Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7074/?format=api
{ "id": 7074, "url": "http://patches.dpdk.org/api/patches/7074/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1442588473-13122-8-git-send-email-yuanhan.liu@linux.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1442588473-13122-8-git-send-email-yuanhan.liu@linux.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1442588473-13122-8-git-send-email-yuanhan.liu@linux.intel.com", "date": "2015-09-18T15:01:08", "name": "[dpdk-dev,v5,07/12] virtio: resolve for control queue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1462b04ab36bc6f478e9d2dbb367840a87a26145", "submitter": { "id": 307, "url": "http://patches.dpdk.org/api/people/307/?format=api", "name": "Yuanhan Liu", "email": "yuanhan.liu@linux.intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1442588473-13122-8-git-send-email-yuanhan.liu@linux.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/7074/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/7074/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A6B628E71;\n\tFri, 18 Sep 2015 17:00:02 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 7A8C48E6A\n\tfor <dev@dpdk.org>; Fri, 18 Sep 2015 16:59:59 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 18 Sep 2015 07:59:59 -0700", "from yliu-dev.sh.intel.com ([10.239.66.60])\n\tby orsmga003.jf.intel.com with ESMTP; 18 Sep 2015 07:59:57 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,553,1437462000\"; d=\"scan'208\";a=\"647571834\"", "From": "Yuanhan Liu <yuanhan.liu@linux.intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 18 Sep 2015 23:01:08 +0800", "Message-Id": "<1442588473-13122-8-git-send-email-yuanhan.liu@linux.intel.com>", "X-Mailer": "git-send-email 1.9.0", "In-Reply-To": "<1442588473-13122-1-git-send-email-yuanhan.liu@linux.intel.com>", "References": "<1442588473-13122-1-git-send-email-yuanhan.liu@linux.intel.com>", "Cc": "\"Michael S. Tsirkin\" <mst@redhat.com>, hangchun.ouyang@hotmail.com", "Subject": "[dpdk-dev] [PATCH v5 07/12] virtio: resolve for control queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Changchun Ouyang <changchun.ouyang@intel.com>\n\nFix the max virtio queue pair read issue.\n\nControl queue can't work for vhost-user mulitple queue mode,\nso introduce a counter to void the dead loop when polling\nthe control queue.\n\nSigned-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\nSigned-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 465d3cd..b2f4120 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1162,7 +1162,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \tstruct virtio_hw *hw = eth_dev->data->dev_private;\n \tstruct virtio_net_config *config;\n \tstruct virtio_net_config local_config;\n-\tuint32_t offset_conf = sizeof(config->mac);\n \tstruct rte_pci_device *pci_dev;\n \n \tRTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr));\n@@ -1222,7 +1221,9 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \t\tconfig = &local_config;\n \n \t\tif (vtpci_with_feature(hw, VIRTIO_NET_F_STATUS)) {\n-\t\t\toffset_conf += sizeof(config->status);\n+\t\t\tvtpci_read_dev_config(hw,\n+\t\t\t\toffsetof(struct virtio_net_config, status),\n+\t\t\t\t&config->status, sizeof(config->status));\n \t\t} else {\n \t\t\tPMD_INIT_LOG(DEBUG,\n \t\t\t\t \"VIRTIO_NET_F_STATUS is not supported\");\n@@ -1230,15 +1231,16 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)\n \t\t}\n \n \t\tif (vtpci_with_feature(hw, VIRTIO_NET_F_MQ)) {\n-\t\t\toffset_conf += sizeof(config->max_virtqueue_pairs);\n+\t\t\tvtpci_read_dev_config(hw,\n+\t\t\t\toffsetof(struct virtio_net_config, max_virtqueue_pairs),\n+\t\t\t\t&config->max_virtqueue_pairs,\n+\t\t\t\tsizeof(config->max_virtqueue_pairs));\n \t\t} else {\n \t\t\tPMD_INIT_LOG(DEBUG,\n \t\t\t\t \"VIRTIO_NET_F_MQ is not supported\");\n \t\t\tconfig->max_virtqueue_pairs = 1;\n \t\t}\n \n-\t\tvtpci_read_dev_config(hw, 0, (uint8_t *)config, offset_conf);\n-\n \t\thw->max_rx_queues =\n \t\t\t(VIRTIO_MAX_RX_QUEUES < config->max_virtqueue_pairs) ?\n \t\t\tVIRTIO_MAX_RX_QUEUES : config->max_virtqueue_pairs;\n", "prefixes": [ "dpdk-dev", "v5", "07/12" ] }