Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70491/?format=api
{ "id": 70491, "url": "http://patches.dpdk.org/api/patches/70491/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200521080306.17404-1-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200521080306.17404-1-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200521080306.17404-1-wei.zhao1@intel.com", "date": "2020-05-21T08:03:06", "name": "[v2] net/i40e: fix flow FDIR enable issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ba5eb3d78e6c734eed92df603a99d78a352fd64", "submitter": { "id": 495, "url": "http://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200521080306.17404-1-wei.zhao1@intel.com/mbox/", "series": [ { "id": 10186, "url": "http://patches.dpdk.org/api/series/10186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10186", "date": "2020-05-21T08:03:06", "name": "[v2] net/i40e: fix flow FDIR enable issue", "version": 2, "mbox": "http://patches.dpdk.org/series/10186/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70491/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70491/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15542A0093;\n\tThu, 21 May 2020 10:26:34 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD3241D66A;\n\tThu, 21 May 2020 10:26:33 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 920C71D66A;\n Thu, 21 May 2020 10:26:31 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 May 2020 01:26:30 -0700", "from unknown (HELO localhost.localdomain.bj.intel.com)\n ([172.16.182.123])\n by orsmga005.jf.intel.com with ESMTP; 21 May 2020 01:26:28 -0700" ], "IronPort-SDR": [ "\n +CV6WCya4pzTFp7/pwI+/kpAKUA3zE5y7EDsZiMxhGFo6JAXM2bTdA/1qG2HBpBNwcfLmtO4hF\n xe/jdwtbqhHg==", "\n hzD1SV46OHIcHHehvzV3AKm6DJLZYasWUNRfhdCETZdVnBauiTI5KfwiKvDSWd+ciJLvBizInc\n q9qALt2cdmHQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,417,1583222400\"; d=\"scan'208\";a=\"440361215\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, beilei.xing@intel.com, jia.guo@intel.com,\n xiaolong.ye@intel.com, Wei Zhao <wei.zhao1@intel.com>", "Date": "Thu, 21 May 2020 16:03:06 +0800", "Message-Id": "<20200521080306.17404-1-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20200519071652.26537-1-wei.zhao1@intel.com>", "References": "<20200519071652.26537-1-wei.zhao1@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix flow FDIR enable issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we flush flow FDIR, all queues are disabled for FDIR.\nIf FDIR rule is created again, then the flow list is empty,\nas it is the first time to create rule after flush fdir filter,\nso we need to enable FDIR for all queues. And also, disable FDIR\nfor queues should be done in function i40e_flow_flush_fdir_filter().\n\nFixes: 1491f63c7559 (\"net/i40e: fix flush of flow director filter\")\nFixes: 6ae9b2b5e8c2 (\"net/i40e: cache flow director enable value in Rx queue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n\n---\n\nv2:\nupdate log info\n---\n drivers/net/i40e/i40e_flow.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 25c77e7aa..8f8df6fae 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -3462,6 +3462,10 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,\n \t\t}\n \t}\n \n+\t/* If create the first fdir rule, enable fdir check for rx queues */\n+\tif (TAILQ_EMPTY(&pf->fdir.fdir_list))\n+\t\ti40e_fdir_rx_proc_enable(dev, 1);\n+\n \treturn 0;\n err:\n \ti40e_fdir_teardown(pf);\n@@ -5330,9 +5334,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \t\treturn -rte_errno;\n \t}\n \n-\t/* Disable FDIR processing as all FDIR rules are now flushed */\n-\ti40e_fdir_rx_proc_enable(dev, 0);\n-\n \treturn ret;\n }\n \n@@ -5368,6 +5369,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)\n \t\tfor (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP;\n \t\t pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++)\n \t\t\tpf->fdir.inset_flag[pctype] = 0;\n+\n+\t\t/* Disable FDIR processing as all FDIR rules are now flushed */\n+\t\ti40e_fdir_rx_proc_enable(dev, 0);\n \t}\n \n \treturn ret;\n", "prefixes": [ "v2" ] }