Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70339/?format=api
{ "id": 70339, "url": "http://patches.dpdk.org/api/patches/70339/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200515184542.89318-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200515184542.89318-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200515184542.89318-3-ajit.khaparde@broadcom.com", "date": "2020-05-15T18:45:35", "name": "[v1,2/9] net/bnxt: fix to alloc LED config info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4755af78e131dbeb5802a7674cba5ad502ce9565", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200515184542.89318-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 10105, "url": "http://patches.dpdk.org/api/series/10105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10105", "date": "2020-05-15T18:45:33", "name": "bug fixes for bnxt PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/10105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70339/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/70339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 45B01A00C3;\n\tFri, 15 May 2020 20:46:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA54B1DB03;\n\tFri, 15 May 2020 20:45:54 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id B0CE91DABD;\n Fri, 15 May 2020 20:45:50 +0200 (CEST)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 21A1630C0B0;\n Fri, 15 May 2020 11:44:43 -0700 (PDT)", "from localhost.localdomain (unknown [10.230.185.215])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 5A5F914008C;\n Fri, 15 May 2020 11:45:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 21A1630C0B0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1589568283;\n bh=FpYX6ncPzb6yPvlp9j2j/VlmiB0D88JBni9SspH0CO0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Cbyiz0YkuflsGAf2lrKIl27QJU63cpTmNk4hH79QAw58fwZn0ECz++lvefO7opxXu\n RKHS32dLKkygX8r4JKM1PyIinI51jQT6dAS27iMP8bXEYHBuhIAhOCqrUt+x/8X7Vp\n ziZNMKcLxg8PGyMtkowxc7ld/ZhoVBhKL/Bhetuc=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Fri, 15 May 2020 11:45:35 -0700", "Message-Id": "<20200515184542.89318-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200515184542.89318-1-ajit.khaparde@broadcom.com>", "References": "<20200515184542.89318-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 2/9] net/bnxt: fix to alloc LED config info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Dynamically allocate bnxt_led_cfg.\nThis helps reduces memory footprint of struct bnxt.\n\nFixes: bb81e07323b (\"net/bnxt: support LED on/off\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 4 ++--\n drivers/net/bnxt/bnxt_ethdev.c | 23 +++++++++++++++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 14 +++++++-------\n 3 files changed, 32 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex bf5b39cd3..f4b39b345 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -147,6 +147,7 @@\n #define BNXT_NUM_CMPL_DMA_AGGR_DURING_INT\t12\n \n struct bnxt_led_info {\n+\tuint8_t\t num_leds;\n \tuint8_t led_id;\n \tuint8_t led_type;\n \tuint8_t led_group_id;\n@@ -686,8 +687,7 @@ struct bnxt {\n \tuint32_t\t\tfw_ver;\n \tuint32_t\t\thwrm_spec_code;\n \n-\tstruct bnxt_led_info\tleds[BNXT_MAX_LED];\n-\tuint8_t\t\t\tnum_leds;\n+\tstruct bnxt_led_info\t*leds;\n \tstruct bnxt_ptp_cfg *ptp_cfg;\n \tuint16_t\t\tvf_resv_strategy;\n \tstruct bnxt_ctx_mem_info *ctx;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 2ba9d6bad..3bd30dfa1 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -191,6 +191,12 @@ static uint16_t bnxt_rss_hash_tbl_size(const struct bnxt *bp)\n \treturn bnxt_rss_ctxts(bp) * BNXT_RSS_ENTRIES_PER_CTX_THOR;\n }\n \n+static void bnxt_free_leds_info(struct bnxt *bp)\n+{\n+\trte_free(bp->leds);\n+\tbp->leds = NULL;\n+}\n+\n static void bnxt_free_mem(struct bnxt *bp, bool reconfig)\n {\n \tbnxt_free_filter_mem(bp);\n@@ -213,6 +219,17 @@ static void bnxt_free_mem(struct bnxt *bp, bool reconfig)\n \tbp->grp_info = NULL;\n }\n \n+static int bnxt_alloc_leds_info(struct bnxt *bp)\n+{\n+\tbp->leds = rte_zmalloc(\"bnxt_leds\",\n+\t\t\t BNXT_MAX_LED * sizeof(struct bnxt_led_info),\n+\t\t\t 0);\n+\tif (bp->leds == NULL)\n+\t\treturn -ENOMEM;\n+\n+\treturn 0;\n+}\n+\n static int bnxt_alloc_mem(struct bnxt *bp, bool reconfig)\n {\n \tint rc;\n@@ -1216,6 +1233,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \n \tbnxt_uninit_resources(bp, false);\n \n+\tbnxt_free_leds_info(bp);\n+\n \teth_dev->dev_ops = NULL;\n \teth_dev->rx_pkt_burst = NULL;\n \teth_dev->tx_pkt_burst = NULL;\n@@ -5359,6 +5378,10 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t \"Failed to allocate hwrm resource rc: %x\\n\", rc);\n \t\tgoto error_free;\n \t}\n+\trc = bnxt_alloc_leds_info(bp);\n+\tif (rc)\n+\t\tgoto error_free;\n+\n \trc = bnxt_init_resources(bp, false);\n \tif (rc)\n \t\tgoto error_free;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d80d67a2d..148000934 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -3900,17 +3900,17 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)\n \tif (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {\n \t\tunsigned int i;\n \n-\t\tbp->num_leds = resp->num_leds;\n+\t\tbp->leds->num_leds = resp->num_leds;\n \t\tmemcpy(bp->leds, &resp->led0_id,\n-\t\t\tsizeof(bp->leds[0]) * bp->num_leds);\n-\t\tfor (i = 0; i < bp->num_leds; i++) {\n+\t\t\tsizeof(bp->leds[0]) * bp->leds->num_leds);\n+\t\tfor (i = 0; i < bp->leds->num_leds; i++) {\n \t\t\tstruct bnxt_led_info *led = &bp->leds[i];\n \n \t\t\tuint16_t caps = led->led_state_caps;\n \n \t\t\tif (!led->led_group_id ||\n \t\t\t\t!BNXT_LED_ALT_BLINK_CAP(caps)) {\n-\t\t\t\tbp->num_leds = 0;\n+\t\t\t\tbp->leds->num_leds = 0;\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n@@ -3930,7 +3930,7 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on)\n \tuint16_t duration = 0;\n \tint rc, i;\n \n-\tif (!bp->num_leds || BNXT_VF(bp))\n+\tif (!bp->leds->num_leds || BNXT_VF(bp))\n \t\treturn -EOPNOTSUPP;\n \n \tHWRM_PREP(&req, HWRM_PORT_LED_CFG, BNXT_USE_CHIMP_MB);\n@@ -3940,9 +3940,9 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on)\n \t\tduration = rte_cpu_to_le_16(500);\n \t}\n \treq.port_id = bp->pf.port_id;\n-\treq.num_leds = bp->num_leds;\n+\treq.num_leds = bp->leds->num_leds;\n \tled_cfg = (struct bnxt_led_cfg *)&req.led0_id;\n-\tfor (i = 0; i < bp->num_leds; i++, led_cfg++) {\n+\tfor (i = 0; i < bp->leds->num_leds; i++, led_cfg++) {\n \t\treq.enables |= BNXT_LED_DFLT_ENABLES(i);\n \t\tled_cfg->led_id = bp->leds[i].led_id;\n \t\tled_cfg->led_state = led_state;\n", "prefixes": [ "v1", "2/9" ] }