Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70321/?format=api
{ "id": 70321, "url": "http://patches.dpdk.org/api/patches/70321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200515094752.28490-10-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200515094752.28490-10-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200515094752.28490-10-hemant.agrawal@nxp.com", "date": "2020-05-15T09:47:48", "name": "[v8,09/13] bus/dpaa: share qman portal ids as function calls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "07ee1c692a981728d5ce60bce61273eaa4c1aad0", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200515094752.28490-10-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10095, "url": "http://patches.dpdk.org/api/series/10095/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10095", "date": "2020-05-15T09:47:39", "name": "NXP DPAAx: move internal symbols to INTERNAL", "version": 8, "mbox": "http://patches.dpdk.org/series/10095/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70321/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 961D1A00C3;\n\tFri, 15 May 2020 11:51:42 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E8411DAFB;\n\tFri, 15 May 2020 11:50:43 +0200 (CEST)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id AF7321DAC4\n for <dev@dpdk.org>; Fri, 15 May 2020 11:50:27 +0200 (CEST)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8730E200748;\n Fri, 15 May 2020 11:50:27 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 829262005FF;\n Fri, 15 May 2020 11:50:25 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id CBED84031D;\n Fri, 15 May 2020 17:50:22 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tmdr@ashroe.eu", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Fri, 15 May 2020 15:17:48 +0530", "Message-Id": "<20200515094752.28490-10-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200515094752.28490-1-hemant.agrawal@nxp.com>", "References": "<20200514132533.13752-1-hemant.agrawal@nxp.com>\n <20200515094752.28490-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v8 09/13] bus/dpaa: share qman portal ids as\n\tfunction calls", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "qman caam and pool portal ids are only used in control\npath. This patch changes their inter library access to\nfunction call instead of direct shared variable.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++++++++++\n drivers/bus/dpaa/include/fsl_qman.h | 8 +++++++-\n drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 ++--\n drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-\n 4 files changed, 20 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c\nindex 69244ef701..1166d68e21 100644\n--- a/drivers/bus/dpaa/base/qbman/qman_driver.c\n+++ b/drivers/bus/dpaa/base/qbman/qman_driver.c\n@@ -30,6 +30,16 @@ static __thread struct dpaa_ioctl_portal_map map = {\n \t.type = dpaa_portal_qman\n };\n \n+u16 dpaa_get_qm_channel_caam(void)\n+{\n+\treturn qm_channel_caam;\n+}\n+\n+u16 dpaa_get_qm_channel_pool(void)\n+{\n+\treturn qm_channel_pool1;\n+}\n+\n static int fsl_qman_portal_init(uint32_t index, int is_shared)\n {\n \tstruct qman_portal *portal;\ndiff --git a/drivers/bus/dpaa/include/fsl_qman.h b/drivers/bus/dpaa/include/fsl_qman.h\nindex 4411bb0a79..78b698f393 100644\n--- a/drivers/bus/dpaa/include/fsl_qman.h\n+++ b/drivers/bus/dpaa/include/fsl_qman.h\n@@ -44,6 +44,12 @@ enum qm_dc_portal {\n \tqm_dc_portal_pme = 3\n };\n \n+__rte_internal\n+u16 dpaa_get_qm_channel_caam(void);\n+\n+__rte_internal\n+u16 dpaa_get_qm_channel_pool(void);\n+\n /* Portal processing (interrupt) sources */\n #define QM_PIRQ_CCSCI\t0x00200000\t/* CEETM Congestion State Change */\n #define QM_PIRQ_CSCI\t0x00100000\t/* Congestion State Change */\n@@ -65,7 +71,7 @@ enum qm_dc_portal {\n /* for conversion from n of qm_channel */\n static inline u32 QM_SDQCR_CHANNELS_POOL_CONV(u16 channel)\n {\n-\treturn QM_SDQCR_CHANNELS_POOL(channel + 1 - qm_channel_pool1);\n+\treturn QM_SDQCR_CHANNELS_POOL(channel + 1 - dpaa_get_qm_channel_pool());\n }\n \n /* For qman_volatile_dequeue(); Choose one PRECEDENCE. EXACT is optional. Use\ndiff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map\nindex 53732289d3..8bb2757e04 100644\n--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map\n+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map\n@@ -12,6 +12,8 @@ INTERNAL {\n \tbman_query_free_buffers;\n \tbman_release;\n \tbman_thread_irq;\n+\tdpaa_get_qm_channel_caam;\n+\tdpaa_get_qm_channel_pool;\n \tdpaa_logtype_eventdev;\n \tdpaa_logtype_mempool;\n \tdpaa_logtype_pmd;\n@@ -50,8 +52,6 @@ INTERNAL {\n \tnetcfg_release;\n \tper_lcore_dpaa_io;\n \tper_lcore_held_bufs;\n-\tqm_channel_caam;\n-\tqm_channel_pool1;\n \tqman_alloc_cgrid_range;\n \tqman_alloc_pool_range;\n \tqman_clear_irq;\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex 25dcbd259a..4af9024a00 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -123,7 +123,7 @@ dpaa_sec_init_rx(struct qman_fq *fq_in, rte_iova_t hwdesc,\n \n \tqm_fqd_context_a_set64(&fq_opts.fqd, hwdesc);\n \tfq_opts.fqd.context_b = fqid_out;\n-\tfq_opts.fqd.dest.channel = qm_channel_caam;\n+\tfq_opts.fqd.dest.channel = dpaa_get_qm_channel_caam();\n \tfq_opts.fqd.dest.wq = 0;\n \n \tfq_in->cb.ern = ern_sec_fq_handler;\n", "prefixes": [ "v8", "09/13" ] }