Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70247/?format=api
http://patches.dpdk.org/api/patches/70247/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200514132533.13752-5-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200514132533.13752-5-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200514132533.13752-5-hemant.agrawal@nxp.com", "date": "2020-05-14T13:25:24", "name": "[v4,04/13] crypto: move internal symbols into INTERNAL section", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f01b3f60e491fd9bbe0d918aa2639166a87e42e1", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200514132533.13752-5-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10068, "url": "http://patches.dpdk.org/api/series/10068/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10068", "date": "2020-05-14T13:25:20", "name": "NXP DPAAx: move internal symbols to INTERNAL", "version": 4, "mbox": "http://patches.dpdk.org/series/10068/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70247/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70247/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F18BCA0352;\n\tThu, 14 May 2020 15:28:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 27E8A1D94C;\n\tThu, 14 May 2020 15:28:10 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id D91351D91B\n for <dev@dpdk.org>; Thu, 14 May 2020 15:28:02 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id BA1711A02E1;\n Thu, 14 May 2020 15:28:02 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id AF8391A0372;\n Thu, 14 May 2020 15:28:00 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id C0E91402E0;\n Thu, 14 May 2020 21:27:57 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com,\n\tmdr@ashroe.eu", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Thu, 14 May 2020 18:55:24 +0530", "Message-Id": "<20200514132533.13752-5-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200514132533.13752-1-hemant.agrawal@nxp.com>", "References": "<20200513132745.9006-1-hemant.agrawal@nxp.com>\n <20200514132533.13752-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v4 04/13] crypto: move internal symbols into\n\tINTERNAL section", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch moves the internal symbols to INTERNAL sections\nso that any change in them is not reported as ABI breakage.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n devtools/libabigail.abignore | 4 ++++\n drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++--\n drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 2 +-\n drivers/crypto/dpaa_sec/dpaa_sec_event.h | 8 ++++----\n drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map | 4 +---\n 5 files changed, 13 insertions(+), 10 deletions(-)", "diff": "diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex ab34302d0c..8db64f267d 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -55,3 +55,7 @@\n \tfile_name_regexp = ^librte_bus_fslmc\\.\n [suppress_file]\n \tfile_name_regexp = ^librte_bus_dpaa\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_pmd_dpaa2_sec\\.\n+[suppress_file]\n+\tfile_name_regexp = ^librte_pmd_dpaa_sec\\.\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h\nindex c779d5d837..675cbbb81d 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_event.h\n@@ -6,12 +6,13 @@\n #ifndef _DPAA2_SEC_EVENT_H_\n #define _DPAA2_SEC_EVENT_H_\n \n-int\n-dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,\n+__rte_internal\n+int dpaa2_sec_eventq_attach(const struct rte_cryptodev *dev,\n \t\tint qp_id,\n \t\tstruct dpaa2_dpcon_dev *dpcon,\n \t\tconst struct rte_event *event);\n \n+__rte_internal\n int dpaa2_sec_eventq_detach(const struct rte_cryptodev *dev,\n \t\tint qp_id);\n \ndiff --git a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map\nindex 5952d645fd..1352f576e5 100644\n--- a/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map\n+++ b/drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map\n@@ -1,4 +1,4 @@\n-DPDK_20.0 {\n+INTERNAL {\n \tglobal:\n \n \tdpaa2_sec_eventq_attach;\ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec_event.h b/drivers/crypto/dpaa_sec/dpaa_sec_event.h\nindex 8d1a018096..0b09fa8f75 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec_event.h\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec_event.h\n@@ -6,14 +6,14 @@\n #ifndef _DPAA_SEC_EVENT_H_\n #define _DPAA_SEC_EVENT_H_\n \n-int\n-dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,\n+__rte_internal\n+int dpaa_sec_eventq_attach(const struct rte_cryptodev *dev,\n \t\tint qp_id,\n \t\tuint16_t ch_id,\n \t\tconst struct rte_event *event);\n \n-int\n-dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,\n+__rte_internal\n+int dpaa_sec_eventq_detach(const struct rte_cryptodev *dev,\n \t\tint qp_id);\n \n #endif /* _DPAA_SEC_EVENT_H_ */\ndiff --git a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map\nindex 8580fa13db..aed07fb371 100644\n--- a/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map\n+++ b/drivers/crypto/dpaa_sec/rte_pmd_dpaa_sec_version.map\n@@ -1,8 +1,6 @@\n-DPDK_20.0 {\n+INTERNAL {\n \tglobal:\n \n \tdpaa_sec_eventq_attach;\n \tdpaa_sec_eventq_detach;\n-\n-\tlocal: *;\n };\n", "prefixes": [ "v4", "04/13" ] }{ "id": 70247, "url": "