Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70145/?format=api
http://patches.dpdk.org/api/patches/70145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200513202128.112290-2-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200513202128.112290-2-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200513202128.112290-2-jia.guo@intel.com", "date": "2020-05-13T20:21:28", "name": "[v2,2/2] net/iavf: fix rss algorithm configure issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "54f68416e256e4dfb122bcdfdc7bf914f4865975", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200513202128.112290-2-jia.guo@intel.com/mbox/", "series": [ { "id": 10017, "url": "http://patches.dpdk.org/api/series/10017/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10017", "date": "2020-05-13T20:21:27", "name": "[v2,1/2] common/iavf: fix typo of rss algorithm type", "version": 2, "mbox": "http://patches.dpdk.org/series/10017/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70145/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/70145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 02ADAA034F;\n\tWed, 13 May 2020 10:22:12 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 737871C435;\n\tWed, 13 May 2020 10:22:04 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 546711C246\n for <dev@dpdk.org>; Wed, 13 May 2020 10:22:01 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 May 2020 01:22:00 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by fmsmga006.fm.intel.com with ESMTP; 13 May 2020 01:21:59 -0700" ], "IronPort-SDR": [ "\n udBvb3OP34y29LFE1EcEtUP3G+XUzEGC71RrdimzCBcfq+Ns7qQRWyBj0pcWhKG4VOcBB6AJdw\n ZaaifmRV6klQ==", "\n o6gWGiccnNr21l6E/A2fijGiZyQyu9AsB55FG09GNnUj/eTTMktl159vfOt39A+N6j4xLuY1Vx\n zjOZg1GXQhuA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,387,1583222400\"; d=\"scan'208\";a=\"464052861\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "beilei.xing@intel.com, xiaolong.ye@intel.com, qi.z.zhang@intel.com,\n jingjing.wu@intel.com", "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com", "Date": "Wed, 13 May 2020 16:21:28 -0400", "Message-Id": "<20200513202128.112290-2-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200513202128.112290-1-jia.guo@intel.com>", "References": "<20200509202730.70367-1-jia.guo@intel.com>\n <20200513202128.112290-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev v2 2/2] net/iavf: fix rss algorithm configure\n\tissue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When configure rss rule, the etherdev rss hash function type should be\nmapped to the corresponding virtchnl rss algorithm type.\n\nFixes: 7be10c3004be (\"net/iavf: add RSS configuration for VF\")\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv2->v1:\nfix a type for xor.\n---\n drivers/net/iavf/iavf_hash.c | 20 +++++++++++---------\n 1 file changed, 11 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c\nindex 6359ead76..975c84556 100644\n--- a/drivers/net/iavf/iavf_hash.c\n+++ b/drivers/net/iavf/iavf_hash.c\n@@ -47,7 +47,7 @@ struct iavf_hash_match_type {\n \n struct iavf_rss_meta {\n \tstruct virtchnl_proto_hdrs *proto_hdrs;\n-\tuint32_t hash_function;\n+\tenum virtchnl_rss_algorithm rss_algorithm;\n };\n \n struct iavf_hash_flow_cfg {\n@@ -1001,13 +1001,15 @@ iavf_hash_parse_action(struct iavf_pattern_match_item *pattern_match_item,\n \n \t\t\t/* Check hash function and save it to rss_meta. */\n \t\t\tif (rss->func == RTE_ETH_HASH_FUNCTION_SIMPLE_XOR)\n-\t\t\t\trss_meta->hash_function =\n-\t\t\t\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR;\n-\n-\t\t\tif (rss->func ==\n-\t\t\t RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)\n-\t\t\t\trss_meta->hash_function =\n-\t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ;\n+\t\t\t\trss_meta->rss_algorithm =\n+\t\t\t\t\tVIRTCHNL_RSS_ALG_XOR_ASYMMETRIC;\n+\t\t\telse if (rss->func ==\n+\t\t\t\t RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)\n+\t\t\t\trss_meta->rss_algorithm =\n+\t\t\t\t\tVIRTCHNL_RSS_ALG_TOEPLITZ_SYMMETRIC;\n+\t\t\telse\n+\t\t\t\trss_meta->rss_algorithm =\n+\t\t\t\t\tVIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC;\n \n \t\t\ttype_match_item =\n \t\t\trte_zmalloc(\"iavf_type_match_item\",\n@@ -1126,7 +1128,7 @@ iavf_hash_create(__rte_unused struct iavf_adapter *ad,\n \t}\n \n \trss_cfg->proto_hdrs = *rss_meta->proto_hdrs;\n-\trss_cfg->rss_algorithm = rss_meta->hash_function;\n+\trss_cfg->rss_algorithm = rss_meta->rss_algorithm;\n \n \tret = iavf_add_del_rss_cfg(ad, rss_cfg, true);\n \tif (!ret) {\n", "prefixes": [ "v2", "2/2" ] }{ "id": 70145, "url": "