Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70123/?format=api
{ "id": 70123, "url": "http://patches.dpdk.org/api/patches/70123/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200512140100.26803-12-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200512140100.26803-12-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200512140100.26803-12-hemant.agrawal@nxp.com", "date": "2020-05-12T14:01:00", "name": "[v2,12/12] bus/dpaa: change netcfg access as function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a1fda3dbf18644e33ccc3df7a875719ff2f0c908", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200512140100.26803-12-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 10002, "url": "http://patches.dpdk.org/api/series/10002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=10002", "date": "2020-05-12T14:00:49", "name": "[v2,01/12] common/dpaax: move internal symbols into INTERNAL section", "version": 2, "mbox": "http://patches.dpdk.org/series/10002/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70123/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70123/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D28CDA04A2;\n\tTue, 12 May 2020 16:05:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1CFA41C220;\n\tTue, 12 May 2020 16:03:46 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by dpdk.org (Postfix) with ESMTP id 756D31BFEF\n for <dev@dpdk.org>; Tue, 12 May 2020 16:03:30 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 54F3A1A10D6;\n Tue, 12 May 2020 16:03:30 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id A88261A10D3;\n Tue, 12 May 2020 16:03:28 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n [10.232.133.63])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 753E2402E1;\n Tue, 12 May 2020 22:03:26 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 12 May 2020 19:31:00 +0530", "Message-Id": "<20200512140100.26803-12-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200512140100.26803-1-hemant.agrawal@nxp.com>", "References": "<20200505140832.646-1-hemant.agrawal@nxp.com>\n <20200512140100.26803-1-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 12/12] bus/dpaa: change netcfg access as\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch changes the export of fman port config\nas function call instead of direct variable access.\nThis is in control path, so it will not impact perf.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/dpaa/dpaa_bus.c | 6 ++++++\n drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 +\n drivers/bus/dpaa/rte_dpaa_bus.h | 6 +++---\n drivers/net/dpaa/dpaa_ethdev.c | 2 +-\n 4 files changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c\nindex 41d42b0c30..d53fe6083a 100644\n--- a/drivers/bus/dpaa/dpaa_bus.c\n+++ b/drivers/bus/dpaa/dpaa_bus.c\n@@ -57,6 +57,12 @@ unsigned int dpaa_svr_family;\n RTE_DEFINE_PER_LCORE(bool, dpaa_io);\n RTE_DEFINE_PER_LCORE(struct dpaa_portal_dqrr, held_bufs);\n \n+struct fm_eth_port_cfg *\n+dpaa_get_eth_port_cfg(int dev_id)\n+{\n+\treturn &dpaa_netcfg->port_cfg[dev_id];\n+}\n+\n static int\n compare_dpaa_devices(struct rte_dpaa_device *dev1,\n \t\t struct rte_dpaa_device *dev2)\ndiff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map\nindex 9b02cc674c..1d6bd39f4d 100644\n--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map\n+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map\n@@ -8,6 +8,7 @@ INTERNAL {\n \tbman_query_free_buffers;\n \tbman_release;\n \tbman_thread_irq;\n+\tdpaa_get_eth_port_cfg;\n \tdpaa_get_qm_channel_caam;\n \tdpaa_get_qm_channel_pool;\n \tdpaa_svr_family;\ndiff --git a/drivers/bus/dpaa/rte_dpaa_bus.h b/drivers/bus/dpaa/rte_dpaa_bus.h\nindex d4aee132ef..2a186d83fb 100644\n--- a/drivers/bus/dpaa/rte_dpaa_bus.h\n+++ b/drivers/bus/dpaa/rte_dpaa_bus.h\n@@ -44,9 +44,6 @@ struct rte_dpaa_driver;\n TAILQ_HEAD(rte_dpaa_device_list, rte_dpaa_device);\n TAILQ_HEAD(rte_dpaa_driver_list, rte_dpaa_driver);\n \n-/* Configuration variables exported from DPAA bus */\n-extern struct netcfg_info *dpaa_netcfg;\n-\n enum rte_dpaa_type {\n \tFSL_DPAA_ETH = 1,\n \tFSL_DPAA_CRYPTO,\n@@ -217,6 +214,9 @@ RTE_DECLARE_PER_LCORE(struct dpaa_portal_dqrr, held_bufs);\n #define DPAA_PER_LCORE_DQRR_HELD RTE_PER_LCORE(held_bufs).dqrr_held\n #define DPAA_PER_LCORE_DQRR_MBUF(i) RTE_PER_LCORE(held_bufs).mbuf[i]\n \n+__rte_internal\n+struct fm_eth_port_cfg *dpaa_get_eth_port_cfg(int dev_id);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex c97f3042be..13d1c6a1fc 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1332,7 +1332,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \tdpaa_device = DEV_TO_DPAA_DEVICE(eth_dev->device);\n \tdev_id = dpaa_device->id.dev_id;\n \tdpaa_intf = eth_dev->data->dev_private;\n-\tcfg = &dpaa_netcfg->port_cfg[dev_id];\n+\tcfg = dpaa_get_eth_port_cfg(dev_id);\n \tfman_intf = cfg->fman_if;\n \n \tdpaa_intf->name = dpaa_device->name;\n", "prefixes": [ "v2", "12/12" ] }