Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70086/?format=api
{ "id": 70086, "url": "http://patches.dpdk.org/api/patches/70086/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200511150931.1693-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200511150931.1693-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200511150931.1693-1-david.marchand@redhat.com", "date": "2020-05-11T15:09:31", "name": "telemetry: fix error log output", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8c5875e3915c3c6265d003d93a65ba56522df0ad", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200511150931.1693-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 9986, "url": "http://patches.dpdk.org/api/series/9986/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9986", "date": "2020-05-11T15:09:31", "name": "telemetry: fix error log output", "version": 1, "mbox": "http://patches.dpdk.org/series/9986/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70086/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70086/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8945A0350;\n\tMon, 11 May 2020 17:09:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2EF261C197;\n\tMon, 11 May 2020 17:09:47 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 032AA1C197\n for <dev@dpdk.org>; Mon, 11 May 2020 17:09:44 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-297-HQcJ2QYmMfqtYzBqPrTcSQ-1; Mon, 11 May 2020 11:09:41 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 148618014C0;\n Mon, 11 May 2020 15:09:40 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.236])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 7ECC267642;\n Mon, 11 May 2020 15:09:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1589209783;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=rCjjqzdjrwtOKg23LwnFzjxHrOlXGdDy8DYJknOMxos=;\n b=RUbAtetLNWCS9u2CscCPmOoac2wIqFNZq7wmrOON2cxCq/qkxmWlnVpkCdw6XaHO2gJkQb\n 6Y0l7Xp7WTHu+8c7H5h8NkOcnoXMYzKCOZlwYPHwgeWzo4lA3ZEChVYZk22mvAaGugkjW7\n jvkSmQxpdy0rBI6RSyRBNlfUSQn6y28=", "X-MC-Unique": "HQcJ2QYmMfqtYzBqPrTcSQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Kevin Laatz <kevin.laatz@intel.com>, Ciara Power <ciara.power@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Keith Wiles <keith.wiles@intel.com>", "Date": "Mon, 11 May 2020 17:09:31 +0200", "Message-Id": "<20200511150931.1693-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] telemetry: fix error log output", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Caught while running testpmd:\nNo telemetry legacy support- No legacy callbacks, legacy socket not createdInteractive-mode selected\n\nAdd missing \\n.\n\nFixes: 6dd571fd07c3 (\"telemetry: introduce new functionality\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_telemetry/telemetry.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c\nindex 9a1e945455..56a2fed3f5 100644\n--- a/lib/librte_telemetry/telemetry.c\n+++ b/lib/librte_telemetry/telemetry.c\n@@ -275,8 +275,8 @@ socket_listener(void *socket)\n \t\tint s_accepted = accept(s->sock, NULL, NULL);\n \t\tif (s_accepted < 0) {\n \t\t\tsnprintf(telemetry_log_error,\n-\t\t\t\t\tsizeof(telemetry_log_error),\n-\t\t\t\t\t\"Error with accept, telemetry thread quitting\\n\");\n+\t\t\t\tsizeof(telemetry_log_error),\n+\t\t\t\t\"Error with accept, telemetry thread quitting\");\n \t\t\treturn NULL;\n \t\t}\n \t\tpthread_create(&th, NULL, s->fn, (void *)(uintptr_t)s_accepted);\n@@ -400,12 +400,12 @@ rte_telemetry_init(const char *runtime_dir, const char **err_str)\n {\n \tif (telemetry_v2_init(runtime_dir) != 0) {\n \t\t*err_str = telemetry_log_error;\n-\t\tprintf(\"Error initialising telemetry - %s\", *err_str);\n+\t\tprintf(\"Error initialising telemetry - %s\\n\", *err_str);\n \t\treturn -1;\n \t}\n \tif (telemetry_legacy_init(runtime_dir) != 0) {\n \t\t*err_str = telemetry_log_error;\n-\t\tprintf(\"No telemetry legacy support- %s\", *err_str);\n+\t\tprintf(\"No telemetry legacy support - %s\\n\", *err_str);\n \t}\n \treturn 0;\n }\n", "prefixes": [] }