Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/70069/?format=api
{ "id": 70069, "url": "http://patches.dpdk.org/api/patches/70069/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com", "date": "2020-05-11T10:25:13", "name": "meson: error out on failed kernel module builds", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "011a4878ddd762007fe770f449e2e9a09afac019", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 9978, "url": "http://patches.dpdk.org/api/series/9978/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9978", "date": "2020-05-11T10:25:13", "name": "meson: error out on failed kernel module builds", "version": 1, "mbox": "http://patches.dpdk.org/series/9978/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/70069/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/70069/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C9ADA0350;\n\tMon, 11 May 2020 12:25:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D9C471C138;\n\tMon, 11 May 2020 12:25:15 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id B45891C129\n for <dev@dpdk.org>; Mon, 11 May 2020 12:25:13 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 May 2020 03:25:12 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.52])\n by orsmga006.jf.intel.com with ESMTP; 11 May 2020 03:25:11 -0700" ], "IronPort-SDR": [ "\n 0oD9W57UF+8a0KMjjLHlr9iFWUffz3X/H5GmDJIIApysAsyZEXeb9FS3oDxYtFfDejYnrzHRfs\n WrIzoB8jlhmQ==", "\n NEGnMHczsXNJ8zEwYVhxHEZaXfwSP+Xrm824KpOuqcX2nhiHBOufVJD3QJZ1+Y6Xi0nE9mgUlX\n TTsrjvZR98Pw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,379,1583222400\"; d=\"scan'208\";a=\"265110472\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com", "Date": "Mon, 11 May 2020 11:25:13 +0100", "Message-Id": "\n <e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] meson: error out on failed kernel module builds", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that kernel modules aren't built by default, we can be more\nstrict with their build process, and fail the build if they were\nrequested to be built, but weren't.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n kernel/linux/meson.build | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build\nindex 1796cc6861..da79df1687 100644\n--- a/kernel/linux/meson.build\n+++ b/kernel/linux/meson.build\n@@ -5,8 +5,7 @@ subdirs = ['igb_uio', 'kni']\n \n # if we are cross-compiling we need kernel_dir specified\n if get_option('kernel_dir') == '' and meson.is_cross_build()\n-\twarning('Need \"kernel_dir\" option for kmod compilation when cross-compiling')\n-\tsubdir_done()\n+\terror('Need \"kernel_dir\" option for kmod compilation when cross-compiling')\n endif\n \n kernel_dir = get_option('kernel_dir')\n@@ -20,8 +19,7 @@ endif\n make_returncode = run_command('make', '-sC', kernel_dir + '/build',\n \t\t'kernelversion').returncode()\n if make_returncode != 0\n-\twarning('Cannot compile kernel modules as requested - are kernel headers installed?')\n-\tsubdir_done()\n+\terror('Cannot compile kernel modules as requested - are kernel headers installed?')\n endif\n \n # DO ACTUAL MODULE BUILDING\n", "prefixes": [] }