Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69682/?format=api
{ "id": 69682, "url": "http://patches.dpdk.org/api/patches/69682/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200503203135.6493-5-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200503203135.6493-5-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200503203135.6493-5-david.marchand@redhat.com", "date": "2020-05-03T20:31:31", "name": "[4/8] trace: avoid confusion on optarg", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4b3607967895ff3b481dbf6c4a0ec03d4ed90d9d", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200503203135.6493-5-david.marchand@redhat.com/mbox/", "series": [ { "id": 9796, "url": "http://patches.dpdk.org/api/series/9796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9796", "date": "2020-05-03T20:31:27", "name": "Traces cleanup for rc2", "version": 1, "mbox": "http://patches.dpdk.org/series/9796/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69682/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6D058A04AF;\n\tSun, 3 May 2020 22:32:51 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D41691D532;\n\tSun, 3 May 2020 22:32:25 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6FDBC1D52B\n for <dev@dpdk.org>; Sun, 3 May 2020 22:32:24 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-166-LnhfKoBkO6OPE7Kjmb5sCg-1; Sun, 03 May 2020 16:32:20 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 755CD1895944;\n Sun, 3 May 2020 20:32:19 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.236])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9BC3A6F972;\n Sun, 3 May 2020 20:32:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1588537943;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=jwLArlOAImSvqi3uQvKcXQv4IO8pCHM1WmwREFG8XMQ=;\n b=FvWPDngn/pyU1HLD2EtMEfYEjsm26pfs7DIl+JMPfwb+TWiKLgQgRR0c0dskvWUJKOb/a6\n 0cjdPRVbAc7AeeWKxr3jaM/1YWOjXb10wi6lriysQE/SK1l1PyFHC7N1LGdQRUuqR3AhH6\n nntKKwbcFhYkvh3p+ude3fCxEmIc/D8=", "X-MC-Unique": "LnhfKoBkO6OPE7Kjmb5sCg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>", "Date": "Sun, 3 May 2020 22:31:31 +0200", "Message-Id": "<20200503203135.6493-5-david.marchand@redhat.com>", "In-Reply-To": "<20200503203135.6493-1-david.marchand@redhat.com>", "References": "<20200503203135.6493-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 4/8] trace: avoid confusion on optarg", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Prefer a local name to optarg which is a global symbol from the C library.\n\nFixes: 8c8066ea6a7b (\"trace: add trace mode configuration parameter\")\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n .../common/eal_common_trace_utils.c | 32 +++++++++----------\n lib/librte_eal/common/eal_trace.h | 8 ++---\n 2 files changed, 20 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_trace_utils.c b/lib/librte_eal/common/eal_common_trace_utils.c\nindex fce8892c38..a7c5893b00 100644\n--- a/lib/librte_eal/common/eal_common_trace_utils.c\n+++ b/lib/librte_eal/common/eal_common_trace_utils.c\n@@ -135,7 +135,7 @@ trace_dir_update(const char *str)\n }\n \n int\n-eal_trace_args_save(const char *optarg)\n+eal_trace_args_save(const char *val)\n {\n \tstruct trace *trace = trace_obj_get();\n \tchar *trace_args;\n@@ -144,17 +144,17 @@ eal_trace_args_save(const char *optarg)\n \tnb_args = trace->args.nb_args;\n \n \tif (nb_args >= TRACE_MAX_ARGS) {\n-\t\ttrace_err(\"ignoring trace %s as limit exceeds\", optarg);\n+\t\ttrace_err(\"ignoring trace %s as limit exceeds\", val);\n \t\treturn 0;\n \t}\n \n-\ttrace_args = calloc(1, (strlen(optarg) + 1));\n+\ttrace_args = calloc(1, (strlen(val) + 1));\n \tif (trace_args == NULL) {\n-\t\ttrace_err(\"fail to allocate memory for %s\", optarg);\n+\t\ttrace_err(\"fail to allocate memory for %s\", val);\n \t\treturn -ENOMEM;\n \t}\n \n-\tmemcpy(trace_args, optarg, strlen(optarg));\n+\tmemcpy(trace_args, val, strlen(val));\n \ttrace->args.args[nb_args++] = trace_args;\n \ttrace->args.nb_args = nb_args;\n \treturn 0;\n@@ -194,17 +194,17 @@ trace_args_apply(const char *arg)\n }\n \n int\n-eal_trace_bufsz_args_save(char const *optarg)\n+eal_trace_bufsz_args_save(char const *val)\n {\n \tstruct trace *trace = trace_obj_get();\n \tuint64_t bufsz;\n \n-\tif (optarg == NULL) {\n+\tif (val == NULL) {\n \t\ttrace_err(\"no optarg is passed\");\n \t\treturn -EINVAL;\n \t}\n \n-\tbufsz = rte_str_to_size(optarg);\n+\tbufsz = rte_str_to_size(val);\n \tif (bufsz == 0) {\n \t\ttrace_err(\"buffer size cannot be zero\");\n \t\treturn -EINVAL;\n@@ -224,14 +224,14 @@ trace_bufsz_args_apply(void)\n }\n \n int\n-eal_trace_mode_args_save(const char *optarg)\n+eal_trace_mode_args_save(const char *val)\n {\n \tstruct trace *trace = trace_obj_get();\n-\tsize_t len = strlen(optarg);\n+\tsize_t len = strlen(val);\n \tunsigned long tmp;\n \tchar *pattern;\n \n-\tif (optarg == NULL) {\n+\tif (val == NULL) {\n \t\ttrace_err(\"no optarg is passed\");\n \t\treturn -EINVAL;\n \t}\n@@ -247,7 +247,7 @@ eal_trace_mode_args_save(const char *optarg)\n \t\treturn -ENOMEM;\n \t}\n \n-\tsprintf(pattern, \"%s*\", optarg);\n+\tsprintf(pattern, \"%s*\", val);\n \n \tif (fnmatch(pattern, \"overwrite\", 0) == 0)\n \t\ttmp = RTE_TRACE_MODE_OVERWRITE;\n@@ -264,19 +264,19 @@ eal_trace_mode_args_save(const char *optarg)\n }\n \n int\n-eal_trace_dir_args_save(char const *optarg)\n+eal_trace_dir_args_save(char const *val)\n {\n \tstruct trace *trace = trace_obj_get();\n \tuint32_t size = sizeof(trace->dir);\n \tchar *dir_path = NULL;\n \tint rc;\n \n-\tif (optarg == NULL) {\n+\tif (val == NULL) {\n \t\ttrace_err(\"no optarg is passed\");\n \t\treturn -EINVAL;\n \t}\n \n-\tif (strlen(optarg) >= size) {\n+\tif (strlen(val) >= size) {\n \t\ttrace_err(\"input string is too big\");\n \t\treturn -ENAMETOOLONG;\n \t}\n@@ -287,7 +287,7 @@ eal_trace_dir_args_save(char const *optarg)\n \t\treturn -ENOMEM;\n \t}\n \n-\tsprintf(dir_path, \"%s/\", optarg);\n+\tsprintf(dir_path, \"%s/\", val);\n \trc = trace_dir_update(dir_path);\n \n \tfree(dir_path);\ndiff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h\nindex f53ccc0d50..7d95bd2aa9 100644\n--- a/lib/librte_eal/common/eal_trace.h\n+++ b/lib/librte_eal/common/eal_trace.h\n@@ -111,10 +111,10 @@ void trace_mem_per_thread_free(void);\n /* EAL interface */\n int eal_trace_init(void);\n void eal_trace_fini(void);\n-int eal_trace_args_save(const char *optarg);\n+int eal_trace_args_save(const char *val);\n void eal_trace_args_free(void);\n-int eal_trace_dir_args_save(const char *optarg);\n-int eal_trace_mode_args_save(const char *optarg);\n-int eal_trace_bufsz_args_save(const char *optarg);\n+int eal_trace_dir_args_save(const char *val);\n+int eal_trace_mode_args_save(const char *val);\n+int eal_trace_bufsz_args_save(const char *val);\n \n #endif /* __EAL_TRACE_H */\n", "prefixes": [ "4/8" ] }