Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69651/?format=api
{ "id": 69651, "url": "http://patches.dpdk.org/api/patches/69651/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200501155649.2959-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200501155649.2959-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200501155649.2959-1-harry.van.haaren@intel.com", "date": "2020-05-01T15:56:49", "name": "test/service: add perf test for service on app lcore", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "50db6fa03e4a55a0b89245c637a546ef9a810cd0", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200501155649.2959-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 9781, "url": "http://patches.dpdk.org/api/series/9781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9781", "date": "2020-05-01T15:56:49", "name": "test/service: add perf test for service on app lcore", "version": 1, "mbox": "http://patches.dpdk.org/series/9781/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69651/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/69651/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17FA3A04AD;\n\tFri, 1 May 2020 17:56:00 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 707B11DA40;\n\tFri, 1 May 2020 17:55:59 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 50E841252\n for <dev@dpdk.org>; Fri, 1 May 2020 17:55:57 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 May 2020 08:55:56 -0700", "from silpixa00399779.ir.intel.com (HELO\n silpixa00399779.ger.corp.intel.com) ([10.237.222.209])\n by fmsmga004.fm.intel.com with ESMTP; 01 May 2020 08:55:55 -0700" ], "IronPort-SDR": [ "\n wH2oHanSIEZ/UuvTVw7O/VFBqeQqSR7pTmnBUixQxk1qd6G/rbaqyakEvlZr3OlFAxzzThcwiu\n 92mfe0O9kwWg==", "\n v0T/3X4bbWfB70r+sQCPvw4BUHD8LOVrB+MHDxLVjP78xRx8pDoRXJKIcoW0vjCkFN8JE6H4Bl\n hH76yxP4jqrA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,340,1583222400\"; d=\"scan'208\";a=\"283210557\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "honnappa.nagarahalli@arm.com, phil.yang@arm.com,\n Harry van Haaren <harry.van.haaren@intel.com>", "Date": "Fri, 1 May 2020 16:56:49 +0100", "Message-Id": "<20200501155649.2959-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] test/service: add perf test for service on app\n\tlcore", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a performance test to the service run on app lcore auto-\ntest. This test runs the service in a tight loop, and measures\ncycles passed, printing the results. It provides a quick cycle\ncost value, enabling measuring performance of the function to\nrun a service on an application lcore.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nI'm suggesting to merge this patch before the bugfix/C11 patch series,\n(v2 currently here: http://patches.dpdk.org/patch/69199/ )\nas this would enable users to benchmark the \"before\" and \"after\"\nstates of the bugfix/C11 patches easier.\n\n---\n app/test/test_service_cores.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\nindex a922c7ddc..469243314 100644\n--- a/app/test/test_service_cores.c\n+++ b/app/test/test_service_cores.c\n@@ -789,8 +789,18 @@ service_app_lcore_poll_impl(const int mt_safe)\n \t\t\t\t\"MT Unsafe: App core1 didn't return -EBUSY\");\n \t}\n \n-\tunregister_all();\n+\t/* Performance test: call in a loop, and measure tsc() */\n+\tconst uint32_t perf_iters = (1 << 12);\n+\tuint64_t start = rte_rdtsc();\n+\tfor (uint32_t i = 0; i < perf_iters; i++) {\n+\t\tint err = service_run_on_app_core_func(&id);\n+\t\tTEST_ASSERT_EQUAL(0, err, \"perf test: returned run failure\");\n+\t}\n+\tuint64_t end = rte_rdtsc();\n+\tprintf(\"perf test for %s: %0.1f cycles per call\\n\", mt_safe ?\n+\t\t\"MT Safe\" : \"MT Unsafe\", (end - start)/(float)perf_iters);\n \n+\tunregister_all();\n \treturn TEST_SUCCESS;\n }\n \n", "prefixes": [] }