Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69638/?format=api
{ "id": 69638, "url": "http://patches.dpdk.org/api/patches/69638/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200501110814.67384-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200501110814.67384-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200501110814.67384-1-harry.van.haaren@intel.com", "date": "2020-05-01T11:08:14", "name": "test/flow-classify: fix failure on dual socket systems", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b0ae0f66945647acc4c2d4dc8c2db2354972c52", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200501110814.67384-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 9775, "url": "http://patches.dpdk.org/api/series/9775/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9775", "date": "2020-05-01T11:08:14", "name": "test/flow-classify: fix failure on dual socket systems", "version": 1, "mbox": "http://patches.dpdk.org/series/9775/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69638/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69638/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C5900A04AC;\n\tFri, 1 May 2020 13:07:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 269AE1D9A2;\n\tFri, 1 May 2020 13:07:28 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 754F81D92D;\n Fri, 1 May 2020 13:07:26 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 May 2020 04:07:25 -0700", "from silpixa00399779.ir.intel.com (HELO\n silpixa00399779.ger.corp.intel.com) ([10.237.222.209])\n by orsmga005.jf.intel.com with ESMTP; 01 May 2020 04:07:23 -0700" ], "IronPort-SDR": [ "\n vwWPvtcwUpGfYKORMc+CUUW01qXIKjL+JCTT8Z3yRfq1z7XfC0j551ZIm0T/YnEUDGQpnPktsF\n gxFEkTLUVX6Q==", "\n si7JB256I6EXtIq0FgPHsCWgAtQ7gkCyf19fYYcycnPdGpgt5o+GURzrZsMZo7dr9ygaNgqDU4\n la4JgiLN++MQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,339,1583222400\"; d=\"scan'208\";a=\"433284698\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "bernard.iremonger@intel.com, ferruh.yigit@intel.com,\n Harry van Haaren <harry.van.haaren@intel.com>, stable@dpdk.org", "Date": "Fri, 1 May 2020 12:08:14 +0100", "Message-Id": "<20200501110814.67384-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket\n\tsystems", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit fixes failures of the flow_classify_autotest when\nran on dual-socket servers, as the sample application does not\nsupport more than a single socket. Increasing the NB_SOCKETS\nvalue allows the test to run successfully.\n\nFixes: 9c9befea4f57 (\"test: add flow classify unit tests\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nDPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot\neasily statically allocate the array. As a bugfix patch, I'd\nprefer not add complexity of dynamically allocating based on\nrte_socket_count(), hence just increasing the value seems the\nmost pragmatic fix.\n\nFixes: tag is a bit complex, code was moved in previous commit.\nThis fixes tag is against when the NB_SOCKET = 1 was introduced.\n\nCc: stable@dpdk.org\n\n---\n app/test/test_flow_classify.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c\nindex ff5265c6a..ef0b6fdd5 100644\n--- a/app/test/test_flow_classify.c\n+++ b/app/test/test_flow_classify.c\n@@ -23,7 +23,7 @@\n \n #define FLOW_CLASSIFY_MAX_RULE_NUM 100\n #define MAX_PKT_BURST 32\n-#define NB_SOCKETS 1\n+#define NB_SOCKETS 4\n #define MEMPOOL_CACHE_SIZE 256\n #define MBUF_SIZE 512\n #define NB_MBUF 512\n", "prefixes": [] }