Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69533/?format=api
{ "id": 69533, "url": "http://patches.dpdk.org/api/patches/69533/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200429100831.398-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200429100831.398-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200429100831.398-6-bruce.richardson@intel.com", "date": "2020-04-29T10:08:29", "name": "[5/7] build/pkg-config: output driver libs first for static build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "df79323c734a3e4f4caf9921e66b658aecbe3170", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200429100831.398-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 9730, "url": "http://patches.dpdk.org/api/series/9730/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9730", "date": "2020-04-29T10:08:24", "name": "improve DPDK static builds with meson", "version": 1, "mbox": "http://patches.dpdk.org/series/9730/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69533/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69533/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADEFBA00BE;\n\tWed, 29 Apr 2020 12:14:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BF341D9B4;\n\tWed, 29 Apr 2020 12:13:56 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 397921D939\n for <dev@dpdk.org>; Wed, 29 Apr 2020 12:13:53 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Apr 2020 03:13:52 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.218])\n by orsmga001.jf.intel.com with ESMTP; 29 Apr 2020 03:13:51 -0700" ], "IronPort-SDR": [ "\n PkD8mJ0Zrbv7YMf0HmZ2sa5LZZA3P+KZ4esSa/10tFWGdq0yqdYb7dS73IxFREYk1iJsWggWQQ\n IvSy7ONF1TXw==", "\n YouFVpx809d9TDbb+OTBevX9Ifji4LLkjNxHZyzhq+IX/Mmpd9bTuZkN1+9+grLs5iClFgvzbe\n 1Qz/tagBCo7A==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,331,1583222400\"; d=\"scan'208\";a=\"336916016\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bluca@debian.org, david.marchand@redhat.com,\n ktraynor@redhat.com, Bruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 29 Apr 2020 11:08:29 +0100", "Message-Id": "<20200429100831.398-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200429100831.398-1-bruce.richardson@intel.com>", "References": "<20200429100831.398-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first\n\tfor static build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When calling pkg-config --static --libs, pkg-config will always output the\nregular libs first, and then the extra libs from libraries.private field,\nsince the assumption is that those are additional dependencies for building\nstatically that the .a files depend upon.\n\nHowever, for DPDK, we only link the driver files for static builds, and\nthose need to come *before* the regular libraries. To get this result, we\nneed two pkgconfig files for DPDK, one for the shared libs, and a second\nfor the static libs and drivers, which depends upon the first. Using a\ndependency means that the shared libs are printed only after the\nlibraries.private field rather than before.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n buildtools/pkg-config/meson.build | 32 +++++++++++++++++++++++--------\n 1 file changed, 24 insertions(+), 8 deletions(-)", "diff": "diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build\nindex 85d59972d..f08ca54ed 100644\n--- a/buildtools/pkg-config/meson.build\n+++ b/buildtools/pkg-config/meson.build\n@@ -10,17 +10,33 @@ pkg_extra_cflags = ['-include', 'rte_config.h'] + machine_args\n if is_freebsd\n \tpkg_extra_cflags += ['-D__BSD_VISIBLE']\n endif\n-pkg.generate(name: meson.project_name(),\n-\tfilebase: 'lib' + meson.project_name().to_lower(),\n+\n+# When calling pkg-config --static --libs, pkg-config will always output the\n+# regular libs first, and then the extra libs from libraries.private field,\n+# since the assumption is that those are additional dependencies for building\n+# statically that the .a files depend upon. However, for DPDK, we only link\n+# the driver files for static builds, and those need to come *before* the\n+# regular libraries. To get this result, we need two pkgconfig files for DPDK,\n+# one for the shared libs, and a second for the static libs and drivers, which\n+# depends upon the first. Using a dependency means that the shared libs are\n+# printed only after the libraries.private field rather than before.\n+pkg.generate(name: 'dpdk-libs',\n+\tfilebase: 'libdpdk-libs',\n+\tdescription: 'The Data Plane Development Kit (DPDK), libraries only.',\n \tversion: meson.project_version(),\n+\tsubdirs: [get_option('include_subdir_arch'), '.'],\n+\textra_cflags: pkg_extra_cflags,\n \tlibraries: dpdk_libraries,\n-\tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n-\t\t\t['-Wl,-Bdynamic'] + dpdk_extra_ldflags,\n-\trequires: libbsd, # apps using rte_string_fns.h may need this if enabled\n-\t # if libbsd is not enabled, then this is blank\n+\tlibraries_private: dpdk_extra_ldflags)\n+\n+pkg.generate(name: 'DPDK', # main DPDK pkgconfig file\n+\tfilebase: 'libdpdk',\n+\tversion: meson.project_version(),\n \tdescription: '''The Data Plane Development Kit (DPDK).\n Note that CFLAGS might contain an -march flag higher than typical baseline.\n This is required for a number of static inline functions in the public headers.''',\n-\tsubdirs: [get_option('include_subdir_arch'), '.'],\n-\textra_cflags: pkg_extra_cflags\n+\trequires: ['libdpdk-libs', libbsd], # may need libbsd for string funcs\n+\t # if libbsd is not enabled, then this is blank\n+\tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n+\t\t\t['-Wl,-Bdynamic']\n )\n", "prefixes": [ "5/7" ] }