Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6951,
    "url": "http://patches.dpdk.org/api/patches/6951/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1441523526-26202-26-git-send-email-jingjing.wu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1441523526-26202-26-git-send-email-jingjing.wu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1441523526-26202-26-git-send-email-jingjing.wu@intel.com",
    "date": "2015-09-06T07:11:39",
    "name": "[dpdk-dev,25/52] i40e/base: fix up type clash in i40e_aq_rc_to_posix conversion",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d586508d13e6c8943d6f49cf62b58124d34b43ea",
    "submitter": {
        "id": 47,
        "url": "http://patches.dpdk.org/api/people/47/?format=api",
        "name": "Jingjing Wu",
        "email": "jingjing.wu@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1441523526-26202-26-git-send-email-jingjing.wu@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/6951/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/6951/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0431D9368;\n\tSun,  6 Sep 2015 09:13:41 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 2C5E48E83\n\tfor <dev@dpdk.org>; Sun,  6 Sep 2015 09:13:36 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 06 Sep 2015 00:13:20 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 06 Sep 2015 00:13:08 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t867D6rq019615;\n\tSun, 6 Sep 2015 15:13:06 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t867D46n026414; Sun, 6 Sep 2015 15:13:06 +0800",
            "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t867D4nP026410; \n\tSun, 6 Sep 2015 15:13:04 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,478,1437462000\"; d=\"scan'208\";a=\"783753614\"",
        "From": "Jingjing Wu <jingjing.wu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Sun,  6 Sep 2015 15:11:39 +0800",
        "Message-Id": "<1441523526-26202-26-git-send-email-jingjing.wu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1441523526-26202-1-git-send-email-jingjing.wu@intel.com>",
        "References": "<1441523526-26202-1-git-send-email-jingjing.wu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 25/52] i40e/base: fix up type clash in\n\ti40e_aq_rc_to_posix conversion",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The error code sent into i40e_aq_rc_to_posix() are signed values, so we\nreally need to treat them as such.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.h b/drivers/net/i40e/base/i40e_adminq.h\nindex 3d267bc..434c754 100644\n--- a/drivers/net/i40e/base/i40e_adminq.h\n+++ b/drivers/net/i40e/base/i40e_adminq.h\n@@ -116,9 +116,10 @@ struct i40e_adminq_info {\n \n /**\n  * i40e_aq_rc_to_posix - convert errors to user-land codes\n- * aq_rc: AdminQ error code to convert\n+ * aq_ret: AdminQ handler error code can override aq_rc\n+ * aq_rc: AdminQ firmware error code to convert\n  **/\n-STATIC inline int i40e_aq_rc_to_posix(int aq_ret, u16 aq_rc)\n+STATIC inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc)\n {\n \tint aq_to_posix[] = {\n \t\t0,           /* I40E_AQ_RC_OK */\n@@ -150,8 +151,9 @@ STATIC inline int i40e_aq_rc_to_posix(int aq_ret, u16 aq_rc)\n \tif (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT)\n \t\treturn -EAGAIN;\n \n-\tif (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))\n+\tif (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0]))))\n \t\treturn -ERANGE;\n+\n \treturn aq_to_posix[aq_rc];\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "25/52"
    ]
}