Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69363/?format=api
http://patches.dpdk.org/api/patches/69363/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200427071500.14767-4-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200427071500.14767-4-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200427071500.14767-4-wei.zhao1@intel.com", "date": "2020-04-27T07:15:00", "name": "[3/3] net/i40e: remove teardown when flush FDIR filter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c39588c1db14f0192a8c854918ec1074c6adaf47", "submitter": { "id": 495, "url": "http://patches.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200427071500.14767-4-wei.zhao1@intel.com/mbox/", "series": [ { "id": 9660, "url": "http://patches.dpdk.org/api/series/9660/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9660", "date": "2020-04-27T07:14:57", "name": "fix i40e bug for flow filter", "version": 1, "mbox": "http://patches.dpdk.org/series/9660/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69363/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/69363/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C6B98A00BE;\n\tMon, 27 Apr 2020 09:38:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F09661C18F;\n\tMon, 27 Apr 2020 09:37:49 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 628391BF81;\n Mon, 27 Apr 2020 09:37:42 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Apr 2020 00:37:40 -0700", "from unknown (HELO localhost.localdomain.bj.intel.com)\n ([172.16.182.123])\n by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2020 00:37:34 -0700" ], "IronPort-SDR": [ "\n r4EAzXmUiSktWc0yiv2QSR7GB9J3gnnq1ia5cbdxL7mT4tiE/o8G6GdUBTLL8nPtMtN2Q9Arr6\n j6mpKZmhXnKQ==", "\n 3nhgrNgopPtuOUI0I+4d3noCmzErMDmimj/m/W/somuYvGFUovpK4bWZwE2faA7885h8sRllYg\n VC8YBGfBwvgw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.73,323,1583222400\"; d=\"scan'208\";a=\"458244993\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, maxime.leroy@6wind.com, stable@dpdk.org,\n Wei Zhao <wei.zhao1@intel.com>", "Date": "Mon, 27 Apr 2020 15:15:00 +0800", "Message-Id": "<20200427071500.14767-4-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20200427071500.14767-1-wei.zhao1@intel.com>", "References": "<20200427071500.14767-1-wei.zhao1@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] net/i40e: remove teardown when flush FDIR\n\tfilter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we flush FDIR filter, we can not call i40e_fdir_teardown()\nfunction as it will free vsi used for FDIR, then the vsi->base_queue\nwill be freed from pf->qp_pool, but vsi->base_queue can only get\nonce when do dev init in i40e_pf_setup(). If we free it, it will\nnever be alloc again.\n\nBugzilla ID: 404\nFixes: 2e67a7fbf3ff (\"net/i40e: config flow director automatically\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/i40e/i40e_flow.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 1533d5abb..65f877866 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -5145,7 +5145,6 @@ i40e_flow_destroy(struct rte_eth_dev *dev,\n \n \t\t/* If the last flow is destroyed, disable fdir. */\n \t\tif (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {\n-\t\t\ti40e_fdir_teardown(pf);\n \t\t\ti40e_fdir_rx_proc_enable(dev, 0);\n \t\t}\n \t\tbreak;\n@@ -5343,8 +5342,6 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)\n \t\t\tpf->fdir.inset_flag[pctype] = 0;\n \t}\n \n-\ti40e_fdir_teardown(pf);\n-\n \treturn ret;\n }\n \n", "prefixes": [ "3/3" ] }{ "id": 69363, "url": "