Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 69210,
    "url": "http://patches.dpdk.org/api/patches/69210/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200424092445.44693-3-yong.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200424092445.44693-3-yong.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200424092445.44693-3-yong.liu@intel.com",
    "date": "2020-04-24T09:24:38",
    "name": "[v9,2/9] net/virtio: inorder should depend on feature bit",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e687f3b3b7c0f0ce58e8f19e85a6106452852cb5",
    "submitter": {
        "id": 17,
        "url": "http://patches.dpdk.org/api/people/17/?format=api",
        "name": "Marvin Liu",
        "email": "yong.liu@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200424092445.44693-3-yong.liu@intel.com/mbox/",
    "series": [
        {
            "id": 9605,
            "url": "http://patches.dpdk.org/api/series/9605/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9605",
            "date": "2020-04-24T09:24:36",
            "name": "add packed ring vectorized path",
            "version": 9,
            "mbox": "http://patches.dpdk.org/series/9605/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/69210/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/69210/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A253A00C4;\n\tFri, 24 Apr 2020 03:49:47 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E35EF1C242;\n\tFri, 24 Apr 2020 03:49:34 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id CA9141C227\n for <dev@dpdk.org>; Fri, 24 Apr 2020 03:49:31 +0200 (CEST)",
            "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2020 18:49:31 -0700",
            "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.56])\n by orsmga007.jf.intel.com with ESMTP; 23 Apr 2020 18:49:29 -0700"
        ],
        "IronPort-SDR": [
            "\n 6oEuhoD54JNu1G4rJiDL0+jVjaP0S/SnWkeSC+x5xDyKMvxjad+tNF8UWNYwkZWKhEuAAEvYtb\n JH3rD6BBZ2og==",
            "\n zLaKFsE0LYSo7tQlfuvRwft3Rnut1dw4f/6mirxwnh95ANVcqfttTI4jGrEpmMmaircph3MsBi\n 6oUyrgWB/dbg=="
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.73,310,1583222400\"; d=\"scan'208\";a=\"245083887\"",
        "From": "Marvin Liu <yong.liu@intel.com>",
        "To": "maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com",
        "Cc": "dev@dpdk.org, harry.van.haaren@intel.com, Marvin Liu <yong.liu@intel.com>",
        "Date": "Fri, 24 Apr 2020 17:24:38 +0800",
        "Message-Id": "<20200424092445.44693-3-yong.liu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200424092445.44693-1-yong.liu@intel.com>",
        "References": "<20200313174230.74661-1-yong.liu@intel.com>\n <20200424092445.44693-1-yong.liu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v9 2/9] net/virtio: inorder should depend on\n\tfeature bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Ring initialization is different when inorder feature negotiated. This\naction should dependent on negotiated feature bits.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 94ba7a3ec..e450477e8 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -989,6 +989,7 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev *dev, uint16_t queue_idx)\n \tstruct rte_mbuf *m;\n \tuint16_t desc_idx;\n \tint error, nbufs, i;\n+\tbool in_order = vtpci_with_feature(hw, VIRTIO_F_IN_ORDER);\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -1018,7 +1019,7 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev *dev, uint16_t queue_idx)\n \t\t\tvirtio_rxq_rearm_vec(rxvq);\n \t\t\tnbufs += RTE_VIRTIO_VPMD_RX_REARM_THRESH;\n \t\t}\n-\t} else if (hw->use_inorder_rx) {\n+\t} else if (!vtpci_packed_queue(vq->hw) && in_order) {\n \t\tif ((!virtqueue_full(vq))) {\n \t\t\tuint16_t free_cnt = vq->vq_free_cnt;\n \t\t\tstruct rte_mbuf *pkts[free_cnt];\n@@ -1133,7 +1134,7 @@ virtio_dev_tx_queue_setup_finish(struct rte_eth_dev *dev,\n \tPMD_INIT_FUNC_TRACE();\n \n \tif (!vtpci_packed_queue(hw)) {\n-\t\tif (hw->use_inorder_tx)\n+\t\tif (vtpci_with_feature(hw, VIRTIO_F_IN_ORDER))\n \t\t\tvq->vq_split.ring.desc[vq->vq_nentries - 1].next = 0;\n \t}\n \n@@ -2046,7 +2047,7 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tstruct virtio_hw *hw = vq->hw;\n \tuint16_t hdr_size = hw->vtnet_hdr_size;\n \tuint16_t nb_tx = 0;\n-\tbool in_order = hw->use_inorder_tx;\n+\tbool in_order = vtpci_with_feature(hw, VIRTIO_F_IN_ORDER);\n \n \tif (unlikely(hw->started == 0 && tx_pkts != hw->inject_pkts))\n \t\treturn nb_tx;\n",
    "prefixes": [
        "v9",
        "2/9"
    ]
}