Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69124/?format=api
{ "id": 69124, "url": "http://patches.dpdk.org/api/patches/69124/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-5-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422190349.3768487-5-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422190349.3768487-5-jerinj@marvell.com", "date": "2020-04-22T19:03:21", "name": "[v7,04/32] eal/trace: implement trace operation APIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d5e1d5b4acd52fb4bccb665116d8ed520081e524", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200422190349.3768487-5-jerinj@marvell.com/mbox/", "series": [ { "id": 9574, "url": "http://patches.dpdk.org/api/series/9574/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9574", "date": "2020-04-22T19:03:17", "name": "DPDK Trace support", "version": 7, "mbox": "http://patches.dpdk.org/series/9574/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69124/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/69124/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C065EA00C2;\n\tWed, 22 Apr 2020 21:04:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8BB7E1D536;\n\tWed, 22 Apr 2020 21:04:16 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9F30B1D428\n for <dev@dpdk.org>; Wed, 22 Apr 2020 21:04:11 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 03MJ1McD005799; Wed, 22 Apr 2020 12:04:11 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0b-0016f401.pphosted.com with ESMTP id 30jd013jcm-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 22 Apr 2020 12:04:11 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 22 Apr 2020 12:04:08 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 22 Apr 2020 12:04:08 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 90D323F703F;\n Wed, 22 Apr 2020 12:04:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=/1jajm8vYC4r6Z1v0purEcC4xsfcMrbTalUIMeOh8Ec=;\n b=TyE7ubms4WgcJnLrSe4/HnBPR2XCtWqQeIRa5HDi44lF+CkU5PjcJbcPyOWITn230iiN\n AKzO+V4WnXrZjDBgJSbGjmGKR8SDIVWakfVb+o0090u0sDMR/ij+Czqhol1NLs78u07x\n 8oyWKQ66TBx2dWob+LA4xVwWasFNOEcmAz/Icpglspxhsd8v+Mt68m9t6W2DZp/dGfpm\n oEadvnsgzBEyCNAQbCjH32fUUvqkNOw5zOyddDZ3tVf6rNrUSlEKlFMKXxXO6sbtPWcp\n T2PeZzRnfpUKzDqibqm62/KyOabJ66RpR8tEFQ44LPtnnHgkmaJ600TfPP3u+lyBYqVR oQ==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>", "Date": "Thu, 23 Apr 2020 00:33:21 +0530", "Message-ID": "<20200422190349.3768487-5-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200422190349.3768487-1-jerinj@marvell.com>", "References": "<20200419100133.3232316-1-jerinj@marvell.com>\n <20200422190349.3768487-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-22_06:2020-04-22,\n 2020-04-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v7 04/32] eal/trace: implement trace operation\n\tAPIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nThis patch implements the following public trace APIs.\n\n- rte_trace_is_enabled()\n- rte_trace_mode_get()\n- rte_trace_mode_set()\n- rte_trace_pattern()\n- rte_trace_point_disable()\n- rte_trace_point_enable()\n- rte_trace_point_is_enabled()\n- rte_trace_point_lookup()\n- rte_trace_regexp()\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n lib/librte_eal/common/eal_common_trace.c | 141 +++++++++++++++++++++++\n lib/librte_eal/common/eal_trace.h | 10 ++\n lib/librte_eal/rte_eal_version.map | 9 ++\n 3 files changed, 160 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c\nindex 5c5cbd2a1..4090f909f 100644\n--- a/lib/librte_eal/common/eal_common_trace.c\n+++ b/lib/librte_eal/common/eal_common_trace.c\n@@ -2,8 +2,10 @@\n * Copyright(C) 2020 Marvell International Ltd.\n */\n \n+#include <fnmatch.h>\n #include <inttypes.h>\n #include <sys/queue.h>\n+#include <regex.h>\n \n #include <rte_common.h>\n #include <rte_errno.h>\n@@ -20,6 +22,145 @@ static RTE_DEFINE_PER_LCORE(int, ctf_count);\n static struct trace_point_head tp_list = STAILQ_HEAD_INITIALIZER(tp_list);\n static struct trace trace;\n \n+bool\n+rte_trace_is_enabled(void)\n+{\n+\treturn trace.status;\n+}\n+\n+static void\n+trace_mode_set(rte_trace_point_t *trace, enum rte_trace_mode mode)\n+{\n+\tif (mode == RTE_TRACE_MODE_OVERWRITE)\n+\t\t__atomic_and_fetch(trace, ~__RTE_TRACE_FIELD_ENABLE_DISCARD,\n+\t\t\t\t __ATOMIC_RELEASE);\n+\telse\n+\t\t__atomic_or_fetch(trace, __RTE_TRACE_FIELD_ENABLE_DISCARD,\n+\t\t\t\t __ATOMIC_RELEASE);\n+}\n+\n+void\n+rte_trace_mode_set(enum rte_trace_mode mode)\n+{\n+\tstruct trace_point *tp;\n+\n+\tif (!rte_trace_is_enabled())\n+\t\treturn;\n+\n+\tSTAILQ_FOREACH(tp, &tp_list, next)\n+\t\ttrace_mode_set(tp->handle, mode);\n+\n+\ttrace.mode = mode;\n+}\n+\n+enum\n+rte_trace_mode rte_trace_mode_get(void)\n+{\n+\treturn trace.mode;\n+}\n+\n+static bool\n+trace_point_is_invalid(rte_trace_point_t *t)\n+{\n+\treturn (t == NULL) || (trace_id_get(t) >= trace.nb_trace_points);\n+}\n+\n+bool\n+rte_trace_point_is_enabled(rte_trace_point_t *trace)\n+{\n+\tuint64_t val;\n+\n+\tif (trace_point_is_invalid(trace))\n+\t\treturn false;\n+\n+\tval = __atomic_load_n(trace, __ATOMIC_ACQUIRE);\n+\treturn (val & __RTE_TRACE_FIELD_ENABLE_MASK) != 0;\n+}\n+\n+int\n+rte_trace_point_enable(rte_trace_point_t *trace)\n+{\n+\tif (trace_point_is_invalid(trace))\n+\t\treturn -ERANGE;\n+\n+\t__atomic_or_fetch(trace, __RTE_TRACE_FIELD_ENABLE_MASK,\n+\t\t\t __ATOMIC_RELEASE);\n+\treturn 0;\n+}\n+\n+int\n+rte_trace_point_disable(rte_trace_point_t *trace)\n+{\n+\tif (trace_point_is_invalid(trace))\n+\t\treturn -ERANGE;\n+\n+\t__atomic_and_fetch(trace, ~__RTE_TRACE_FIELD_ENABLE_MASK,\n+\t\t\t __ATOMIC_RELEASE);\n+\treturn 0;\n+}\n+\n+int\n+rte_trace_pattern(const char *pattern, bool enable)\n+{\n+\tstruct trace_point *tp;\n+\tint rc = 0, found = 0;\n+\n+\tSTAILQ_FOREACH(tp, &tp_list, next) {\n+\t\tif (fnmatch(pattern, tp->name, 0) == 0) {\n+\t\t\tif (enable)\n+\t\t\t\trc = rte_trace_point_enable(tp->handle);\n+\t\t\telse\n+\t\t\t\trc = rte_trace_point_disable(tp->handle);\n+\t\t\tfound = 1;\n+\t\t}\n+\t\tif (rc < 0)\n+\t\t\treturn rc;\n+\t}\n+\n+\treturn rc | found;\n+}\n+\n+int\n+rte_trace_regexp(const char *regex, bool enable)\n+{\n+\tstruct trace_point *tp;\n+\tint rc = 0, found = 0;\n+\tregex_t r;\n+\n+\tif (regcomp(&r, regex, 0) != 0)\n+\t\treturn -EINVAL;\n+\n+\tSTAILQ_FOREACH(tp, &tp_list, next) {\n+\t\tif (regexec(&r, tp->name, 0, NULL, 0) == 0) {\n+\t\t\tif (enable)\n+\t\t\t\trc = rte_trace_point_enable(tp->handle);\n+\t\t\telse\n+\t\t\t\trc = rte_trace_point_disable(tp->handle);\n+\t\t\tfound = 1;\n+\t\t}\n+\t\tif (rc < 0)\n+\t\t\treturn rc;\n+\t}\n+\tregfree(&r);\n+\n+\treturn rc | found;\n+}\n+\n+rte_trace_point_t *\n+rte_trace_point_lookup(const char *name)\n+{\n+\tstruct trace_point *tp;\n+\n+\tif (name == NULL)\n+\t\treturn NULL;\n+\n+\tSTAILQ_FOREACH(tp, &tp_list, next)\n+\t\tif (strncmp(tp->name, name, TRACE_POINT_NAME_SIZE) == 0)\n+\t\t\treturn tp->handle;\n+\n+\treturn NULL;\n+}\n+\n int\n __rte_trace_point_register(rte_trace_point_t *handle, const char *name,\n \t\t\t void (*register_fn)(void))\ndiff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h\nindex 4f1792768..ebf7914ff 100644\n--- a/lib/librte_eal/common/eal_trace.h\n+++ b/lib/librte_eal/common/eal_trace.h\n@@ -28,9 +28,19 @@ struct trace_point {\n \n struct trace {\n \tint register_errno;\n+\tbool status;\n+\tenum rte_trace_mode mode;\n \tuint32_t nb_trace_points;\n };\n \n+/* Helper functions */\n+static inline uint16_t\n+trace_id_get(rte_trace_point_t *trace)\n+{\n+\treturn (*trace & __RTE_TRACE_FIELD_ID_MASK) >>\n+\t\t__RTE_TRACE_FIELD_ID_SHIFT;\n+}\n+\n /* Trace point list functions */\n STAILQ_HEAD(trace_point_head, trace_point);\n \ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 02a595126..2e6aacc17 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -341,4 +341,13 @@ EXPERIMENTAL {\n \tper_lcore_trace_point_sz;\n \trte_log_can_log;\n \trte_thread_getname;\n+\trte_trace_is_enabled;\n+\trte_trace_mode_get;\n+\trte_trace_mode_set;\n+\trte_trace_pattern;\n+\trte_trace_point_disable;\n+\trte_trace_point_enable;\n+\trte_trace_point_is_enabled;\n+\trte_trace_point_lookup;\n+\trte_trace_regexp;\n };\n", "prefixes": [ "v7", "04/32" ] }