Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/69032/?format=api
{ "id": 69032, "url": "http://patches.dpdk.org/api/patches/69032/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200422010255.76137-4-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200422010255.76137-4-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200422010255.76137-4-jia.guo@intel.com", "date": "2020-04-22T01:02:55", "name": "[v8,3/3] app/testpmd: add new types to RSS hash commands", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "67c586f0ea58184184cc9d2d70116d74344a5b4b", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200422010255.76137-4-jia.guo@intel.com/mbox/", "series": [ { "id": 9544, "url": "http://patches.dpdk.org/api/series/9544/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9544", "date": "2020-04-22T01:02:52", "name": "add RSS configuration for iavf", "version": 8, "mbox": "http://patches.dpdk.org/series/9544/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/69032/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/69032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 807C5A0597;\n\tTue, 21 Apr 2020 15:05:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B1F41D5D4;\n\tTue, 21 Apr 2020 15:03:55 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id D848E1D617\n for <dev@dpdk.org>; Tue, 21 Apr 2020 15:03:44 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Apr 2020 06:03:44 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2020 06:03:41 -0700" ], "IronPort-SDR": [ "\n Kj+/O26wTs0hd2vVuihGtI75gTtqyGU9dBSACF+UUZe37rYIO6F3WqxJLLwAvM1cgRhki3EwUE\n M5Aal3VwjiVQ==", "\n JhkB8tLn71TBM00YsV7kzrzqW7gAJYvAxFe/zr/2Dg9JnX1txHHjjqTPx/wt3/j0oPXq6RJlm1\n aHgLTxnCXoAw==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,410,1580803200\"; d=\"scan'208\";a=\"279630600\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "bernard.iremonger@intel.com, orika@mellanox.com, wenzhuo.lu@intel.com,\n stephen@networkplumber.org, qi.z.zhang@intel.com, jingjing.wu@intel.com", "Cc": "beilei.xing@intel.com, xiaolong.ye@intel.com, dev@dpdk.org,\n yahui.cao@intel.com, simei.su@intel.com, jia.guo@intel.com", "Date": "Tue, 21 Apr 2020 21:02:55 -0400", "Message-Id": "<20200422010255.76137-4-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200422010255.76137-1-jia.guo@intel.com>", "References": "<20200318170401.7938-5-jia.guo@intel.com>\n <20200422010255.76137-1-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev v8 3/3] app/testpmd: add new types to RSS hash\n\tcommands", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/\nl2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used\nto configure these rss input set by cmdline.\n\nExample flow commands was:\ntestpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \\\n\tactions rss types l2tpv3 end key_len 0 queues end / end\n\nport config commands was:\ntestpmd>port config all rss l2tpv3\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\nAcked-by: Ori Kam <orika@mellanox.com>\n---\nv8->v7:\nrefine guide doc.\n---\n app/test-pmd/cmdline.c | 34 +++++++++++++++++----\n app/test-pmd/config.c | 14 +++++++--\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 ++--\n 3 files changed, 43 insertions(+), 11 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex a36c505c5..96fe7c818 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -2270,9 +2270,14 @@ cmd_config_rss_parsed(void *parsed_result,\n \tint ret;\n \n \tif (!strcmp(res->value, \"all\"))\n-\t\trss_conf.rss_hf = ETH_RSS_IP | ETH_RSS_TCP |\n-\t\t\t\tETH_RSS_UDP | ETH_RSS_SCTP |\n-\t\t\t\t\tETH_RSS_L2_PAYLOAD;\n+\t\trss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP |\n+\t\t\tETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP |\n+\t\t\tETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP |\n+\t\t\tETH_RSS_AH | ETH_RSS_PFCP;\n+\telse if (!strcmp(res->value, \"eth\"))\n+\t\trss_conf.rss_hf = ETH_RSS_ETH;\n+\telse if (!strcmp(res->value, \"vlan\"))\n+\t\trss_conf.rss_hf = ETH_RSS_VLAN;\n \telse if (!strcmp(res->value, \"ip\"))\n \t\trss_conf.rss_hf = ETH_RSS_IP;\n \telse if (!strcmp(res->value, \"udp\"))\n@@ -2299,6 +2304,18 @@ cmd_config_rss_parsed(void *parsed_result,\n \t\trss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY;\n \telse if (!strcmp(res->value, \"l4-dst-only\"))\n \t\trss_conf.rss_hf = ETH_RSS_L4_DST_ONLY;\n+\telse if (!strcmp(res->value, \"l2-src-only\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2_SRC_ONLY;\n+\telse if (!strcmp(res->value, \"l2-dst-only\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2_DST_ONLY;\n+\telse if (!strcmp(res->value, \"l2tpv3\"))\n+\t\trss_conf.rss_hf = ETH_RSS_L2TPV3;\n+\telse if (!strcmp(res->value, \"esp\"))\n+\t\trss_conf.rss_hf = ETH_RSS_ESP;\n+\telse if (!strcmp(res->value, \"ah\"))\n+\t\trss_conf.rss_hf = ETH_RSS_AH;\n+\telse if (!strcmp(res->value, \"pfcp\"))\n+\t\trss_conf.rss_hf = ETH_RSS_PFCP;\n \telse if (!strcmp(res->value, \"none\"))\n \t\trss_conf.rss_hf = 0;\n \telse if (!strcmp(res->value, \"default\"))\n@@ -2359,7 +2376,8 @@ cmdline_parse_inst_t cmd_config_rss = {\n \t.f = cmd_config_rss_parsed,\n \t.data = NULL,\n \t.help_str = \"port config all rss \"\n-\t\t\"all|default|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|none|<flowtype_id>\",\n+\t\t\"all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|\"\n+\t\t\"nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|none|<flowtype_id>\",\n \t.tokens = {\n \t\t(void *)&cmd_config_rss_port,\n \t\t(void *)&cmd_config_rss_keyword,\n@@ -2469,7 +2487,9 @@ cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type =\n \t\t\t\t \"ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6-udp#\"\n \t\t\t\t \"ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#\"\n \t\t\t\t \"ipv6-tcp-ex#ipv6-udp-ex#\"\n-\t\t\t\t \"l3-src-only#l3-dst-only#l4-src-only#l4-dst-only\");\n+\t\t\t\t \"l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#\"\n+\t\t\t\t \"l2-src-only#l2-dst-only#s-vlan#c-vlan#\"\n+\t\t\t\t \"l2tpv3#esp#ah#pfcp\");\n cmdline_parse_token_string_t cmd_config_rss_hash_key_value =\n \tTOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL);\n \n@@ -2480,7 +2500,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = {\n \t\t\"ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|\"\n \t\t\"ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|\"\n \t\t\"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|\"\n-\t\t\"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only \"\n+\t\t\"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|\"\n+\t\t\"l2-src-only|l2-dst-only|s-vlan|c-vlan|\"\n+\t\t\"l2tpv3|esp|ah|pfcp \"\n \t\t\"<string of hex digits (variable length, NIC dependent)>\",\n \t.tokens = {\n \t\t(void *)&cmd_config_rss_hash_key_port,\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 69c5633e8..72f25d152 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -75,10 +75,16 @@ static const struct {\n };\n \n const struct rss_type_info rss_type_table[] = {\n-\t{ \"all\", ETH_RSS_IP | ETH_RSS_TCP |\n-\t\t\tETH_RSS_UDP | ETH_RSS_SCTP |\n-\t\t\tETH_RSS_L2_PAYLOAD },\n+\t{ \"all\", ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP | ETH_RSS_TCP |\n+\t\tETH_RSS_UDP | ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD |\n+\t\tETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP},\n \t{ \"none\", 0 },\n+\t{ \"eth\", ETH_RSS_ETH },\n+\t{ \"l2-src-only\", ETH_RSS_L2_SRC_ONLY },\n+\t{ \"l2-dst-only\", ETH_RSS_L2_DST_ONLY },\n+\t{ \"vlan\", ETH_RSS_VLAN },\n+\t{ \"s-vlan\", ETH_RSS_S_VLAN },\n+\t{ \"c-vlan\", ETH_RSS_C_VLAN },\n \t{ \"ipv4\", ETH_RSS_IPV4 },\n \t{ \"ipv4-frag\", ETH_RSS_FRAG_IPV4 },\n \t{ \"ipv4-tcp\", ETH_RSS_NONFRAG_IPV4_TCP },\n@@ -110,6 +116,8 @@ const struct rss_type_info rss_type_table[] = {\n \t{ \"l4-dst-only\", ETH_RSS_L4_DST_ONLY },\n \t{ \"esp\", ETH_RSS_ESP },\n \t{ \"ah\", ETH_RSS_AH },\n+\t{ \"l2tpv3\", ETH_RSS_L2TPV3 },\n+\t{ \"pfcp\", ETH_RSS_PFCP },\n \t{ NULL, 0 },\n };\n \ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex dcee5de45..a360ecccf 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -2199,12 +2199,14 @@ port config - RSS\n \n Set the RSS (Receive Side Scaling) mode on or off::\n \n- testpmd> port config all rss (all|default|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|none)\n+ testpmd> port config all rss (all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|none)\n \n RSS is on by default.\n \n-The ``all`` option is equivalent to ip|tcp|udp|sctp|ether.\n+The ``all`` option is equivalent to eth|vlan|ip|tcp|udp|sctp|ether|l2tpv3|esp|ah|pfcp.\n+\n The ``default`` option enables all supported RSS types reported by device info.\n+\n The ``none`` option is equivalent to the ``--disable-rss`` command-line option.\n \n port config - RSS Reta\n", "prefixes": [ "v8", "3/3" ] }