Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68967/?format=api
{ "id": 68967, "url": "http://patches.dpdk.org/api/patches/68967/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200420192523.2546909-3-aconole@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200420192523.2546909-3-aconole@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200420192523.2546909-3-aconole@redhat.com", "date": "2020-04-20T19:25:22", "name": "[v6,2/3] ip_frag: ensure minimum v6 fragmentation length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "531293e94f83598ae15caa48872ed8a3929b6a4f", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200420192523.2546909-3-aconole@redhat.com/mbox/", "series": [ { "id": 9518, "url": "http://patches.dpdk.org/api/series/9518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9518", "date": "2020-04-20T19:25:20", "name": "ip_frag: add a unit test for fragmentation", "version": 6, "mbox": "http://patches.dpdk.org/series/9518/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/68967/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/68967/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3ED5A0561;\n\tMon, 20 Apr 2020 21:25:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 958251C1D8;\n\tMon, 20 Apr 2020 21:25:42 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B1F571C1B3\n for <dev@dpdk.org>; Mon, 20 Apr 2020 21:25:34 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-348-ssegE6g6MWSoAFlDYJ4nHw-1; Mon, 20 Apr 2020 15:25:32 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1426B1084430;\n Mon, 20 Apr 2020 19:25:31 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (ovpn-114-167.rdu2.redhat.com\n [10.10.114.167])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 1C3F35C1BB;\n Mon, 20 Apr 2020 19:25:30 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1587410734;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eXjWk6GlzS0+6XGKQuBFO6SqxhK9+YfFGMPoh2DfjG8=;\n b=D4Kvrf6zyFyVkXNS/Hgdj9ZDBZbHK20O+cm5LereTCnSFpkwfRfPHAwIOBCoFwZqFWnLH9\n 5mOViP3MZeUMb9of4B+6tR5Th21Oe2OupTUPvw6S8fldHhknBqKyfhYRfAyCSIFRGo6pNg\n VBgoeBpr25SQajF63fyK2r9K0zjVBSo=", "X-MC-Unique": "ssegE6g6MWSoAFlDYJ4nHw-1", "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "Date": "Mon, 20 Apr 2020 15:25:22 -0400", "Message-Id": "<20200420192523.2546909-3-aconole@redhat.com>", "In-Reply-To": "<20200420192523.2546909-1-aconole@redhat.com>", "References": "<20200417131410.1343135-1-aconole@redhat.com>\n <20200420192523.2546909-1-aconole@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v6 2/3] ip_frag: ensure minimum v6 fragmentation\n\tlength", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In addition, do a formal parameter check.\n\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nAcked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\nSigned-off-by: Aaron Conole <aconole@redhat.com>\n---\n lib/librte_ip_frag/rte_ipv6_fragmentation.c | 9 +++++++++\n lib/librte_net/rte_ip.h | 2 ++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_frag/rte_ipv6_fragmentation.c\nindex 43449970e5..5d67336f2d 100644\n--- a/lib/librte_ip_frag/rte_ipv6_fragmentation.c\n+++ b/lib/librte_ip_frag/rte_ipv6_fragmentation.c\n@@ -79,6 +79,15 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in,\n \tuint16_t fragment_offset, frag_size;\n \tuint64_t frag_bytes_remaining;\n \n+\t/*\n+\t * Formal parameter checking.\n+\t */\n+\tif (unlikely(pkt_in == NULL) || unlikely(pkts_out == NULL) ||\n+\t unlikely(nb_pkts_out == 0) ||\n+\t unlikely(pool_direct == NULL) || unlikely(pool_indirect == NULL) ||\n+\t unlikely(mtu_size < RTE_IPV6_MIN_MTU))\n+\t\treturn -EINVAL;\n+\n \t/*\n \t * Ensure the IP payload length of all fragments (except the\n \t * the last fragment) are a multiple of 8 bytes per RFC2460.\ndiff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h\nindex 1ceb7b7931..d50edec572 100644\n--- a/lib/librte_net/rte_ip.h\n+++ b/lib/librte_net/rte_ip.h\n@@ -371,6 +371,8 @@ struct rte_ipv6_hdr {\n #define RTE_IPV6_HDR_ECN_MASK\t(0x03 << RTE_IPV6_HDR_TC_SHIFT)\n #define RTE_IPV6_HDR_ECN_CE\tRTE_IPV6_HDR_ECN_MASK\n \n+#define RTE_IPV6_MIN_MTU 1280 /**< Minimum MTU for IPv6, see RFC 8200. */\n+\n /**\n * Process the pseudo-header checksum of an IPv6 header.\n *\n", "prefixes": [ "v6", "2/3" ] }