Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6870/?format=api
{ "id": 6870, "url": "http://patches.dpdk.org/api/patches/6870/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1441199803-27055-11-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441199803-27055-11-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1441199803-27055-11-git-send-email-thomas.monjalon@6wind.com", "date": "2015-09-02T13:16:43", "name": "[dpdk-dev,v2,10/10] ring: remove deprecated functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "182d77919dc7eb441d264791ca610be9676b9d21", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1441199803-27055-11-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6870/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6870/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id ECD54918F;\n\tWed, 2 Sep 2015 15:18:13 +0200 (CEST)", "from mail-wi0-f170.google.com (mail-wi0-f170.google.com\n\t[209.85.212.170]) by dpdk.org (Postfix) with ESMTP id C2F178E90\n\tfor <dev@dpdk.org>; Wed, 2 Sep 2015 15:18:12 +0200 (CEST)", "by wicfx3 with SMTP id fx3so17428113wic.1\n\tfor <dev@dpdk.org>; Wed, 02 Sep 2015 06:18:12 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\ti6sm32392938wje.33.2015.09.02.06.18.11\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Sep 2015 06:18:12 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=x8hbNr0B4YkHyyi+IizB8r8erCLz1xtU5OSNFqN43Ec=;\n\tb=l0dfC+r4iACwLhqXdzaAFrQa2N5OwLnQDaBcuPecOnDQvVSkdyTS0cAAyt7JFHOS+B\n\tU5wkPoPn39r8fNZHE93+4Sfr6rkoLUQHJWFw9H/6t3T2+ZL0lm2fY1ftDwmg3kySPtbC\n\tvSYiwIAv1/IaSctnEw53UOgkTEnmpHlSmIAmVOQONxWN4W05U5V5F0k0xOt3h3B4lnPM\n\tpD7MM7GuMVKYseRxgGgpuECvHOa5nAufHpLR+QVEhkw2DxdKpyL5ukY2bNZ+xXHl4WvU\n\tQhHdWsTYVItXjMu08i5FrWFQY5tvJ3nD77vsAZgiDkY58kd0KnGGMotcJGQyEesmFpPL\n\t3x9g==", "X-Gm-Message-State": "ALoCoQkjK94mTcp6ZS72/LmfHp1C0WRev/d90XoAAr1x/D7MQ2AfgT7DliJWa1tLveOw8p/d52+4", "X-Received": "by 10.194.122.97 with SMTP id lr1mr39717363wjb.26.1441199892588; \n\tWed, 02 Sep 2015 06:18:12 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 2 Sep 2015 15:16:43 +0200", "Message-Id": "<1441199803-27055-11-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.1", "In-Reply-To": "<1441199803-27055-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1441199803-27055-1-git-send-email-thomas.monjalon@6wind.com>", "Cc": "Stephen Hemminger <shemming@brocade.com>", "Subject": "[dpdk-dev] [PATCH v2 10/10] ring: remove deprecated functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <shemming@brocade.com>\n\nThese were deprecated in 2.0 so remove them from 2.2.\nThe library version is incremented.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\nAcked-by: Neil Horman <nhorman@tuxdriver.com>\n---\n doc/guides/rel_notes/deprecation.rst | 3 --\n doc/guides/rel_notes/release_2_2.rst | 5 ++-\n drivers/net/ring/Makefile | 2 +-\n drivers/net/ring/rte_eth_ring.c | 56 -------------------------------\n drivers/net/ring/rte_eth_ring.h | 3 --\n drivers/net/ring/rte_eth_ring_version.map | 2 --\n 6 files changed, 5 insertions(+), 66 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 04819fa..5f6079b 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -40,9 +40,6 @@ Deprecation Notices\n the tunnel type, TNI/VNI, inner MAC and inner VLAN are monitored.\n The release 2.2 will contain these changes without backwards compatibility.\n \n-* librte_pmd_ring: The deprecated functions rte_eth_ring_pair_create and\n- rte_eth_ring_pair_attach should be removed.\n-\n * ABI changes are planned for struct virtio_net in order to support vhost-user\n multiple queues feature.\n It should be integrated in release 2.2 without backward compatibility.\ndiff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst\nindex 6dcfe88..abe57b4 100644\n--- a/doc/guides/rel_notes/release_2_2.rst\n+++ b/doc/guides/rel_notes/release_2_2.rst\n@@ -24,6 +24,9 @@ API Changes\n * The deprecated KNI functions are removed:\n rte_kni_create(), rte_kni_get_port_id() and rte_kni_info_get().\n \n+* The deprecated ring PMD functions are removed:\n+ rte_eth_ring_pair_create() and rte_eth_ring_pair_attach().\n+\n \n ABI Changes\n -----------\n@@ -67,7 +70,7 @@ The libraries prepended with a plus sign were incremented in this version.\n librte_meter.so.1\n librte_pipeline.so.1\n librte_pmd_bond.so.1\n- librte_pmd_ring.so.1\n+ + librte_pmd_ring.so.2\n librte_port.so.1\n librte_power.so.1\n librte_reorder.so.1\ndiff --git a/drivers/net/ring/Makefile b/drivers/net/ring/Makefile\nindex e442d0b..ae83505 100644\n--- a/drivers/net/ring/Makefile\n+++ b/drivers/net/ring/Makefile\n@@ -41,7 +41,7 @@ CFLAGS += $(WERROR_FLAGS)\n \n EXPORT_MAP := rte_eth_ring_version.map\n \n-LIBABIVER := 1\n+LIBABIVER := 2\n \n #\n # all source are stored in SRCS-y\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 6fd3d0a..0ba36d5 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -391,62 +391,6 @@ eth_dev_ring_create(const char *name, const unsigned numa_node,\n \treturn 0;\n }\n \n-\n-static int\n-eth_dev_ring_pair_create(const char *name, const unsigned numa_node,\n-\t\tenum dev_action action)\n-{\n-\t/* rx and tx are so-called from point of view of first port.\n-\t * They are inverted from the point of view of second port\n-\t */\n-\tstruct rte_ring *rx[RTE_PMD_RING_MAX_RX_RINGS];\n-\tstruct rte_ring *tx[RTE_PMD_RING_MAX_TX_RINGS];\n-\tunsigned i;\n-\tchar rx_rng_name[RTE_RING_NAMESIZE];\n-\tchar tx_rng_name[RTE_RING_NAMESIZE];\n-\tunsigned num_rings = RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS,\n-\t\t\tRTE_PMD_RING_MAX_TX_RINGS);\n-\n-\tfor (i = 0; i < num_rings; i++) {\n-\t\tsnprintf(rx_rng_name, sizeof(rx_rng_name), \"ETH_RX%u_%s\", i, name);\n-\t\trx[i] = (action == DEV_CREATE) ?\n-\t\t\t\trte_ring_create(rx_rng_name, 1024, numa_node,\n-\t\t\t\t\t\tRING_F_SP_ENQ|RING_F_SC_DEQ) :\n-\t\t\t\trte_ring_lookup(rx_rng_name);\n-\t\tif (rx[i] == NULL)\n-\t\t\treturn -1;\n-\t\tsnprintf(tx_rng_name, sizeof(tx_rng_name), \"ETH_TX%u_%s\", i, name);\n-\t\ttx[i] = (action == DEV_CREATE) ?\n-\t\t\t\trte_ring_create(tx_rng_name, 1024, numa_node,\n-\t\t\t\t\t\tRING_F_SP_ENQ|RING_F_SC_DEQ):\n-\t\t\t\trte_ring_lookup(tx_rng_name);\n-\t\tif (tx[i] == NULL)\n-\t\t\treturn -1;\n-\t}\n-\n-\tif (rte_eth_from_rings(rx_rng_name, rx, num_rings, tx, num_rings,\n-\t\t\t\tnuma_node) < 0 ||\n-\t\t\trte_eth_from_rings(tx_rng_name, tx, num_rings, rx,\n-\t\t\t\tnum_rings, numa_node) < 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n-int\n-rte_eth_ring_pair_create(const char *name, const unsigned numa_node)\n-{\n-\tRTE_LOG(WARNING, PMD, \"rte_eth_ring_pair_create is deprecated\\n\");\n-\treturn eth_dev_ring_pair_create(name, numa_node, DEV_CREATE);\n-}\n-\n-int\n-rte_eth_ring_pair_attach(const char *name, const unsigned numa_node)\n-{\n-\tRTE_LOG(WARNING, PMD, \"rte_eth_ring_pair_attach is deprecated\\n\");\n-\treturn eth_dev_ring_pair_create(name, numa_node, DEV_ATTACH);\n-}\n-\n struct node_action_pair {\n \tchar name[PATH_MAX];\n \tunsigned node;\ndiff --git a/drivers/net/ring/rte_eth_ring.h b/drivers/net/ring/rte_eth_ring.h\nindex 2262249..5a69bff 100644\n--- a/drivers/net/ring/rte_eth_ring.h\n+++ b/drivers/net/ring/rte_eth_ring.h\n@@ -65,9 +65,6 @@ int rte_eth_from_rings(const char *name,\n \t\tconst unsigned nb_tx_queues,\n \t\tconst unsigned numa_node);\n \n-int rte_eth_ring_pair_create(const char *name, const unsigned numa_node);\n-int rte_eth_ring_pair_attach(const char *name, const unsigned numa_node);\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map\nindex 8ad107d..0875e25 100644\n--- a/drivers/net/ring/rte_eth_ring_version.map\n+++ b/drivers/net/ring/rte_eth_ring_version.map\n@@ -2,8 +2,6 @@ DPDK_2.0 {\n \tglobal:\n \n \trte_eth_from_rings;\n-\trte_eth_ring_pair_attach;\n-\trte_eth_ring_pair_create;\n \n \tlocal: *;\n };\n", "prefixes": [ "dpdk-dev", "v2", "10/10" ] }