Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68676/?format=api
{ "id": 68676, "url": "http://patches.dpdk.org/api/patches/68676/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200416124258.15549-8-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200416124258.15549-8-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200416124258.15549-8-i.dyukov@samsung.com", "date": "2020-04-16T12:42:58", "name": "[v12,7/7] net/virtio: Support of VIRTIO_NET_F_SPEED_DUPLEX", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "79a5225241bb2967363b4cc43c44c3e624f75db9", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200416124258.15549-8-i.dyukov@samsung.com/mbox/", "series": [ { "id": 9425, "url": "http://patches.dpdk.org/api/series/9425/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9425", "date": "2020-04-16T12:42:52", "name": "[v12,1/7] ethdev: added UNKNOWN speed value", "version": 12, "mbox": "http://patches.dpdk.org/series/9425/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/68676/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/68676/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D2DFA0588;\n\tThu, 16 Apr 2020 14:44:36 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 360061DC88;\n\tThu, 16 Apr 2020 14:43:26 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 406A71DC49\n for <dev@dpdk.org>; Thu, 16 Apr 2020 14:43:22 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200416124322euoutp0199a3320324ef4be65450e1d599f03255~GTWIDr7iH0589505895euoutp01X\n for <dev@dpdk.org>; Thu, 16 Apr 2020 12:43:22 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200416124321eucas1p1f24f34c2747091ceb29e425ad6143964~GTWHze-2C1957019570eucas1p1m;\n Thu, 16 Apr 2020 12:43:21 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 9E.B2.60679.9E2589E5; Thu, 16\n Apr 2020 13:43:21 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200416124321eucas1p2768f2846666ffad04efcadd871859cf9~GTWHgB3mt0431804318eucas1p2M;\n Thu, 16 Apr 2020 12:43:21 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200416124321eusmtrp227169b20d56344e44120af2d3973e9a8~GTWHfczOP1274212742eusmtrp2A;\n Thu, 16 Apr 2020 12:43:21 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 9A.BA.08375.9E2589E5; Thu, 16\n Apr 2020 13:43:21 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200416124320eusmtip26616a27cd80fec57b08e718391144de1~GTWG1FCgo0292802928eusmtip2Z;\n Thu, 16 Apr 2020 12:43:20 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200416124322euoutp0199a3320324ef4be65450e1d599f03255~GTWIDr7iH0589505895euoutp01X", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1587041002;\n bh=iR2nubcRfZZfuamrSwGwMbAQtyb7R+YhVTXAXvQjG0U=;\n h=From:To:Subject:Date:In-Reply-To:References:From;\n b=G9D1vzPuzB9DO99w9tXHtPoNAZo6xF2T3FJhOpEoN5h4N4RF1HV9H1H5LJiciuQMn\n b5m/bg+5NU9yQSxQFIsNdE4h3MbZj9hzMYvwqMr46BmxuC/Xh71t6jp/WAyxLXk5fx\n OAj2u2MnmLXKhMhSIwFTLPtC9Z8FFDd48LX0PNT0=", "X-AuditID": "cbfec7f4-0cbff7000001ed07-9c-5e9852e9f1c3", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, i.dyukov@samsung.com,\n v.kuramshin@samsung.com, amorenoz@redhat.com, zhihong.wang@intel.com,\n xiaolong.ye@intel.com, mb@smartsharesystems.com", "Date": "Thu, 16 Apr 2020 15:42:58 +0300", "Message-Id": "<20200416124258.15549-8-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200416124258.15549-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWy7djP87ovg2bEGdy6rGPRuuMBi8W7T9uZ\n LGZdamK3ONa5h8Wi79dVRovTNzezW/x5Y2qx+eIkJgcOj18LlrJ6LN7zksnj/b6rbB59W1Yx\n epx61M0cwBrFZZOSmpNZllqkb5fAlTF35yX2gjsSFadm9DA2MK4Q6WLk5JAQMJF4saeDqYuR\n i0NIYAWjxLvexawQzhdGiYVPVzBCOJ8ZJR5PbmGDadm85AAzRGI5o8Sn/gtQzldGiZWP1zCD\n VLEJaEic7pjHBGKLCOxllDh2pgDEFhbwlJj1bj/QWA4OFgFVid/driBhXgFLieMPD7FALJCX\n WL3hANgYTgEribvdr8BOkhB4zyZxf/5tqCIXia9LljFD2MISr45vYYewZST+75zPBGFXS3zf\n dJ0dormDUeLeolaoInuJLa/PsYMcwSygKbF+lz5E2FFi7aLXLCBhCQE+iRtvBUHCzEDmpG3T\n mSHCvBIdbUIQ1UoSB05eggpLSPz9zQMR9pBonb0aGqJ7GCVu71zJPoFRbhbCrgWMjKsYxVNL\n i3PTU4uN8lLL9YoTc4tL89L1kvNzNzECk8Lpf8e/7GDc9SfpEKMAB6MSD2+C/Yw4IdbEsuLK\n 3EOMEhzMSiK8fKZAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzGi17GCgmkJ5akZqemFqQWwWSZ\n ODilGhinfr85+/3dCadSw+85x7mUeb0OOhus/2iRpZ6w7mPGaVYb/7L/SP7kWvrWUSBYnkFU\n MOxHVO7SZdpX9pkUs7xZlirkeeid6o95cvcuRLqEblrA4hOhrhnPcGtljfMr6SIuOX7W84W7\n 1L/tPurM8FD6+lV3dekL2qzNT7RnqdmskVdL6350Ya8SS3FGoqEWc1FxIgDVsYbsBgMAAA==", "\n H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t/xe7ovg2bEGXxZJGHRuuMBi8W7T9uZ\n LGZdamK3ONa5h8Wi79dVRovTNzezW/x5Y2qx+eIkJgcOj18LlrJ6LN7zksnj/b6rbB59W1Yx\n epx61M0cwBqlZ1OUX1qSqpCRX1xiqxRtaGGkZ2hpoWdkYqlnaGwea2VkqqRvZ5OSmpNZllqk\n b5eglzF35yX2gjsSFadm9DA2MK4Q6WLk5JAQMJHYvOQAcxcjF4eQwFJGicv7+5i6GDmAEhIS\n r58wQ9QIS/y51sUGUfOZUeLF+zPsIAk2AQ2J0x3zmEASIgLHGSV6Z/1nAkkIC3hKzHq3nxFk\n EIuAqsTvbleQMK+ApcTxh4dYIIbKS6zecABsAaeAlcTd7lesILaQQIbEwkuPWSYw8i5gZFjF\n KJJaWpybnltsqFecmFtcmpeul5yfu4kRGKTbjv3cvIPx0sbgQ4wCHIxKPLwJ9jPihFgTy4or\n cw8xSnAwK4nw8pkChXhTEiurUovy44tKc1KLDzGaAt00kVlKNDkfGEF5JfGGpobmFpaG5sbm\n xmYWSuK8HQIHY4QE0hNLUrNTUwtSi2D6mDg4pRoY5S7eksg722LM3Ch5XpRtIv8tv/0HQv5r\n OXnOX+Q6kVdFUJ0/OmbzPvFtm0o9Njl+djbdr/BGtfjJ1unnazyLNrgpcEcERBRffSRaVnZ7\n msyh5Ce8N2X0Z8xYwHfv0nQ17h6HhDOrtrw8p8/YtL7nTrHYd4Y40UxRSxld6VsfyvUOZu8O\n vCChxFKckWioxVxUnAgAo4Cm22gCAAA=" ], "X-CMS-MailID": "20200416124321eucas1p2768f2846666ffad04efcadd871859cf9", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200416124321eucas1p2768f2846666ffad04efcadd871859cf9", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200416124321eucas1p2768f2846666ffad04efcadd871859cf9", "References": "<20191212085012.9170-1-i.dyukov@samsung.com>\n <20200416124258.15549-1-i.dyukov@samsung.com>\n <CGME20200416124321eucas1p2768f2846666ffad04efcadd871859cf9@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v12 7/7] net/virtio: Support of\n\tVIRTIO_NET_F_SPEED_DUPLEX", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds a support of VIRTIO_NET_F_SPEED_DUPLEX feature\nfor virtio driver.\n\nThere are two ways to specify speed of the link:\n * 'speed' devarg\n * negotiate speed from qemu via VIRTIO_NET_F_SPEED_DUPLEX\nThe highest priority is devarg. If devarg is not specified,\ndriver tries to negotiate it from qemu.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 14 ++++++++++++++\n drivers/net/virtio/virtio_ethdev.h | 3 ++-\n drivers/net/virtio/virtio_pci.h | 15 +++++++++++++++\n 3 files changed, 31 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex b757edfcc..46d699773 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1718,6 +1718,20 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)\n \t\t hw->mac_addr[0], hw->mac_addr[1], hw->mac_addr[2],\n \t\t hw->mac_addr[3], hw->mac_addr[4], hw->mac_addr[5]);\n \n+\tif (vtpci_with_feature(hw, VIRTIO_NET_F_SPEED_DUPLEX)) {\n+\t\tconfig = &local_config;\n+\t\t/* if speed is not specified in devargs */\n+\t\tif (hw->speed == ETH_SPEED_NUM_UNKNOWN) {\n+\t\t\tvtpci_read_dev_config(hw,\n+\t\t\t\toffsetof(struct virtio_net_config, speed),\n+\t\t\t\t&config->speed, sizeof(config->speed));\n+\t\t\thw->speed = config->speed;\n+\t\t}\n+\t}\n+\n+\tPMD_INIT_LOG(DEBUG, \"link speed = %u%s\",\n+\t\thw->speed, hw->speed == ETH_SPEED_NUM_UNKNOWN ?\n+\t\t\"(UNKNOWN)\" : \"\");\n \tif (vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VQ)) {\n \t\tconfig = &local_config;\n \ndiff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex cd8947656..febaf17a8 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -37,7 +37,8 @@\n \t 1ULL << VIRTIO_F_RING_PACKED\t |\t\\\n \t 1ULL << VIRTIO_F_IOMMU_PLATFORM |\t\\\n \t 1ULL << VIRTIO_F_ORDER_PLATFORM |\t\\\n-\t 1ULL << VIRTIO_F_NOTIFICATION_DATA)\n+\t 1ULL << VIRTIO_F_NOTIFICATION_DATA | \\\n+\t 1ULL << VIRTIO_NET_F_SPEED_DUPLEX)\n \n #define VIRTIO_PMD_SUPPORTED_GUEST_FEATURES\t\\\n \t(VIRTIO_PMD_DEFAULT_GUEST_FEATURES |\t\\\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex ed98e11c3..2948760ab 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -141,6 +141,9 @@ struct virtnet_ctl;\n */\n #define VIRTIO_F_NOTIFICATION_DATA 38\n \n+/* Device set linkspeed and duplex */\n+#define VIRTIO_NET_F_SPEED_DUPLEX 63\n+\n /* The Guest publishes the used index for which it expects an interrupt\n * at the end of the avail ring. Host should ignore the avail->flags field. */\n /* The Host publishes the avail index for which it expects a kick\n@@ -306,6 +309,18 @@ struct virtio_net_config {\n \tuint16_t status;\n \tuint16_t max_virtqueue_pairs;\n \tuint16_t mtu;\n+\t/*\n+\t * speed, in units of 1Mb. All values 0 to INT_MAX are legal.\n+\t * Any other value stands for unknown.\n+\t */\n+\tuint32_t speed;\n+\t/*\n+\t * 0x00 - half duplex\n+\t * 0x01 - full duplex\n+\t * Any other value stands for unknown.\n+\t */\n+\tuint8_t duplex;\n+\n } __attribute__((packed));\n \n /*\n", "prefixes": [ "v12", "7/7" ] }