Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6851/?format=api
{ "id": 6851, "url": "http://patches.dpdk.org/api/patches/6851/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1441143062-2557-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1441143062-2557-3-git-send-email-thomas.monjalon@6wind.com", "date": "2015-09-01T21:30:56", "name": "[dpdk-dev,3/9] ethdev: remove SCTP flow entries switch", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "39268ad66ab1ece292f73ef453c502acde2698c4", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1441143062-2557-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6851/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 262528DAE;\n\tTue, 1 Sep 2015 23:32:25 +0200 (CEST)", "from mail-wi0-f182.google.com (mail-wi0-f182.google.com\n\t[209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 9D7148D9E\n\tfor <dev@dpdk.org>; Tue, 1 Sep 2015 23:32:23 +0200 (CEST)", "by wiclp12 with SMTP id lp12so44312213wic.1\n\tfor <dev@dpdk.org>; Tue, 01 Sep 2015 14:32:23 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tej5sm29085583wjd.22.2015.09.01.14.32.22\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 01 Sep 2015 14:32:23 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=3Tn9kqbJIPuPUsnBcq7o9/D5xgI0smk2hCHCb5m4R5o=;\n\tb=SQVER5AvfTbtB7E+92rReCM5xR18CVOrb068PpGlvHVJcRInTLtMtOpnHQd95K0GyW\n\tw3fXK5fh5I48oCLK+hU+R2ZPO04yO26rSsDp8ZU57Gao3x6JYVND5wFWWuWDgIxnKLuW\n\t+Dpop+IPhB5qCAfHemvOq7fk3qBhP2YE/nlHx3DvbDV/s8oMyuxqHeE8Kg7/SK7a6osM\n\tc9JJuZF1C9KZ86GHU6Lz/Mh7zA0de3VjcITSLKUi8ZhNwL4EK+VXnpioCTsTgTknM4Xw\n\tvCjpn5wMYA2peBqh3rqDoKbh7IGAcpErVWr7JIHGBqb/UFIeOs6Bo14AKIRsKkJploR6\n\tu3hQ==", "X-Gm-Message-State": "ALoCoQmJNEJ8RxTCphA4N4sVYoVD2EQUh1EEuH86XSD17Bmjqk3BShYutSmz19hmV8ZQiuEw6Kiq", "X-Received": "by 10.180.8.200 with SMTP id t8mr285734wia.34.1441143143403;\n\tTue, 01 Sep 2015 14:32:23 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Tue, 1 Sep 2015 23:30:56 +0200", "Message-Id": "<1441143062-2557-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.1", "In-Reply-To": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1441138697-25157-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH 3/9] ethdev: remove SCTP flow entries switch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The extended SCTP flow entries are now part of the standard API.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/test-pmd/cmdline.c | 4 ----\n doc/guides/rel_notes/deprecation.rst | 3 ---\n drivers/net/i40e/i40e_fdir.c | 4 ----\n lib/librte_ether/rte_eth_ctrl.h | 4 ----\n 4 files changed, 15 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 5799c9c..0f8f48f 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -7888,12 +7888,10 @@ cmd_flow_director_filter_parsed(void *parsed_result,\n \t\tIPV4_ADDR_TO_UINT(res->ip_src,\n \t\t\tentry.input.flow.sctp4_flow.ip.src_ip);\n \t\t/* need convert to big endian. */\n-#ifdef RTE_NEXT_ABI\n \t\tentry.input.flow.sctp4_flow.dst_port =\n \t\t\t\trte_cpu_to_be_16(res->port_dst);\n \t\tentry.input.flow.sctp4_flow.src_port =\n \t\t\t\trte_cpu_to_be_16(res->port_src);\n-#endif\n \t\tentry.input.flow.sctp4_flow.verify_tag =\n \t\t\t\trte_cpu_to_be_32(res->verify_tag_value);\n \t\tbreak;\n@@ -7917,12 +7915,10 @@ cmd_flow_director_filter_parsed(void *parsed_result,\n \t\tIPV6_ADDR_TO_ARRAY(res->ip_src,\n \t\t\tentry.input.flow.sctp6_flow.ip.src_ip);\n \t\t/* need convert to big endian. */\n-#ifdef RTE_NEXT_ABI\n \t\tentry.input.flow.sctp6_flow.dst_port =\n \t\t\t\trte_cpu_to_be_16(res->port_dst);\n \t\tentry.input.flow.sctp6_flow.src_port =\n \t\t\t\trte_cpu_to_be_16(res->port_src);\n-#endif\n \t\tentry.input.flow.sctp6_flow.verify_tag =\n \t\t\t\trte_cpu_to_be_32(res->verify_tag_value);\n \t\tbreak;\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 639ab18..cf5cd17 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -44,9 +44,6 @@ Deprecation Notices\n flow director filtering in VF. The release 2.1 does not contain these ABI\n changes, but release 2.2 will, and no backwards compatibility is planned.\n \n-* ABI change is planned to extend the SCTP flow's key input from release 2.1.\n- The change may be enabled in the release 2.1 with CONFIG_RTE_NEXT_ABI.\n-\n * ABI changes are planned for struct rte_eth_fdir_filter and\n rte_eth_fdir_masks in order to support new flow director modes,\n MAC VLAN and Cloud, on x550. The MAC VLAN mode means the MAC and\ndiff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c\nindex 8208273..c9ce98f 100644\n--- a/drivers/net/i40e/i40e_fdir.c\n+++ b/drivers/net/i40e/i40e_fdir.c\n@@ -822,7 +822,6 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf,\n \t\tsctp = (struct sctp_hdr *)(raw_pkt + sizeof(struct ether_hdr) +\n \t\t\t\t\t sizeof(struct ipv4_hdr));\n \t\tpayload = (unsigned char *)sctp + sizeof(struct sctp_hdr);\n-#ifdef RTE_NEXT_ABI\n \t\t/*\n \t\t * The source and destination fields in the transmitted packet\n \t\t * need to be presented in a reversed order with respect\n@@ -830,7 +829,6 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf,\n \t\t */\n \t\tsctp->src_port = fdir_input->flow.sctp4_flow.dst_port;\n \t\tsctp->dst_port = fdir_input->flow.sctp4_flow.src_port;\n-#endif\n \t\tsctp->tag = fdir_input->flow.sctp4_flow.verify_tag;\n \t\tbreak;\n \n@@ -873,7 +871,6 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf,\n \t\tsctp = (struct sctp_hdr *)(raw_pkt + sizeof(struct ether_hdr) +\n \t\t\t\t\t sizeof(struct ipv6_hdr));\n \t\tpayload = (unsigned char *)sctp + sizeof(struct sctp_hdr);\n-#ifdef RTE_NEXT_ABI\n \t\t/*\n \t\t * The source and destination fields in the transmitted packet\n \t\t * need to be presented in a reversed order with respect\n@@ -881,7 +878,6 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf,\n \t\t */\n \t\tsctp->src_port = fdir_input->flow.sctp6_flow.dst_port;\n \t\tsctp->dst_port = fdir_input->flow.sctp6_flow.src_port;\n-#endif\n \t\tsctp->tag = fdir_input->flow.sctp6_flow.verify_tag;\n \t\tbreak;\n \ndiff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h\nindex 4beb981..26b7b33 100644\n--- a/lib/librte_ether/rte_eth_ctrl.h\n+++ b/lib/librte_ether/rte_eth_ctrl.h\n@@ -335,10 +335,8 @@ struct rte_eth_tcpv4_flow {\n */\n struct rte_eth_sctpv4_flow {\n \tstruct rte_eth_ipv4_flow ip; /**< IPv4 fields to match. */\n-#ifdef RTE_NEXT_ABI\n \tuint16_t src_port; /**< SCTP source port to match. */\n \tuint16_t dst_port; /**< SCTP destination port to match. */\n-#endif\n \tuint32_t verify_tag; /**< Verify tag to match */\n };\n \n@@ -373,10 +371,8 @@ struct rte_eth_tcpv6_flow {\n */\n struct rte_eth_sctpv6_flow {\n \tstruct rte_eth_ipv6_flow ip; /**< IPv6 fields to match. */\n-#ifdef RTE_NEXT_ABI\n \tuint16_t src_port; /**< SCTP source port to match. */\n \tuint16_t dst_port; /**< SCTP destination port to match. */\n-#endif\n \tuint32_t verify_tag; /**< Verify tag to match */\n };\n \n", "prefixes": [ "dpdk-dev", "3/9" ] }