Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68075/?format=api
{ "id": 68075, "url": "http://patches.dpdk.org/api/patches/68075/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-13-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200409172502.1693-13-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200409172502.1693-13-l.wojciechow@partner.samsung.com", "date": "2020-04-09T17:25:01", "name": "[v3,12/13] app/test: add rte security capabilities get tests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "52ec6594ddae9fc82d8eeaa12d668e1e2e8e74d9", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-13-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9272, "url": "http://patches.dpdk.org/api/series/9272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9272", "date": "2020-04-09T17:24:49", "name": "Fixes and unit tests for librte_security", "version": 3, "mbox": "http://patches.dpdk.org/series/9272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/68075/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/68075/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 46C82A0597;\n\tThu, 9 Apr 2020 19:27:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6C4F41D443;\n\tThu, 9 Apr 2020 19:25:51 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 7D08E1D152\n for <dev@dpdk.org>; Thu, 9 Apr 2020 19:25:37 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172537euoutp0209625418feb6792eb2979c34e0bf40ea~ENrkXbeaA2229522295euoutp02K\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:37 +0000 (GMT)", "from eusmges1new.samsung.com (unknown [203.254.199.242]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200409172536eucas1p29d87b1885c875b91678dfea59c1022f4~ENrj7Our10369803698eucas1p2s\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:36 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges1new.samsung.com (EUCPMTA) with SMTP id D4.F2.61286.09A5F8E5; Thu, 9\n Apr 2020 18:25:36 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb~ENrjochmm2198621986eucas1p16\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:36 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172536eusmtrp15a0dcf736a19fe726700682e150549b7~ENrjn_UFe2463624636eusmtrp1P\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:36 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 35.48.07950.09A5F8E5; Thu, 9\n Apr 2020 18:25:36 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172536eusmtip1cbbc78d6a18a6b61941a1cfa7b34eceb~ENrjUEhbK0978609786eusmtip1v\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:36 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200409172537euoutp0209625418feb6792eb2979c34e0bf40ea~ENrkXbeaA2229522295euoutp02K", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586453137;\n bh=bbaULdOoK7Yqq1zoQqLeE0AbsAwWKDjSXHli5Qu5bes=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=buaryCoSemCltSbBIHzZqnByQPYp98cBXV4mS/ZSkTJFjUhCEJfeh2oHOvJWZlK5h\n zqweG2KLbD/Yxd6wmxn+Bn87btDTr/DTR8TaUXWBG//5SJJtchtTIEhgYOcqtZE4cs\n iZXPTXpJb4H8C8jpxeqg08fM824xv67AA5oehA8E=", "X-AuditID": "cbfec7f2-f0bff7000001ef66-3a-5e8f5a9012c3", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Thu, 9 Apr 2020 19:25:01 +0200", "Message-Id": "<20200409172502.1693-13-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200409172502.1693-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsWy7djP87oTovrjDD6+1rN492k7kwOjx68F\n S1kDGKO4bFJSczLLUov07RK4Mg6cjShYrl0xv20nUwPjN5UuRk4OCQETiYOtixi7GLk4hARW\n MEqc/bYRymlnklj+8CM7hNPGJLH3SC8zTEvv/JVsEInljBI/t3axwlX1n/jPBlLFJmArcWTm\n V1YQW0SARWLl9+8sIDazgIDE43vPwOLCAt4Sz/YdZgSxWQRUJV4euw7WyyvgKrGqfwYjxDZ5\n idUbDoBt5gSK3zp+iRlkmYTACjaJU3d2sEAUuUg07T0AdZ6wxKvjW9ghbBmJ05N7WCAatjFK\n XP39kxHC2c8ocb13BVSVtcThf7+BVnMAnacpsX6XPkTYUeLcr+tgYQkBPokbbwUhHuCTmLRt\n OjNEmFeio00IolpP4mnPVEaYtX/WPoE6zUNi1adN0AC6zCjx7s5XxgmM8rMQli1gZFzFKJ5a\n WpybnlpsmJdarlecmFtcmpeul5yfu4kRGMWn/x3/tIPx66WkQ4wCHIxKPLwGDP1xQqyJZcWV\n uYcYJTiYlUR4vZt644R4UxIrq1KL8uOLSnNSiw8xSnOwKInzGi96GSskkJ5YkpqdmlqQWgST\n ZeLglGpgTL/+K+L3F+6tv9e0+B0Ve5pz/f7SY11Lq62lZy/Uf6D/vff3GsYUPZv5hUYOHi0z\n 2MwO21yYu+Jezb1lDvpat+auXlCsurGEW3L6qzUehxwnRc/nnvfxX+L8y+lTD2tvUV+h/OER\n y6Ok05n2Sye0G8ru1X1Q7jv57UctlbcHNsn7HTo4ecZp/utKLMUZiYZazEXFiQBN1dQB3gIA\n AA==", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7oTovrjDJp3y1i8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GQfORhQs166Y37aTqYHxm0oXIyeHhICJRO/8lWxdjFwcQgJLGSWaJq5k7mLkAErISHy4JABR\n Iyzx51oXVE0Lk8SqlbeYQBJsArYSR2Z+ZQWxRQRYJFZ+/84CYjMLCEg8vvcMLC4s4C3xbN9h\n RhCbRUBV4uWx62wgNq+Aq8Sq/hmMEAvkJVZvOMAMYnMCxW8dvwRmCwnUS9zu+sM4gZFvASPD\n KkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMBw2nbs55YdjF3vgg8xCnAwKvHwGjD0xwmxJpYV\n V+YeYpTgYFYS4fVu6o0T4k1JrKxKLcqPLyrNSS0+xGgKdNREZinR5HxgqOeVxBuaGppbWBqa\n G5sbm1koifN2CByMERJITyxJzU5NLUgtgulj4uCUamA85vNh1RFBjp2WT91OXJtcl+Vse23t\n OYOPHx5wS1x93OmXZsC25oCKoI+wsKN5hXJpXWrB3Mddwh/9FGY38sSZ3mGoNKspvq+4+M0n\n ho7lydwHt8SwP4h4lhbQvnDeqxMPv8muOTCj1vzFjeDtfgVzxew+r1vR+qAkb3ltvIbbkylK\n mdc37DuvxFKckWioxVxUnAgAHMXLLz0CAAA=" ], "X-CMS-MailID": "20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb", "References": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <20200409172502.1693-1-l.wojciechow@partner.samsung.com>\n <CGME20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v3 12/13] app/test: add rte security capabilities\n\tget tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_capabilities_get function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 138 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 138 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex 53b9e122e..3570da2a2 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -440,6 +440,30 @@ mock_get_userdata(void *device,\n \treturn mock_get_userdata_exp.ret;\n }\n \n+/**\n+ * capabilities_get mockup\n+ *\n+ * Verified parameters: device.\n+ */\n+static struct mock_capabilities_get_data {\n+\tvoid *device;\n+\n+\tstruct rte_security_capability *ret;\n+\n+\tint called;\n+\tint failed;\n+} mock_capabilities_get_exp = {NULL, NULL, 0, 0};\n+\n+static const struct rte_security_capability *\n+mock_capabilities_get(void *device)\n+{\n+\tmock_capabilities_get_exp.called++;\n+\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_capabilities_get_exp, device);\n+\n+\treturn mock_capabilities_get_exp.ret;\n+}\n+\n /**\n * empty_ops\n *\n@@ -460,6 +484,7 @@ struct rte_security_ops mock_ops = {\n \t.session_destroy = mock_session_destroy,\n \t.set_pkt_metadata = mock_set_pkt_metadata,\n \t.get_userdata = mock_get_userdata,\n+\t.capabilities_get = mock_capabilities_get,\n };\n \n \n@@ -556,6 +581,7 @@ ut_setup(void)\n \tmock_session_destroy_exp.called = 0;\n \tmock_set_pkt_metadata_exp.called = 0;\n \tmock_get_userdata_exp.called = 0;\n+\tmock_capabilities_get_exp.called = 0;\n \n \tmock_session_create_exp.failed = 0;\n \tmock_session_update_exp.failed = 0;\n@@ -564,6 +590,7 @@ ut_setup(void)\n \tmock_session_destroy_exp.failed = 0;\n \tmock_set_pkt_metadata_exp.failed = 0;\n \tmock_get_userdata_exp.failed = 0;\n+\tmock_capabilities_get_exp.failed = 0;\n \n \treturn TEST_SUCCESS;\n }\n@@ -1658,6 +1685,106 @@ test_get_userdata_success(void)\n }\n \n \n+/**\n+ * rte_security_capabilities_get tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with NULL instance\n+ */\n+static int\n+test_capabilities_get_inv_context(void)\n+{\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_capabilities_get_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = NULL;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get with empty\n+ * security operations\n+ */\n+static int\n+test_capabilities_get_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get when capabilities_get\n+ * security operation fails\n+ */\n+static int\n+test_capabilities_get_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_capabilities_get_exp.device = NULL;\n+\tmock_capabilities_get_exp.ret = NULL;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, NULL, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_capabilities_get in successful execution path\n+ */\n+static int\n+test_capabilities_get_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tstruct rte_security_capability capabilities;\n+\n+\tmock_capabilities_get_exp.device = NULL;\n+\tmock_capabilities_get_exp.ret = &capabilities;\n+\n+\tconst struct rte_security_capability *ret;\n+\tret = rte_security_capabilities_get(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_capabilities_get,\n+\t\t\tret, &capabilities, \"%p\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_capabilities_get_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1759,6 +1886,17 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_get_userdata_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_capabilities_get_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v3", "12/13" ] }