Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/68072/?format=api
{ "id": 68072, "url": "http://patches.dpdk.org/api/patches/68072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-10-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200409172502.1693-10-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200409172502.1693-10-l.wojciechow@partner.samsung.com", "date": "2020-04-09T17:24:58", "name": "[v3,09/13] app/test: add rte security session destroy tests", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "093a791e2d701927ab1772f242476d89f1fa2252", "submitter": { "id": 1628, "url": "http://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-10-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 9272, "url": "http://patches.dpdk.org/api/series/9272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9272", "date": "2020-04-09T17:24:49", "name": "Fixes and unit tests for librte_security", "version": 3, "mbox": "http://patches.dpdk.org/series/9272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/68072/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/68072/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E162A0597;\n\tThu, 9 Apr 2020 19:27:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 50E791D41D;\n\tThu, 9 Apr 2020 19:25:47 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5B93A1D152\n for <dev@dpdk.org>; Thu, 9 Apr 2020 19:25:36 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172536euoutp025dd32a307cc0808d24088adff8618a62~ENrjT32H32229522295euoutp02J\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:36 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200409172535eucas1p24b523894175c6cde11693ac9ef0d4fa6~ENrjBjbPy0369803698eucas1p2q\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:35 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 82.50.60679.F8A5F8E5; Thu, 9\n Apr 2020 18:25:35 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d~ENriVtq7J2193421934eucas1p1G\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:35 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172535eusmtrp118732d4df1fcc1ee03b03fd08b6d8ddb~ENriVPsJH2463624636eusmtrp1M\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:35 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 2D.B9.08375.F8A5F8E5; Thu, 9\n Apr 2020 18:25:35 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172534eusmtip12b2ccc658c6fb3d7f43709c51367db56~ENriEf5QQ0971609716eusmtip1W\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:25:34 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200409172536euoutp025dd32a307cc0808d24088adff8618a62~ENrjT32H32229522295euoutp02J", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586453136;\n bh=igxkj1rh0eTu9I7h5X2CfjMMhnmGhIJ6tYnNcUVR9fk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=up54j6Sb6hWC84cUB5mcXXWGL7tgQZjGmuDs3Py/G7swc7R+akhwXheIfuAJdsS9Z\n +yueyuG9qvF92+2wRmmpVptrfRFynvWvUW6l6aCTI1IRptPGMtmfDHk4ToaXkvphH+\n SPWWnQ+ES7T4mm8Z4bkrpt5slZIvtB9CXpjMpAiQ=", "X-AuditID": "cbfec7f4-0e5ff7000001ed07-db-5e8f5a8fa146", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org", "Date": "Thu, 9 Apr 2020 19:24:58 +0200", "Message-Id": "<20200409172502.1693-10-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200409172502.1693-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsWy7djPc7r9Uf1xBh3/jC3efdrO5MDo8WvB\n UtYAxigum5TUnMyy1CJ9uwSujM5bG5kKmnUqZq76xtTA+EO1i5GDQ0LARGLVUpcuRi4OIYEV\n jBLL9jxjhHDamSQat31mhnDamCS+P3zE1MXICdYxfck+JojEckaJG+euIVQ1fPjOCFLFJmAr\n cWTmV1YQW0SARWLl9+8sIDazgIDE43vPwOLCAl4SRzccYAa5g0VAVWLSphSQMK+Aq8S1Wy+Z\n IZbJS6wGK+Hk4ASK3zp+CWyXhMAKNonPy68zQhS5SLw9sA/qOmGJV8e3sEPYMhKnJ/ewQDRs\n Y5S4+vsnI4Szn1Hieu8KqCpricP/frOBXMEsoCmxfpc+RNhR4sOsQ8yQQOKTuPFWEOJ+PolJ\n 26ZDhXklOtqEIKr1JJ72TGWEWftn7RMWCNtDYt7Oa+yQ8LnMKLF32mzGCYzysxCWLWBkXMUo\n nlpanJueWmyUl1quV5yYW1yal66XnJ+7iREYw6f/Hf+yg3HXn6RDjAIcjEo8vAYM/XFCrIll\n xZW5hxglOJiVRHi9m3rjhHhTEiurUovy44tKc1KLDzFKc7AoifMaL3oZKySQnliSmp2aWpBa\n BJNl4uCUamA0uXpvqoPx+YlVO4u+vimdrKxy7qpz0dqibTYTZml+c3yUvexqxtLT1tNutn7P\n 3vnrysyXe+UVu4v4nY53pX1i7hI6vNHEhP8U9+3wLdLb7BKYNsd5b5BIMdMKXvfrmd+tjoiP\n zPeu1r/pmZTWMFPtS/2RM9rfbPOPn/9bePmScDTDDgPflO4YJZbijERDLeai4kQAJn8Sh90C\n AAA=", "\n H4sIAAAAAAAAA+NgFlrFLMWRmVeSWpSXmKPExsVy+t/xu7r9Uf1xBs9+sVu8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GZ23NjIVNOtUzFz1jamB8YdqFyMnh4SAicT0JfuYuhi5OIQEljJK7Jj2CcjhAErISHy4JABR\n Iyzx51oXG0RNC5PEklcr2UASbAK2EkdmfmUFsUUEWCRWfv/OAmIzCwhIPL73DCwuLOAlcXTD\n AWaQmSwCqhKTNqWAhHkFXCWu3XrJDDFfXmI1WAknBydQ/NbxS2C2kEC9xO2uP4wTGPkWMDKs\n YhRJLS3OTc8tNtQrTswtLs1L10vOz93ECAynbcd+bt7BeGlj8CFGAQ5GJR5eA4b+OCHWxLLi\n ytxDjBIczEoivN5NvXFCvCmJlVWpRfnxRaU5qcWHGE2BbprILCWanA8M9bySeENTQ3MLS0Nz\n Y3NjMwslcd4OgYMxQgLpiSWp2ampBalFMH1MHJxSDYyWEhd9b6ucPHG8KDj1eXpJtsS+CbEv\n WdS+Bqb2f9/fcXfTqde5d9rPCQpUebOmxMXcnbTp4/c0FfvG9EP8G6vvma5o9LvSIMPyOfPO\n J819Uh4ROa0nlz6J/GLbu17nfDYrd5LuXc5Qtoh1Xyt5ko199ivLqJtPE0t8uurhOq9tr2dI\n m+c1fFRiKc5INNRiLipOBADEDSAMPQIAAA==" ], "X-CMS-MailID": "20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d", "References": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <20200409172502.1693-1-l.wojciechow@partner.samsung.com>\n <CGME20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v3 09/13] app/test: add rte security session\n\tdestroy tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add unit tests for rte_security_session_destroy function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 166 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 166 insertions(+)", "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex c495449b0..b1a907bd9 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -1137,6 +1137,159 @@ test_session_stats_get_success(void)\n }\n \n \n+/**\n+ * rte_security_session_destroy tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_session_destroy with NULL instance\n+ */\n+static int\n+test_session_destroy_inv_context(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(NULL, ut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_session_destroy_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = NULL;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with empty\n+ * security operations\n+ */\n+static int\n+test_session_destroy_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -ENOTSUP, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy with NULL sess parameter\n+ */\n+static int\n+test_session_destroy_inv_session(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx, NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -EINVAL, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 0);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy when session_destroy\n+ * security operation fails\n+ */\n+static int\n+test_session_destroy_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_destroy_exp.device = NULL;\n+\tmock_session_destroy_exp.sess = ut_params->sess;\n+\tmock_session_destroy_exp.ret = -1;\n+\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, -1, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 1);\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_destroy in successful execution path\n+ */\n+static int\n+test_session_destroy_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_destroy_exp.device = NULL;\n+\tmock_session_destroy_exp.sess = ut_params->sess;\n+\tmock_session_destroy_exp.ret = 0;\n+\tTEST_ASSERT_MEMPOOL_USAGE(1);\n+\tTEST_ASSERT_SESSION_COUNT(1);\n+\n+\tint ret = rte_security_session_destroy(&ut_params->ctx,\n+\t\t\tut_params->sess);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_destroy,\n+\t\t\tret, 0, \"%d\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_destroy_exp, 1);\n+\tTEST_ASSERT_MEMPOOL_USAGE(0);\n+\tTEST_ASSERT_SESSION_COUNT(0);\n+\n+\t/*\n+\t * Remove session from test case parameters, so it won't be destroyed\n+\t * during test case teardown.\n+\t */\n+\tut_params->sess = NULL;\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n * Declaration of testcases\n */\n@@ -1201,6 +1354,19 @@ static struct unit_test_suite security_testsuite = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_session_stats_get_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_inv_session),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_destroy_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n", "prefixes": [ "v3", "09/13" ] }