Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 68070,
    "url": "http://patches.dpdk.org/api/patches/68070/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-8-l.wojciechow@partner.samsung.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200409172502.1693-8-l.wojciechow@partner.samsung.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200409172502.1693-8-l.wojciechow@partner.samsung.com",
    "date": "2020-04-09T17:24:56",
    "name": "[v3,07/13] app/test: add rte security session get size tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9d9d08c03c86b982c0ec6662a98c693d8b813e6d",
    "submitter": {
        "id": 1628,
        "url": "http://patches.dpdk.org/api/people/1628/?format=api",
        "name": "Lukasz Wojciechowski",
        "email": "l.wojciechow@partner.samsung.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200409172502.1693-8-l.wojciechow@partner.samsung.com/mbox/",
    "series": [
        {
            "id": 9272,
            "url": "http://patches.dpdk.org/api/series/9272/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9272",
            "date": "2020-04-09T17:24:49",
            "name": "Fixes and unit tests for librte_security",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/9272/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/68070/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/68070/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 20863A0597;\n\tThu,  9 Apr 2020 19:26:48 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A9FC91D411;\n\tThu,  9 Apr 2020 19:25:44 +0200 (CEST)",
            "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 143631C43F\n for <dev@dpdk.org>; Thu,  9 Apr 2020 19:25:35 +0200 (CEST)",
            "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172534euoutp01e441fb7940ff86a18caade9b09f98fe0~ENriCjyZS0657706577euoutp01X\n for <dev@dpdk.org>; Thu,  9 Apr 2020 17:25:34 +0000 (GMT)",
            "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200409172534eucas1p2a16ee6de118626bb6c4d9d2f9496b1d5~ENrh58bqT2398523985eucas1p25\n for <dev@dpdk.org>; Thu,  9 Apr 2020 17:25:34 +0000 (GMT)",
            "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 62.50.60679.E8A5F8E5; Thu,  9\n Apr 2020 18:25:34 +0100 (BST)",
            "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f~ENrhlVghu0369803698eucas1p2n\n for <dev@dpdk.org>; Thu,  9 Apr 2020 17:25:34 +0000 (GMT)",
            "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200409172534eusmtrp1bee3c0c3f30441b0833d35a5b1cdf859~ENrhk137u2463624636eusmtrp1J\n for <dev@dpdk.org>; Thu,  9 Apr 2020 17:25:34 +0000 (GMT)",
            "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id D4.48.07950.E8A5F8E5; Thu,  9\n Apr 2020 18:25:34 +0100 (BST)",
            "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200409172534eusmtip171f7ea7802590ccd045d7c99837abede~ENrhS7Biq0978609786eusmtip1u\n for <dev@dpdk.org>; Thu,  9 Apr 2020 17:25:33 +0000 (GMT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200409172534euoutp01e441fb7940ff86a18caade9b09f98fe0~ENriCjyZS0657706577euoutp01X",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1586453134;\n bh=QqhM7SFSEoVaEdMEtC+Yi4ZZhSzv0A99gHzsJFwdofY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=gT+yVZONEO1OIQnQW6JAfjunqc6axVaW6HXAjXjQy2FkozzFkT2ETxiKEKHe8dSyM\n GALddHnZmvhzd6uPJ7qe0zIdmfS+ttmxY4Q1JaOLULJ5jBOp8qMDFm5aU2LN3U6t4X\n zR9JBL2vYc07ivnMJZ1FTd/mrh2vuKsr2/Z5lLsw=",
        "X-AuditID": "cbfec7f4-0e5ff7000001ed07-d9-5e8f5a8e862e",
        "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>",
        "To": "",
        "Cc": "dev@dpdk.org",
        "Date": "Thu,  9 Apr 2020 19:24:56 +0200",
        "Message-Id": "<20200409172502.1693-8-l.wojciechow@partner.samsung.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200409172502.1693-1-l.wojciechow@partner.samsung.com>",
        "X-Brightmail-Tracker": [
            "\n H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsWy7djP87p9Uf1xBgdvqVm8+7SdyYHR49eC\n pawBjFFcNimpOZllqUX6dglcGT27L7AVXNSoaDvWytjAeEypi5GTQ0LAROLSxUmMXYxcHEIC\n KxglHuz8B+W0M0m8W3qYCaRKSKCNSeLzDQWYjqdzOpkhipYzSjybsocFwgEq+rnwOytIFZuA\n rcSRmV/BbBEBFomV37+zgNjMAgISj+89A4sLC3hLLDz/ixHEZhFQlXh1vBMszivgIrFvzj1G\n iG3yEqs3HGAGsTkFXCVuHb8EtllCYA2bxJuVp5khilwkVj3+wgphCwMN2sIOYctInJ7cwwLR\n sI1R4urvn4wQzn5Gieu9K6CqrCUO//vN1sXIAXSepsT6XfogpoSAo8TexckQJp/EjbeCEPfz\n SUzaNp0ZIswr0dEmBDFDT+Jpz1RGmK1/1j5hgbA9JI7OAQUiKHwuM0o86brKMoFRfhbCrgWM\n jKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzECY/j0v+NfdjDu+pN0iFGAg1GJh9eAoT9O\n iDWxrLgy9xCjBAezkgivd1NvnBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXFe40UvY4UE0hNLUrNT\n UwtSi2CyTBycUg2MKias9ZdrwvsdtM4HO3Ub1aisj955V02JpXlmAvsUT6Vtq7jfnZToPxj1\n sH67+meNM3nHdBWMOs86Hn59r/XoKmU7Fk9TrgqOmvmuhw7dMVfzFXyzIVGskncyj6PXBcuN\n aquCa7NDjrbu3HE549EBY9UXvGfq9rruW7Pp5uHf03eynucpVm1QYinOSDTUYi4qTgQAKu6g\n Sd0CAAA=",
            "\n H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsVy+t/xu7p9Uf1xBrc+C1q8+7SdyYHR49eC\n pawBjFF6NkX5pSWpChn5xSW2StGGFkZ6hpYWekYmlnqGxuaxVkamSvp2NimpOZllqUX6dgl6\n GT27L7AVXNSoaDvWytjAeEypi5GTQ0LAROLpnE7mLkYuDiGBpYwSNw8/Yu1i5ABKyEh8uCQA\n USMs8edaFxtETQuTxPz3X9hBEmwCthJHZn5lBbFFBFgkVn7/zgJiMwsISDy+9wwsLizgLbHw\n /C9GEJtFQFXi1fFOsDivgIvEvjn3GCEWyEus3nCAGcTmFHCVuHX8EpgtJFAvcbvrD+MERr4F\n jAyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAgNq27GfW3Ywdr0LPsQowMGoxMNrwNAfJ8Sa\n WFZcmXuIUYKDWUmE17upN06INyWxsiq1KD++qDQntfgQoynQUROZpUST84HBnlcSb2hqaG5h\n aWhubG5sZqEkztshcDBGSCA9sSQ1OzW1ILUIpo+Jg1OqgdHlbJn0Ba89LI8T/wWsKXQUn/3z\n noXxxhme6cfZPOvqDxT9j2q1y7tp57OXYe+eAv3vno4/M9lFPOWeOblu35T3f9/MqQUrT94O\n /3bq6VZvLe/T/3c7t36e/+9ye0J08TZNE9GDvaEsCZLXRD5s/J6zyVHvwp3JU544Za1y7rkh\n GmTk27aZtVOJpTgj0VCLuag4EQC/oECVPgIAAA=="
        ],
        "X-CMS-MailID": "20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f",
        "X-Msg-Generator": "CA",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "X-RootMTR": "20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f",
        "X-EPHeader": "CA",
        "CMS-TYPE": "201P",
        "X-CMS-RootMailID": "20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f",
        "References": "<20200408031351.4288-1-l.wojciechow@partner.samsung.com>\n <20200409172502.1693-1-l.wojciechow@partner.samsung.com>\n <CGME20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f@eucas1p2.samsung.com>",
        "Subject": "[dpdk-dev] [PATCH v3 07/13] app/test: add rte security session get\n\tsize tests",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add unit tests for rte_security_session_get_size function.\n\nSigned-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n app/test/test_security.c | 132 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 132 insertions(+)",
    "diff": "diff --git a/app/test/test_security.c b/app/test/test_security.c\nindex daaf30b62..9c5e7d0da 100644\n--- a/app/test/test_security.c\n+++ b/app/test/test_security.c\n@@ -268,6 +268,30 @@ mock_session_update(void *device,\n \treturn mock_session_update_exp.ret;\n }\n \n+/**\n+ * session_get_size mockup\n+ *\n+ * Verified parameters: device.\n+ */\n+static struct mock_session_get_size_data {\n+\tvoid *device;\n+\n+\tunsigned int ret;\n+\n+\tint called;\n+\tint failed;\n+} mock_session_get_size_exp = {NULL, 0U, 0, 0};\n+\n+static unsigned int\n+mock_session_get_size(void *device)\n+{\n+\tmock_session_get_size_exp.called++;\n+\n+\tMOCK_TEST_ASSERT_POINTER_PARAMETER(mock_session_get_size_exp, device);\n+\n+\treturn mock_session_get_size_exp.ret;\n+}\n+\n /**\n  * session_destroy mockup\n  *\n@@ -309,6 +333,7 @@ struct rte_security_ops empty_ops = { NULL };\n struct rte_security_ops mock_ops = {\n \t.session_create = mock_session_create,\n \t.session_update = mock_session_update,\n+\t.session_get_size = mock_session_get_size,\n \t.session_destroy = mock_session_destroy,\n };\n \n@@ -401,10 +426,12 @@ ut_setup(void)\n \n \tmock_session_create_exp.called = 0;\n \tmock_session_update_exp.called = 0;\n+\tmock_session_get_size_exp.called = 0;\n \tmock_session_destroy_exp.called = 0;\n \n \tmock_session_create_exp.failed = 0;\n \tmock_session_update_exp.failed = 0;\n+\tmock_session_get_size_exp.failed = 0;\n \tmock_session_destroy_exp.failed = 0;\n \n \treturn TEST_SUCCESS;\n@@ -856,6 +883,100 @@ test_session_update_success(void)\n }\n \n \n+/**\n+ * rte_security_session_get_size tests\n+ */\n+\n+/**\n+ * Test execution of rte_security_session_get_size with NULL instance\n+ */\n+static int\n+test_session_get_size_inv_context(void)\n+{\n+\tunsigned int ret = rte_security_session_get_size(NULL);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_get_size,\n+\t\t\tret, 0, \"%u\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_get_size_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_get_size with invalid\n+ * security operations structure (NULL)\n+ */\n+static int\n+test_session_get_size_inv_context_ops(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = NULL;\n+\n+\tunsigned int ret = rte_security_session_get_size(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_get_size,\n+\t\t\tret, 0, \"%u\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_get_size_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_get_size with empty\n+ * security operations\n+ */\n+static int\n+test_session_get_size_inv_context_ops_fun(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\tut_params->ctx.ops = &empty_ops;\n+\n+\tunsigned int ret = rte_security_session_get_size(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_get_size,\n+\t\t\tret, 0, \"%u\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_get_size_exp, 0);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_get_size when session_get_size\n+ * security operation fails\n+ */\n+static int\n+test_session_get_size_ops_failure(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_get_size_exp.device = NULL;\n+\tmock_session_get_size_exp.ret = 0;\n+\n+\tunsigned int ret = rte_security_session_get_size(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_get_size,\n+\t\t\tret, 0, \"%u\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_get_size_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+/**\n+ * Test execution of rte_security_session_get_size in successful execution path\n+ */\n+static int\n+test_session_get_size_success(void)\n+{\n+\tstruct security_unittest_params *ut_params = &unittest_params;\n+\n+\tmock_session_get_size_exp.device = NULL;\n+\tmock_session_get_size_exp.ret = 1024;\n+\n+\tunsigned int ret = rte_security_session_get_size(&ut_params->ctx);\n+\tTEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_session_get_size,\n+\t\t\tret, 1024U, \"%u\");\n+\tTEST_ASSERT_MOCK_CALLS(mock_session_get_size_exp, 1);\n+\n+\treturn TEST_SUCCESS;\n+}\n+\n+\n /**\n  * Declaration of testcases\n  */\n@@ -896,6 +1017,17 @@ static struct unit_test_suite security_testsuite  = {\n \t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n \t\t\t\ttest_session_update_success),\n \n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_get_size_inv_context),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_get_size_inv_context_ops),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_get_size_inv_context_ops_fun),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_get_size_ops_failure),\n+\t\tTEST_CASE_ST(ut_setup_with_session, ut_teardown,\n+\t\t\t\ttest_session_get_size_success),\n+\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\n",
    "prefixes": [
        "v3",
        "07/13"
    ]
}