Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 67891,
    "url": "http://patches.dpdk.org/api/patches/67891/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1586233414-7644-1-git-send-email-wangyunjian@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1586233414-7644-1-git-send-email-wangyunjian@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1586233414-7644-1-git-send-email-wangyunjian@huawei.com",
    "date": "2020-04-07T04:23:34",
    "name": "[v3,5/5] net/tap: fix netlink socket file descriptor check before close",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "4b306fc8dc47539a9a50484b018cf1e04672dc25",
    "submitter": {
        "id": 551,
        "url": "http://patches.dpdk.org/api/people/551/?format=api",
        "name": "Yunjian Wang",
        "email": "wangyunjian@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1586233414-7644-1-git-send-email-wangyunjian@huawei.com/mbox/",
    "series": [
        {
            "id": 9222,
            "url": "http://patches.dpdk.org/api/series/9222/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9222",
            "date": "2020-04-07T04:22:26",
            "name": "fixes for tap",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/9222/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/67891/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/67891/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98441A0577;\n\tTue,  7 Apr 2020 06:23:49 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 777E81BF26;\n\tTue,  7 Apr 2020 06:23:49 +0200 (CEST)",
            "from huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by dpdk.org (Postfix) with ESMTP id 11CBB1BF1B;\n Tue,  7 Apr 2020 06:23:48 +0200 (CEST)",
            "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 3E4BC423BD0F2503066F;\n Tue,  7 Apr 2020 12:23:47 +0800 (CST)",
            "from localhost (10.173.251.152) by DGGEMS412-HUB.china.huawei.com\n (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Tue, 7 Apr 2020\n 12:23:36 +0800"
        ],
        "From": "wangyunjian <wangyunjian@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<keith.wiles@intel.com>, <jerry.lilijun@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>",
        "Date": "Tue, 7 Apr 2020 12:23:34 +0800",
        "Message-ID": "<1586233414-7644-1-git-send-email-wangyunjian@huawei.com>",
        "X-Mailer": "git-send-email 1.9.5.msysgit.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.173.251.152]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH v3 5/5] net/tap: fix netlink socket file\n\tdescriptor check before close",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Yunjian Wang <wangyunjian@huawei.com>\n\nThe \"internals->nlsk_fd\" is possibly a zero value. Error comparison\nshould check for negative fd.\n\nFixes: de96fe68ae95 (\"net/tap: add basic flow API patterns and actions\")\nCC: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 88cd615e0..ff149342b 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2442,7 +2442,7 @@ rte_pmd_tap_remove(struct rte_vdev_device *dev)\n \tTAP_LOG(DEBUG, \"Closing %s Ethernet device on numa %u\",\n \t\ttuntap_types[internals->type], rte_socket_id());\n \n-\tif (internals->nlsk_fd) {\n+\tif (internals->nlsk_fd >= 0) {\n \t\ttap_flow_flush(eth_dev, NULL);\n \t\ttap_flow_implicit_flush(internals, NULL);\n \t\ttap_nl_final(internals->nlsk_fd);\n",
    "prefixes": [
        "v3",
        "5/5"
    ]
}