Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67839/?format=api
{ "id": 67839, "url": "http://patches.dpdk.org/api/patches/67839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200405085613.1336841-18-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200405085613.1336841-18-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200405085613.1336841-18-jerinj@marvell.com", "date": "2020-04-05T08:56:01", "name": "[v4,17/29] node: add ethdev Tx node", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "13ce248e0fe2b9feab88ae80731990deecd76fef", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200405085613.1336841-18-jerinj@marvell.com/mbox/", "series": [ { "id": 9203, "url": "http://patches.dpdk.org/api/series/9203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9203", "date": "2020-04-05T08:55:44", "name": "graph: introduce graph subsystem", "version": 4, "mbox": "http://patches.dpdk.org/series/9203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67839/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67839/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6D198A0577;\n\tSun, 5 Apr 2020 11:00:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C13A81C043;\n\tSun, 5 Apr 2020 10:57:20 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 533F81BF59\n for <dev@dpdk.org>; Sun, 5 Apr 2020 10:57:19 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 0358uDlt031954; Sun, 5 Apr 2020 01:57:17 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 306srm29vq-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 05 Apr 2020 01:57:17 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sun, 5 Apr 2020 01:57:15 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sun, 5 Apr 2020 01:57:15 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id BE6E23F7040;\n Sun, 5 Apr 2020 01:57:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=cm78KWBDCnx41qdKD7pNmZvQmFS4Tjah0evugwZm40k=;\n b=f+fQwx9fIdcPMC6PJLuxWwp/9IDCZi+UYAoyA37YYbTL0NHYwlrTw7J0/ZZQWnWgbi8f\n ovNDu6i6d8Z3BJ1f6Nzn+JhCAjxH5fTR9b22Ng1wAY05BuXwB9kHaUUh6Az6uF2uMwAY\n B0y9EDxW+xV+2P5lh2XM27tbtiK+1wbnLAbG5a2EJfXCp4ZouUoN635j6sDRWvk8yg2R\n s9H7gnW2d3cBSOW2Zru0h/AKb4ikSF049J2bOCE2Uft84YsU4lB4i/wPv4YB8zoRa5vD\n +a7IaNptrTMOQi5QZKlLvWT4O0FswzsNw1MSNWqVQ4ILqc2nt76r1G/hRPJtEVM0eNwZ UA==", "From": "<jerinj@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <mdr@ashroe.eu>, <mattias.ronnblom@ericsson.com>,\n <kirankumark@marvell.com>, <xiao.w.wang@intel.com>", "Date": "Sun, 5 Apr 2020 14:26:01 +0530", "Message-ID": "<20200405085613.1336841-18-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200405085613.1336841-1-jerinj@marvell.com>", "References": "<20200331192945.2466880-1-jerinj@marvell.com>\n <20200405085613.1336841-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-04_19:2020-04-03,\n 2020-04-04 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 17/29] node: add ethdev Tx node", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nithin Dabilpuram <ndabilpuram@marvell.com>\n\nAdd rte_node ethdev_tx process function and register it to\ngraph infra. This node has a specific (port, tx-queue) as context\nand it enqueue's all the packets received to that specific queue pair.\nWhen rte_eth_tx_burst() i.e enqueue to queue pair fails, packets\nare forwarded to pkt_drop node to be free'd.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\n---\n lib/librte_node/Makefile | 3 +-\n lib/librte_node/ethdev_tx.c | 86 ++++++++++++++++++++++++++++++++\n lib/librte_node/ethdev_tx_priv.h | 62 +++++++++++++++++++++++\n lib/librte_node/meson.build | 4 +-\n 4 files changed, 152 insertions(+), 3 deletions(-)\n create mode 100644 lib/librte_node/ethdev_tx.c\n create mode 100644 lib/librte_node/ethdev_tx_priv.h", "diff": "diff --git a/lib/librte_node/Makefile b/lib/librte_node/Makefile\nindex 314149385..7428f6c43 100644\n--- a/lib/librte_node/Makefile\n+++ b/lib/librte_node/Makefile\n@@ -11,7 +11,7 @@ CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API\n CFLAGS += $(WERROR_FLAGS)\n # Strict-aliasing rules are violated by uint8_t[] to context size casts.\n CFLAGS += -fno-strict-aliasing\n-LDLIBS += -lrte_eal -lrte_graph -lrte_ethdev\n+LDLIBS += -lrte_eal -lrte_graph -lrte_mbuf -lrte_ethdev\n \n EXPORT_MAP := rte_node_version.map\n \n@@ -19,5 +19,6 @@ EXPORT_MAP := rte_node_version.map\n SRCS-$(CONFIG_RTE_LIBRTE_NODE) += null.c\n SRCS-$(CONFIG_RTE_LIBRTE_NODE) += log.c\n SRCS-$(CONFIG_RTE_LIBRTE_NODE) += ethdev_rx.c\n+SRCS-$(CONFIG_RTE_LIBRTE_NODE) += ethdev_tx.c\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_node/ethdev_tx.c b/lib/librte_node/ethdev_tx.c\nnew file mode 100644\nindex 000000000..075149089\n--- /dev/null\n+++ b/lib/librte_node/ethdev_tx.c\n@@ -0,0 +1,86 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+\n+#include <rte_debug.h>\n+#include <rte_ethdev.h>\n+#include <rte_graph.h>\n+#include <rte_graph_worker.h>\n+#include <rte_mbuf.h>\n+\n+#include \"ethdev_tx_priv.h\"\n+\n+static struct ethdev_tx_node_main ethdev_tx_main;\n+\n+static uint16_t\n+ethdev_tx_node_process(struct rte_graph *graph, struct rte_node *node,\n+\t\t void **objs, uint16_t nb_objs)\n+{\n+\tethdev_tx_node_ctx_t *ctx = (ethdev_tx_node_ctx_t *)node->ctx;\n+\tuint16_t port, queue;\n+\tuint16_t count;\n+\n+\t/* Get Tx port id */\n+\tport = ctx->port;\n+\tqueue = ctx->queue;\n+\n+\tcount = rte_eth_tx_burst(port, queue, (struct rte_mbuf **)objs,\n+\t\t\t\t nb_objs);\n+\n+\t/* Redirect unsent pkts to drop node */\n+\tif (count != nb_objs) {\n+\t\trte_node_enqueue(graph, node, ETHDEV_TX_NEXT_PKT_DROP,\n+\t\t\t\t &objs[count], nb_objs - count);\n+\t}\n+\n+\treturn count;\n+}\n+\n+static int\n+ethdev_tx_node_init(const struct rte_graph *graph, struct rte_node *node)\n+{\n+\tethdev_tx_node_ctx_t *ctx = (ethdev_tx_node_ctx_t *)node->ctx;\n+\tuint64_t port_id = RTE_MAX_ETHPORTS;\n+\tint i;\n+\n+\t/* Find our port id */\n+\tfor (i = 0; i < RTE_MAX_ETHPORTS; i++) {\n+\t\tif (ethdev_tx_main.nodes[i] == node->id) {\n+\t\t\tport_id = i;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\tRTE_VERIFY(port_id < RTE_MAX_ETHPORTS);\n+\n+\t/* Update port and queue */\n+\tctx->port = port_id;\n+\tctx->queue = graph->id;\n+\n+\treturn 0;\n+}\n+\n+struct ethdev_tx_node_main *\n+ethdev_tx_node_data_get(void)\n+{\n+\treturn ðdev_tx_main;\n+}\n+\n+static struct rte_node_register ethdev_tx_node_base = {\n+\t.process = ethdev_tx_node_process,\n+\t.name = \"ethdev_tx\",\n+\n+\t.init = ethdev_tx_node_init,\n+\n+\t.nb_edges = ETHDEV_TX_NEXT_MAX,\n+\t.next_nodes = {\n+\t\t[ETHDEV_TX_NEXT_PKT_DROP] = \"pkt_drop\",\n+\t},\n+};\n+\n+struct rte_node_register *\n+ethdev_tx_node_get(void)\n+{\n+\treturn ðdev_tx_node_base;\n+}\n+\n+RTE_NODE_REGISTER(ethdev_tx_node_base);\ndiff --git a/lib/librte_node/ethdev_tx_priv.h b/lib/librte_node/ethdev_tx_priv.h\nnew file mode 100644\nindex 000000000..586bff44a\n--- /dev/null\n+++ b/lib/librte_node/ethdev_tx_priv.h\n@@ -0,0 +1,62 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+#ifndef __INCLUDE_ETHDEV_TX_PRIV_H__\n+#define __INCLUDE_ETHDEV_TX_PRIV_H__\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+struct ethdev_tx_node_ctx;\n+typedef struct ethdev_tx_node_ctx ethdev_tx_node_ctx_t;\n+\n+enum ethdev_tx_next_nodes {\n+\tETHDEV_TX_NEXT_PKT_DROP,\n+\tETHDEV_TX_NEXT_MAX,\n+};\n+\n+/**\n+ * @internal\n+ *\n+ * Ethernet Tx node context structure.\n+ */\n+struct ethdev_tx_node_ctx {\n+\tuint16_t port;\t/**< Port identifier of the Ethernet Tx node. */\n+\tuint16_t queue; /**< Queue identifier of the Ethernet Tx node. */\n+};\n+\n+/**\n+ * @internal\n+ *\n+ * Ethernet Tx node main structure.\n+ */\n+struct ethdev_tx_node_main {\n+\tuint32_t nodes[RTE_MAX_ETHPORTS]; /**< Tx nodes for each ethdev port. */\n+};\n+\n+/**\n+ * @internal\n+ *\n+ * Get the Ethernet Tx node data.\n+ *\n+ * @return\n+ * Pointer to Ethernet Tx node data.\n+ */\n+struct ethdev_tx_node_main *ethdev_tx_node_data_get(void);\n+\n+/**\n+ * @internal\n+ *\n+ * Get the Ethernet Tx node.\n+ *\n+ * @retrun\n+ * Pointer to the Ethernet Tx node.\n+ */\n+struct rte_node_register *ethdev_tx_node_get(void);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* __INCLUDE_ETHDEV_TX_PRIV_H__ */\ndiff --git a/lib/librte_node/meson.build b/lib/librte_node/meson.build\nindex 94caa6c23..505c76abd 100644\n--- a/lib/librte_node/meson.build\n+++ b/lib/librte_node/meson.build\n@@ -1,8 +1,8 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(C) 2020 Marvell International Ltd.\n \n-sources = files('null.c', 'log.c', 'ethdev_rx.c')\n+sources = files('null.c', 'log.c', 'ethdev_rx.c', 'ethdev_tx.c')\n allow_experimental_apis = true\n # Strict-aliasing rules are violated by uint8_t[] to context size casts.\n cflags += '-fno-strict-aliasing'\n-deps += ['graph', 'ethdev']\n+deps += ['graph', 'mbuf', 'ethdev']\n", "prefixes": [ "v4", "17/29" ] }