Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67819/?format=api
{ "id": 67819, "url": "http://patches.dpdk.org/api/patches/67819/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200404151951.1013-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200404151951.1013-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200404151951.1013-1-pbhagavatula@marvell.com", "date": "2020-04-04T15:19:50", "name": "net/octeontx2: fix device configuration sequence", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0ae7324c986b767e71a5fdb029e9abd502643dce", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200404151951.1013-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 9200, "url": "http://patches.dpdk.org/api/series/9200/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9200", "date": "2020-04-04T15:19:50", "name": "net/octeontx2: fix device configuration sequence", "version": 1, "mbox": "http://patches.dpdk.org/series/9200/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67819/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/67819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE086A0562;\n\tSat, 4 Apr 2020 17:20:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A6CFD1BE99;\n\tSat, 4 Apr 2020 17:20:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8CB43F04;\n Sat, 4 Apr 2020 17:19:59 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 034FDI9x016913; Sat, 4 Apr 2020 08:19:58 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 306qkqrtja-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 04 Apr 2020 08:19:58 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sat, 4 Apr 2020 08:19:57 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sat, 4 Apr 2020 08:19:56 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 4 Apr 2020 08:19:56 -0700", "from BG-LT7430.marvell.com (BG-LT7430.marvell.com [10.28.163.117])\n by maili.marvell.com (Postfix) with ESMTP id 4C12B3F703F;\n Sat, 4 Apr 2020 08:19:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0818; bh=Y8esqzJgJChga2Ps+Xrv30dBdS6d/zCdup05ZpW2V1A=;\n b=HD7tJMTjXvNIcfiNc8w4ypkzcPpOB3u59SvLFrQNFo576gwVWmldvFjBmgTtbdmY87dY\n ty1uifWfgRQUIT+tkrgOkSKUVLRkYQhiy1+N6OV5pyZsc6B27gGbh3sghH2ljFf3YuFN\n Hu0xfemK2M97ZHfyBzbfDrdLLQo9Pq/slJGXorxMqTayevAjpnofxQx3DsWgq1BvA4mL\n xkk6fFofh82U94bY+SNJVtWhBWBGfhksyAB8PK9DXBNQolzhipoEiY0lKZnf46gpJpnT\n N/oOTy8IY6dLuZoKeaohKJUJMMTmOn8wa7DYtb/UVyqGev1yjsMTQCr9Ao4CLH0y387i tw==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>,\n <stable@dpdk.org>", "Date": "Sat, 4 Apr 2020 20:49:50 +0530", "Message-ID": "<20200404151951.1013-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-04_11:2020-04-03,\n 2020-04-04 signatures=0", "Subject": "[dpdk-dev] [PATCH] net/octeontx2: fix device configuration sequence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nWhen an application invokes rte_eth_dev_configure consecutively without\nsetting up Rx/Tx queues, it will incorrectly return error while trying\nto restore Rx/Tx queue configuration.\n\nFix configuration sequence by checking if any Rx/Tx queues are\npreviously configured before trying to restore them.\n\nFixes: 548b5839a32b (\"net/octeontx2: add device configure operation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n drivers/net/octeontx2/otx2_ethdev.c | 16 ++++++++++++----\n drivers/net/octeontx2/otx2_ethdev.h | 1 +\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex e60f4901c..9fbca2b05 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -1132,10 +1132,12 @@ nix_store_queue_cfg_and_then_release(struct rte_eth_dev *eth_dev)\n \ttxq = (struct otx2_eth_txq **)eth_dev->data->tx_queues;\n \tfor (i = 0; i < nb_txq; i++) {\n \t\tif (txq[i] == NULL) {\n-\t\t\totx2_err(\"txq[%d] is already released\", i);\n-\t\t\tgoto fail;\n+\t\t\ttx_qconf[i].valid = false;\n+\t\t\totx2_info(\"txq[%d] is already released\", i);\n+\t\t\tcontinue;\n \t\t}\n \t\tmemcpy(&tx_qconf[i], &txq[i]->qconf, sizeof(*tx_qconf));\n+\t\ttx_qconf[i].valid = true;\n \t\totx2_nix_tx_queue_release(txq[i]);\n \t\teth_dev->data->tx_queues[i] = NULL;\n \t}\n@@ -1143,10 +1145,12 @@ nix_store_queue_cfg_and_then_release(struct rte_eth_dev *eth_dev)\n \trxq = (struct otx2_eth_rxq **)eth_dev->data->rx_queues;\n \tfor (i = 0; i < nb_rxq; i++) {\n \t\tif (rxq[i] == NULL) {\n-\t\t\totx2_err(\"rxq[%d] is already released\", i);\n-\t\t\tgoto fail;\n+\t\t\trx_qconf[i].valid = false;\n+\t\t\totx2_info(\"rxq[%d] is already released\", i);\n+\t\t\tcontinue;\n \t\t}\n \t\tmemcpy(&rx_qconf[i], &rxq[i]->qconf, sizeof(*rx_qconf));\n+\t\trx_qconf[i].valid = true;\n \t\totx2_nix_rx_queue_release(rxq[i]);\n \t\teth_dev->data->rx_queues[i] = NULL;\n \t}\n@@ -1201,6 +1205,8 @@ nix_restore_queue_cfg(struct rte_eth_dev *eth_dev)\n \t * queues are already setup in port_configure().\n \t */\n \tfor (i = 0; i < nb_txq; i++) {\n+\t\tif (!tx_qconf[i].valid)\n+\t\t\tcontinue;\n \t\trc = otx2_nix_tx_queue_setup(eth_dev, i, tx_qconf[i].nb_desc,\n \t\t\t\t\t tx_qconf[i].socket_id,\n \t\t\t\t\t &tx_qconf[i].conf.tx);\n@@ -1216,6 +1222,8 @@ nix_restore_queue_cfg(struct rte_eth_dev *eth_dev)\n \tfree(tx_qconf); tx_qconf = NULL;\n \n \tfor (i = 0; i < nb_rxq; i++) {\n+\t\tif (!rx_qconf[i].valid)\n+\t\t\tcontinue;\n \t\trc = otx2_nix_rx_queue_setup(eth_dev, i, rx_qconf[i].nb_desc,\n \t\t\t\t\t rx_qconf[i].socket_id,\n \t\t\t\t\t &rx_qconf[i].conf.rx,\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h\nindex e5684f9f0..238afb3a8 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.h\n+++ b/drivers/net/octeontx2/otx2_ethdev.h\n@@ -196,6 +196,7 @@ struct otx2_eth_qconf {\n \tvoid *mempool;\n \tuint32_t socket_id;\n \tuint16_t nb_desc;\n+\tuint8_t valid;\n };\n \n struct otx2_fc_info {\n", "prefixes": [] }