Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 67768,
    "url": "http://patches.dpdk.org/api/patches/67768/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200403153709.3703448-10-jerinj@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200403153709.3703448-10-jerinj@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200403153709.3703448-10-jerinj@marvell.com",
    "date": "2020-04-03T15:36:45",
    "name": "[v4,09/33] eal/trace: handle CTF keyword collision",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2f71b25affaa39d2d78ea74c094e9e5f953b6a0a",
    "submitter": {
        "id": 1188,
        "url": "http://patches.dpdk.org/api/people/1188/?format=api",
        "name": "Jerin Jacob Kollanukkaran",
        "email": "jerinj@marvell.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200403153709.3703448-10-jerinj@marvell.com/mbox/",
    "series": [
        {
            "id": 9192,
            "url": "http://patches.dpdk.org/api/series/9192/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9192",
            "date": "2020-04-03T15:36:36",
            "name": "DPDK Trace support",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/9192/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/67768/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/67768/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EF5E3A0562;\n\tFri,  3 Apr 2020 17:39:08 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F0A51C1C4;\n\tFri,  3 Apr 2020 17:37:35 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4901B1C1C4\n for <dev@dpdk.org>; Fri,  3 Apr 2020 17:37:34 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 033FaPHr029227; Fri, 3 Apr 2020 08:37:33 -0700",
            "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 304855y7e3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 03 Apr 2020 08:37:33 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 3 Apr 2020 08:37:32 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 3 Apr 2020 08:37:31 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 3 Apr 2020 08:37:31 -0700",
            "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 5662A3F703F;\n Fri,  3 Apr 2020 08:37:29 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=MR5rY+KVxdgm7gNRKXaHfWSSpB14QqT2rHD/8dtUbC0=;\n b=k1dd84tBqXM+/OoDGzwGzH2Pn9NAtDNDOm5HHOzqe9VH5o69yb48FKr8eIr6jfa03RZ6\n ZFhh/lXa2+U4fO+8abTH3V5cChnUPhe99yDTVZo4Gt1IvNdzp+WFKcFFutDBeXwv1kPi\n leGoJ8rrNKtM/AlA30/mcj0zcvQejMgQZE7fRqzLQTdEIurEiTJ2rZgOtWMAW1+wpms/\n onUwWbwr2kTHsp2tMuyKVmwtWSUAnJtMSKolILU+suOPdKCT/Xz4o4Sbiv/5Eb0ltUFJ\n WrM+BqY1L7Njyq2EGB3mFzn73ZXv81+iflGS35qyuM79YMRdNNAkPOmaiZaAmhWpwBFr 8w==",
        "From": "<jerinj@marvell.com>",
        "To": "Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>",
        "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <bruce.richardson@intel.com>,\n <david.marchand@redhat.com>, <mattias.ronnblom@ericsson.com>",
        "Date": "Fri, 3 Apr 2020 21:06:45 +0530",
        "Message-ID": "<20200403153709.3703448-10-jerinj@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20200403153709.3703448-1-jerinj@marvell.com>",
        "References": "<20200329144342.1543749-1-jerinj@marvell.com>\n <20200403153709.3703448-1-jerinj@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-03_11:2020-04-03,\n 2020-04-03 signatures=0",
        "Subject": "[dpdk-dev] [PATCH v4 09/33] eal/trace: handle CTF keyword collision",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nSome of the keyword like align, event, \".\" and \"->\" etc will be\nused in CTF metadata syntax. This patch support for handling\nthose keywords with DPDK events name.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++++++++++++++++++\n 1 file changed, 119 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_trace_ctf.c b/lib/librte_eal/common/eal_common_trace_ctf.c\nindex 5ad44cc8d..c4f00bf22 100644\n--- a/lib/librte_eal/common/eal_common_trace_ctf.c\n+++ b/lib/librte_eal/common/eal_common_trace_ctf.c\n@@ -215,12 +215,131 @@ meta_stream_emit(char **meta, int *offset)\n \treturn meta_copy(meta, offset, str, rc);\n }\n \n+static void\n+string_fixed_replace(char *input, const char *search, const char *replace)\n+{\n+\tchar *found;\n+\tsize_t len;\n+\n+\tfound = strstr(input, search);\n+\tif (found == NULL)\n+\t\treturn;\n+\n+\tif (strlen(found) != strlen(search))\n+\t\treturn;\n+\n+\tlen = strlen(replace);\n+\tmemcpy(found, replace, len);\n+\tfound[len] = '\\0';\n+}\n+\n+static void\n+ctf_fixup_align(char *str)\n+{\n+\tstring_fixed_replace(str, \"align\", \"_align\");\n+}\n+\n+static void\n+ctf_fixup_arrow_deref(char *str)\n+{\n+\tconst char *replace = \"_\";\n+\tconst char *search = \"->\";\n+\tchar *found;\n+\tsize_t len;\n+\n+\tfound = strstr(str, search);\n+\tif (found == NULL)\n+\t\treturn;\n+\n+\tdo {\n+\t\tmemcpy(found, replace, strlen(replace));\n+\t\tlen = strlen(found + 2);\n+\t\tmemcpy(found + 1, found + 2, len);\n+\t\tfound[len + 1] = '\\0';\n+\t\tfound = strstr(str, search);\n+\t} while (found != NULL);\n+}\n+\n+static void\n+ctf_fixup_dot_deref(char *str)\n+{\n+\tconst char *replace = \"_\";\n+\tconst char *search = \".\";\n+\tchar *found;\n+\tsize_t len;\n+\n+\tfound = strstr(str, search);\n+\tif (found == NULL)\n+\t\treturn;\n+\n+\tlen = strlen(replace);\n+\tdo {\n+\t\tmemcpy(found, replace, len);\n+\t\tfound = strstr(str, search);\n+\t} while (found != NULL);\n+}\n+\n+static void\n+ctf_fixup_event(char *str)\n+{\n+\tstring_fixed_replace(str, \"event\", \"_event\");\n+}\n+\n+static int\n+ctf_fixup_keyword(char *str)\n+{\n+\tchar dup_str[TRACE_CTF_FIELD_SIZE];\n+\tchar input[TRACE_CTF_FIELD_SIZE];\n+\tconst char *delim = \";\";\n+\tchar *from;\n+\tint len;\n+\n+\tif (str == NULL)\n+\t\treturn 0;\n+\n+\tlen = strlen(str);\n+\tif (len >= TRACE_CTF_FIELD_SIZE) {\n+\t\ttrace_err(\"ctf_field reached its maximum limit\");\n+\t\treturn -EMSGSIZE;\n+\t}\n+\n+\t/* Create duplicate string */\n+\tstrcpy(dup_str, str);\n+\n+\tlen = 0;\n+\tfrom = strtok(dup_str, delim);\n+\twhile (from != NULL) {\n+\t\tstrcpy(input, from);\n+\t\tctf_fixup_align(input);\n+\t\tctf_fixup_dot_deref(input);\n+\t\tctf_fixup_arrow_deref(input);\n+\t\tctf_fixup_event(input);\n+\n+\t\tstrcpy(&input[strlen(input)], delim);\n+\t\tif ((len + strlen(input)) >= TRACE_CTF_FIELD_SIZE) {\n+\t\t\ttrace_err(\"ctf_field reached its maximum limit\");\n+\t\t\treturn -EMSGSIZE;\n+\t\t}\n+\n+\t\tstrcpy(str + len, input);\n+\t\tlen += strlen(input);\n+\t\tfrom = strtok(NULL, delim);\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n meta_event_emit(char **meta, int *offset, struct trace_point *tp)\n {\n \tchar *str = NULL;\n \tint rc;\n \n+\t/* Fixup ctf field string in case it using reserved ctf keywords */\n+\trc = ctf_fixup_keyword(tp->ctf_field);\n+\tif (rc)\n+\t\treturn rc;\n+\n \trc = metadata_printf(&str,\n \t\t\"event {\\n\"\n \t\t\"    id = %d;\\n\"\n",
    "prefixes": [
        "v4",
        "09/33"
    ]
}