Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67760/?format=api
{ "id": 67760, "url": "http://patches.dpdk.org/api/patches/67760/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200403153709.3703448-2-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200403153709.3703448-2-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200403153709.3703448-2-jerinj@marvell.com", "date": "2020-04-03T15:36:37", "name": "[v4,01/33] meson: add libatomic as a global dependency for i686 clang", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2e12943e999aa51497691f9bb40b729dfb25100a", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200403153709.3703448-2-jerinj@marvell.com/mbox/", "series": [ { "id": 9192, "url": "http://patches.dpdk.org/api/series/9192/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9192", "date": "2020-04-03T15:36:36", "name": "DPDK Trace support", "version": 4, "mbox": "http://patches.dpdk.org/series/9192/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67760/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCF4CA0562;\n\tFri, 3 Apr 2020 17:37:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E29981C0C2;\n\tFri, 3 Apr 2020 17:37:09 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6AE151C0C2\n for <dev@dpdk.org>; Fri, 3 Apr 2020 17:37:08 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 033Faco6029268; Fri, 3 Apr 2020 08:37:05 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 304855y7ay-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 03 Apr 2020 08:37:05 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 3 Apr 2020 08:37:03 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 3 Apr 2020 08:37:03 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Fri, 3 Apr 2020 08:37:02 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id E0CB73F703F;\n Fri, 3 Apr 2020 08:36:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=t/hYBwlyqatsE7Idxddk5rwwUtCeIwo3U69xGvQrLqA=;\n b=tPCvPf5InA5kJrJLQ9SFVP+TNvf5G5Lvtc8Hcs1D9qIkz0nTddjGy7kwO/Wu4Dl3nvY5\n +BhfP2Vzj4zAq49DMUE0o1Lhn52U1TFMw9R9vXASVibcSmfd8KioFyv2Mh/hxZeVmYcX\n wHMQ4rXsTZuufDHIzjh4ZppeuCF9P4/kK3gO0FOtMROQpKXAWB3POf6qIQrhJUi8ie+P\n Ok96FNlJatlIa/B4naIDBO367jVAyF1Vxz0keePEvNTnrXJDYmPRl4fe04cZ+FSaTQAm\n lE7/MHrNgr1+usF0AFVJC2mzt1snJ5tVqRWhnS3bYXZ4TFvfJ9/TTpllQUGvUgFspSEv jg==", "From": "<jerinj@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerinj@marvell.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Liang Ma <liang.j.ma@intel.com>, Peter Mccarthy <peter.mccarthy@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Radu Nicolau <radu.nicolau@intel.com>, \"Akhil Goyal\" <akhil.goyal@nxp.com>,\n Tomasz Kantecki <tomasz.kantecki@intel.com>,\n Sunil Kumar Kori <skori@marvell.com>, David Hunt <david.hunt@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "CC": "<dev@dpdk.org>, <david.marchand@redhat.com>,\n <mattias.ronnblom@ericsson.com>", "Date": "Fri, 3 Apr 2020 21:06:37 +0530", "Message-ID": "<20200403153709.3703448-2-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200403153709.3703448-1-jerinj@marvell.com>", "References": "<20200329144342.1543749-1-jerinj@marvell.com>\n <20200403153709.3703448-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676\n definitions=2020-04-03_11:2020-04-03,\n 2020-04-03 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 01/33] meson: add libatomic as a global\n\tdependency for i686 clang", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd libatomic as a global dependency when compiling for 32-bit using\nclang. As we need libatomic for 64-bit atomic ops.\n\nCc: bruce.richardson@intel.com\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 8 ++++++++\n drivers/event/octeontx/meson.build | 5 -----\n drivers/event/octeontx2/meson.build | 5 -----\n drivers/event/opdl/meson.build | 5 -----\n examples/l2fwd-event/meson.build | 5 -----\n lib/librte_distributor/meson.build | 5 -----\n lib/librte_rcu/meson.build | 5 -----\n 7 files changed, 8 insertions(+), 30 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 58421342b..8a4c692a9 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -173,6 +173,14 @@ if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)\n \tdpdk_extra_ldflags += '-lpcap'\n endif\n \n+\n+# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n+if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n+\tatomic_dep = cc.find_library('atomic', required: true)\n+\tadd_project_link_arguments('-latomic', language: 'c')\n+\tdpdk_extra_ldflags += '-latomic'\n+endif\n+\n # add -include rte_config to cflags\n add_project_arguments('-include', 'rte_config.h', language: 'c')\n \ndiff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build\nindex 73118a485..2b74bb62d 100644\n--- a/drivers/event/octeontx/meson.build\n+++ b/drivers/event/octeontx/meson.build\n@@ -11,8 +11,3 @@ sources = files('ssovf_worker.c',\n )\n \n deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', 'pmd_octeontx']\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\ndiff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build\nindex 4b938416b..0ade51cec 100644\n--- a/drivers/event/octeontx2/meson.build\n+++ b/drivers/event/octeontx2/meson.build\n@@ -18,11 +18,6 @@ if not dpdk_conf.get('RTE_ARCH_64')\n \textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n endif\n \n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\n-\n foreach flag: extra_flags\n \tif cc.has_argument(flag)\n \t\tcflags += flag\ndiff --git a/drivers/event/opdl/meson.build b/drivers/event/opdl/meson.build\nindex 1fe034ea1..cc6029c6f 100644\n--- a/drivers/event/opdl/meson.build\n+++ b/drivers/event/opdl/meson.build\n@@ -9,8 +9,3 @@ sources = files(\n \t'opdl_test.c',\n )\n deps += ['bus_vdev']\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\ndiff --git a/examples/l2fwd-event/meson.build b/examples/l2fwd-event/meson.build\nindex c4664c3a3..4e9a069d6 100644\n--- a/examples/l2fwd-event/meson.build\n+++ b/examples/l2fwd-event/meson.build\n@@ -16,8 +16,3 @@ sources = files(\n \t'l2fwd_event_internal_port.c',\n \t'l2fwd_event_generic.c'\n )\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\ndiff --git a/lib/librte_distributor/meson.build b/lib/librte_distributor/meson.build\nindex 266af6434..bd12ddb2f 100644\n--- a/lib/librte_distributor/meson.build\n+++ b/lib/librte_distributor/meson.build\n@@ -9,8 +9,3 @@ else\n endif\n headers = files('rte_distributor.h')\n deps += ['mbuf']\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\ndiff --git a/lib/librte_rcu/meson.build b/lib/librte_rcu/meson.build\nindex 5929bd3a7..c009ae4b7 100644\n--- a/lib/librte_rcu/meson.build\n+++ b/lib/librte_rcu/meson.build\n@@ -3,8 +3,3 @@\n \n sources = files('rte_rcu_qsbr.c')\n headers = files('rte_rcu_qsbr.h')\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\n", "prefixes": [ "v4", "01/33" ] }