Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67435/?format=api
{ "id": 67435, "url": "http://patches.dpdk.org/api/patches/67435/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200330114538.43275-15-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200330114538.43275-15-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200330114538.43275-15-qi.z.zhang@intel.com", "date": "2020-03-30T11:45:36", "name": "[14/16] net/ice/base: change function to static", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "231b5976bf7f502f102439530b2739ed32597ef9", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200330114538.43275-15-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 9102, "url": "http://patches.dpdk.org/api/series/9102/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9102", "date": "2020-03-30T11:45:22", "name": "ice share code update", "version": 1, "mbox": "http://patches.dpdk.org/series/9102/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67435/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67435/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 959AEA057B;\n\tMon, 30 Mar 2020 13:44:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 37CDE1C118;\n\tMon, 30 Mar 2020 13:42:40 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id DDC431C0D0\n for <dev@dpdk.org>; Mon, 30 Mar 2020 13:42:35 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2020 04:42:35 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2020 04:42:33 -0700" ], "IronPort-SDR": [ "\n udn+HSZeiM0ZGKwblgWunhbh+xznWW1crc2rhSPDwvs/QUD8TUnZsGE5PlK3ERPrQhvQTaOlKk\n t0kMDbGYVKrA==", "\n wyZ5MTW6dOil/KcXkuoXyleyoS1xq7oC4KfrV3mI5XOsv12HUvquz4ZFj7+qrovX9/w3B/A3OX\n h/hLg0r4TEQg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,324,1580803200\"; d=\"scan'208\";a=\"449769918\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 30 Mar 2020 19:45:36 +0800", "Message-Id": "<20200330114538.43275-15-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200330114538.43275-1-qi.z.zhang@intel.com>", "References": "<20200330114538.43275-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 14/16] net/ice/base: change function to static", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change ice_set_fd_desc_val to static, since it only be used\ninternally.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_fdir.c | 97 +++++++++++++++++++----------------------\n drivers/net/ice/base/ice_fdir.h | 3 --\n 2 files changed, 45 insertions(+), 55 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c\nindex df754dc74..c703a7c6b 100644\n--- a/drivers/net/ice/base/ice_fdir.c\n+++ b/drivers/net/ice/base/ice_fdir.c\n@@ -381,62 +381,11 @@ ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx)\n }\n \n /**\n- * ice_fdir_get_prgm_desc - set a fdir descriptor from a fdir filter struct\n- * @hw: pointer to the hardware structure\n- * @input: filter\n- * @fdesc: filter descriptor\n- * @add: if add is true, this is an add operation, false implies delete\n- */\n-void\n-ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input,\n-\t\t struct ice_fltr_desc *fdesc, bool add)\n-{\n-\tstruct ice_fd_fltr_desc_ctx fdir_fltr_ctx = { 0 };\n-\n-\t/* set default context info */\n-\tice_set_dflt_val_fd_desc(&fdir_fltr_ctx);\n-\n-\t/* change sideband filtering values */\n-\tfdir_fltr_ctx.fdid = input->fltr_id;\n-\tif (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {\n-\t\tfdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;\n-\t\tfdir_fltr_ctx.qindex = 0;\n-\t} else if (input->dest_ctl ==\n-\t\t\tICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) {\n-\t\tfdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;\n-\t\tfdir_fltr_ctx.qindex = 0;\n-\t} else {\n-\t\tif (input->dest_ctl ==\n-\t\t ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)\n-\t\t\tfdir_fltr_ctx.toq = input->q_region;\n-\t\tfdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;\n-\t\tfdir_fltr_ctx.qindex = input->q_index;\n-\t}\n-\tfdir_fltr_ctx.cnt_ena = input->cnt_ena;\n-\tfdir_fltr_ctx.cnt_index = input->cnt_index;\n-\tfdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);\n-\tfdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;\n-\tif (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER)\n-\t\tfdir_fltr_ctx.toq_prio = 0;\n-\telse\n-\t\tfdir_fltr_ctx.toq_prio = 3;\n-\tfdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD :\n-\t\tICE_FXD_FLTR_QW1_PCMD_REMOVE;\n-\tfdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;\n-\tfdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO;\n-\tfdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;\n-\tfdir_fltr_ctx.fdid_prio = input->fdid_prio;\n-\tfdir_fltr_ctx.desc_prof = 1;\n-\tfdir_fltr_ctx.desc_prof_prio = 3;\n-\tice_set_fd_desc_val(&fdir_fltr_ctx, fdesc);\n-}\n-\n-/**\n * ice_set_fd_desc_val\n * @ctx: pointer to fd filter descriptor context\n * @fdir_desc: populated with fd filter descriptor values\n */\n-void\n+static void\n ice_set_fd_desc_val(struct ice_fd_fltr_desc_ctx *ctx,\n \t\t struct ice_fltr_desc *fdir_desc)\n {\n@@ -496,6 +445,50 @@ ice_set_fd_desc_val(struct ice_fd_fltr_desc_ctx *ctx,\n }\n \n /**\n+ * ice_fdir_get_prgm_desc - set a fdir descriptor from a fdir filter struct\n+ * @hw: pointer to the hardware structure\n+ * @input: filter\n+ * @fdesc: filter descriptor\n+ * @add: if add is true, this is an add operation, false implies delete\n+ */\n+void\n+ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input,\n+\t\t struct ice_fltr_desc *fdesc, bool add)\n+{\n+\tstruct ice_fd_fltr_desc_ctx fdir_fltr_ctx = { 0 };\n+\n+\t/* set default context info */\n+\tice_set_dflt_val_fd_desc(&fdir_fltr_ctx);\n+\n+\t/* change sideband filtering values */\n+\tfdir_fltr_ctx.fdid = input->fltr_id;\n+\tif (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {\n+\t\tfdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;\n+\t\tfdir_fltr_ctx.qindex = 0;\n+\t} else {\n+\t\tif (input->dest_ctl ==\n+\t\t ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)\n+\t\t\tfdir_fltr_ctx.toq = input->q_region;\n+\t\tfdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;\n+\t\tfdir_fltr_ctx.qindex = input->q_index;\n+\t}\n+\tfdir_fltr_ctx.cnt_ena = input->cnt_ena;\n+\tfdir_fltr_ctx.cnt_index = input->cnt_index;\n+\tfdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);\n+\tfdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;\n+\tfdir_fltr_ctx.toq_prio = 3;\n+\tfdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD :\n+\t\tICE_FXD_FLTR_QW1_PCMD_REMOVE;\n+\tfdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;\n+\tfdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO;\n+\tfdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;\n+\tfdir_fltr_ctx.fdid_prio = input->fdid_prio;\n+\tfdir_fltr_ctx.desc_prof = 1;\n+\tfdir_fltr_ctx.desc_prof_prio = 3;\n+\tice_set_fd_desc_val(&fdir_fltr_ctx, fdesc);\n+}\n+\n+/**\n * ice_alloc_fd_res_cntr - obtain counter resource for FD type\n * @hw: pointer to the hardware structure\n * @cntr_id: returns counter index\ndiff --git a/drivers/net/ice/base/ice_fdir.h b/drivers/net/ice/base/ice_fdir.h\nindex 6f11195f6..21a83fd6c 100644\n--- a/drivers/net/ice/base/ice_fdir.h\n+++ b/drivers/net/ice/base/ice_fdir.h\n@@ -36,9 +36,6 @@ struct ice_fd_fltr_desc_ctx {\n \n enum ice_status ice_alloc_fd_res_cntr(struct ice_hw *hw, u16 *cntr_id);\n enum ice_status ice_free_fd_res_cntr(struct ice_hw *hw, u16 cntr_id);\n-void\n-ice_set_fd_desc_val(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx,\n-\t\t struct ice_fltr_desc *fdir_desc);\n void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx);\n enum ice_status\n ice_alloc_fd_guar_item(struct ice_hw *hw, u16 *cntr_id, u16 num_fltr);\n", "prefixes": [ "14/16" ] }