Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67423/?format=api
{ "id": 67423, "url": "http://patches.dpdk.org/api/patches/67423/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200330114538.43275-3-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200330114538.43275-3-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200330114538.43275-3-qi.z.zhang@intel.com", "date": "2020-03-30T11:45:24", "name": "[02/16] net/ice/base: reduce scope of variables", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0dd282baec3020b3c088ed2b010f062b173a02b0", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200330114538.43275-3-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 9102, "url": "http://patches.dpdk.org/api/series/9102/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9102", "date": "2020-03-30T11:45:22", "name": "ice share code update", "version": 1, "mbox": "http://patches.dpdk.org/series/9102/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67423/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8FDB7A057B;\n\tMon, 30 Mar 2020 13:42:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ADEFA1C05C;\n\tMon, 30 Mar 2020 13:42:16 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 6497A1C02D\n for <dev@dpdk.org>; Mon, 30 Mar 2020 13:42:14 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Mar 2020 04:42:14 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2020 04:42:12 -0700" ], "IronPort-SDR": [ "\n N3By7W2EPiZFX9i5aPOoN0xSEHvwZqqoTzNonNgQQLn3M4IgKE8PVzCYFVF7lSzx/2T0ShT7WJ\n buJUAttA4KKQ==", "\n t/9cn/FB2lWUY/nnswzBqeEkxwDaC6P646M7/oeU1snkXgsBCE5LQ9XV/onKN1bYW80p35Y6z3\n mmzLoTAz+pCg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,324,1580803200\"; d=\"scan'208\";a=\"449769839\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 30 Mar 2020 19:45:24 +0800", "Message-Id": "<20200330114538.43275-3-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200330114538.43275-1-qi.z.zhang@intel.com>", "References": "<20200330114538.43275-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 02/16] net/ice/base: reduce scope of variables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The scope of these variables can be reduced, so do so. This also eliminates\nthe need for the extra wrapping/braces.\n\nAlso, compact a line since it can fit within 80 columns\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 5 +----\n drivers/net/ice/base/ice_fdir.c | 3 +--\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 0cf578c34..1acac8640 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -1840,9 +1840,6 @@ ice_parse_caps(struct ice_hw *hw, void *buf, u32 cap_count,\n \t\t\t\t caps->msix_vector_first_id);\n \t\t\tbreak;\n \t\tcase ICE_AQC_CAPS_FD:\n-\t\t{\n-\t\t\tu32 reg_val, val;\n-\n \t\t\tif (dev_p) {\n \t\t\t\tdev_p->num_flow_director_fltr = number;\n \t\t\t\tice_debug(hw, ICE_DBG_INIT,\n@@ -1851,6 +1848,7 @@ ice_parse_caps(struct ice_hw *hw, void *buf, u32 cap_count,\n \t\t\t\t\t dev_p->num_flow_director_fltr);\n \t\t\t}\n \t\t\tif (func_p) {\n+\t\t\t\tu32 reg_val, val;\n \t\t\t\tif (hw->dcf_enabled)\n \t\t\t\t\tbreak;\n \t\t\t\treg_val = rd32(hw, GLQF_FD_SIZE);\n@@ -1869,7 +1867,6 @@ ice_parse_caps(struct ice_hw *hw, void *buf, u32 cap_count,\n \t\t\t\t\t prefix, func_p->fd_fltr_best_effort);\n \t\t\t}\n \t\t\tbreak;\n-\t\t}\n \t\tcase ICE_AQC_CAPS_MAX_MTU:\n \t\t\tcaps->max_mtu = number;\n \t\t\tice_debug(hw, ICE_DBG_INIT, \"%s: max_mtu = %d\\n\",\ndiff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c\nindex 6dc8d54da..df754dc74 100644\n--- a/drivers/net/ice/base/ice_fdir.c\n+++ b/drivers/net/ice/base/ice_fdir.c\n@@ -581,8 +581,7 @@ ice_free_fd_shrd_item(struct ice_hw *hw, u16 cntr_id, u16 num_fltr)\n */\n int ice_get_fdir_cnt_all(struct ice_hw *hw)\n {\n-\treturn hw->func_caps.fd_fltr_guar +\n-\t hw->func_caps.fd_fltr_best_effort;\n+\treturn hw->func_caps.fd_fltr_guar + hw->func_caps.fd_fltr_best_effort;\n }\n \n /**\n", "prefixes": [ "02/16" ] }