Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67317/?format=api
{ "id": 67317, "url": "http://patches.dpdk.org/api/patches/67317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200329144308.5103-4-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200329144308.5103-4-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200329144308.5103-4-i.dyukov@samsung.com", "date": "2020-03-29T14:42:49", "name": "[v7,3/5] net/virtio-user: fix devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "547416f2a9fff7fbae63bbed51480344fdc4c1a3", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200329144308.5103-4-i.dyukov@samsung.com/mbox/", "series": [ { "id": 9083, "url": "http://patches.dpdk.org/api/series/9083/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9083", "date": "2020-03-29T14:42:46", "name": "net/virtio: add link speed devarg", "version": 7, "mbox": "http://patches.dpdk.org/series/9083/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67317/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67317/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86841A0562;\n\tSun, 29 Mar 2020 16:44:16 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EFB2D1C036;\n\tSun, 29 Mar 2020 16:43:40 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 42B851BFD7\n for <dev@dpdk.org>; Sun, 29 Mar 2020 16:43:38 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200329144337euoutp02957a9e9db51bd75145ada031d0b0db5b~AzX-SMQ0k0963909639euoutp029\n for <dev@dpdk.org>; Sun, 29 Mar 2020 14:43:37 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200329144337eucas1p2a93632e03a276d9a31db92e169de8d9c~AzX_8wZk20561705617eucas1p2f;\n Sun, 29 Mar 2020 14:43:37 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id E1.A3.60679.914B08E5; Sun, 29\n Mar 2020 15:43:37 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200329144337eucas1p2cc22be55d036822bf52dc69149d538af~AzX_u7-UK0846808468eucas1p2U;\n Sun, 29 Mar 2020 14:43:37 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200329144337eusmtrp28db350455c312456a18a3e56141fa6b1~AzX_uZiyp1656816568eusmtrp2U;\n Sun, 29 Mar 2020 14:43:37 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 41.F7.07950.914B08E5; Sun, 29\n Mar 2020 15:43:37 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200329144336eusmtip19f614961d7c2a094160dcdd87d41bef0~AzX_MVFB60056600566eusmtip1Q;\n Sun, 29 Mar 2020 14:43:36 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200329144337euoutp02957a9e9db51bd75145ada031d0b0db5b~AzX-SMQ0k0963909639euoutp029", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1585493017;\n bh=5tV+PUkbyK8uGKqGJo6atUhkYthNNopDlr81QODeU7I=;\n h=From:To:Subject:Date:In-Reply-To:References:From;\n b=V21XxP5VBu/f8jfL6vhcvJP7+io0FtYPjnZ0UctTItLTf4Miltyw7YtpMbXjCk6fj\n gwgQ8Mnvbep3X5xFYFHOD/G7U/7jK9FxGLuaoJFqrOFKwJaZV9CxbbPKrqR0oYJjlv\n iVC2rzo33qnPmSGldbhSCL6X752wMo0PrnMPCL/o=", "X-AuditID": "cbfec7f4-0cbff7000001ed07-72-5e80b4197a72", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, i.dyukov@samsung.com,\n tiwei.bie@intel.com, amorenoz@redhat.com, zhihong.wang@intel.com,\n xiaolong.ye@intel.com", "Date": "Sun, 29 Mar 2020 17:42:49 +0300", "Message-Id": "<20200329144308.5103-4-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200329144308.5103-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsWy7djPc7qSWxriDI6+ELJo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLFJdN\n SmpOZllqkb5dAlfGjKuXmQuecVTMunCfuYFxJnsXIyeHhICJxJHVF5m6GLk4hARWMEocmr+Y\n DSQhJPCFUWLJ5DoI+zOjxKdZnDANG+/eY4RoWM4ocXvzRDYI5yujxM2DX1hBqtgENCROd8wD\n GysiMJ9R4mTPZ2aQhLCAjcSabyuB2jk4WARUJQ5dlgAJ8wpYSPxd/44FYoO8xOoNB8DKOQUs\n JSa8vwu2TULgPpvEu2v/oe52kehr2wHVICzx6vgWqLiMxP+d85kg7GqJPV1v2SGaOxglvjZs\n ZYRI2EtseX2OHeQIZgFNifW79CHCjhK7nraxgYQlBPgkbrwVBAkzA5mTtk1nhgjzSnS0CUFU\n K0kcOHkJKiwh8fc3D0TYQ+LC/P+skCDZzShx9/Ir1gmMcrMQdi1gZFzFKJ5aWpybnlpslJda\n rlecmFtcmpeul5yfu4kRGP+n/x3/soNx15+kQ4wCHIxKPLwGlfVxQqyJZcWVuYcYJTiYlUR4\n 2fwb4oR4UxIrq1KL8uOLSnNSiw8xSnOwKInzGi96GSskkJ5YkpqdmlqQWgSTZeLglGpgNOyo\n f2zIZKQqzbG8dOGMa+p7HvddalO4vNci6tjqd1uDnq3ukVA3r/oYvsZF4tJisy17103+v2IG\n 4xULUz3b5u3lEybwOD25LCPyv0jY73zj/pSyE3dW+P57Ffunkycj4A/HnPaSgOtHSj+YNE3P\n ujNh0VmDa7EVkSpV0YFfZ2S3Vle1pb1arcRSnJFoqMVcVJwIALp9NBP7AgAA", "\n H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xu7qSWxriDF7PY7Fo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLlJ5N\n UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7GjKuXmQue\n cVTMunCfuYFxJnsXIyeHhICJxMa79xi7GLk4hASWMkrcfdrN2sXIAZSQkHj9hBmiRljiz7Uu\n Noiaz4wSk26+ZwVJsAloSJzumMcEkhARWM4o0X+5lQ0kISxgI7Hm20pGkEEsAqoShy5LgIR5\n BSwk/q5/xwIxVF5i9YYDYAs4BSwlJry/ywhiCwmkSxzcdYJpAiPvAkaGVYwiqaXFuem5xUZ6\n xYm5xaV56XrJ+bmbGIEBue3Yzy07GLveBR9iFOBgVOLhNaisjxNiTSwrrsw9xCjBwawkwsvm\n 3xAnxJuSWFmVWpQfX1Sak1p8iNEU6KaJzFKiyfnAaMkriTc0NTS3sDQ0NzY3NrNQEuftEDgY\n A3RGYklqdmpqQWoRTB8TB6dUA+OSfuOvmQqhd458EK7p/79p/numqA0ns0xLGgUPiR1cHNKl\n 6nVsp0ja6+iifmfPfYdD4ves1FssM705cnpK5Fff09ubHWe/kjIWuWou+q3UYVN+fFlMz3S7\n P6FmIhPF42OlvPS5C/+z3PCreOtxq2Fe55F+uw3u9VIL7mhz5TVWbprOKnthuxJLcUaioRZz\n UXEiAOAKfepeAgAA" ], "X-CMS-MailID": "20200329144337eucas1p2cc22be55d036822bf52dc69149d538af", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200329144337eucas1p2cc22be55d036822bf52dc69149d538af", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200329144337eucas1p2cc22be55d036822bf52dc69149d538af", "References": "<20191212085012.9170-1-i.dyukov@samsung.com>\n <20200329144308.5103-1-i.dyukov@samsung.com>\n <CGME20200329144337eucas1p2cc22be55d036822bf52dc69149d538af@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v7 3/5] net/virtio-user: fix devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "strtoull returns 0 if it fails to parse input string. It's ignored\nin get_integer_arg.\n\nThis patch handles error cases for strtoull function.\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_user_ethdev.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex e61af4068..a79f68a36 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -477,12 +477,17 @@ static int\n get_integer_arg(const char *key __rte_unused,\n \t\tconst char *value, void *extra_args)\n {\n+\tuint64_t integer = 0;\n \tif (!value || !extra_args)\n \t\treturn -EINVAL;\n-\n-\t*(uint64_t *)extra_args = strtoull(value, NULL, 0);\n-\n-\treturn 0;\n+\terrno = 0;\n+\tinteger = strtoull(value, NULL, 0);\n+\t/* extra_args keeps default value, it should be replaced\n+\t * only in case of successful parsing of the 'value' arg\n+\t */\n+\tif (errno == 0)\n+\t\t*(uint64_t *)extra_args = integer;\n+\treturn -errno;\n }\n \n static struct rte_eth_dev *\n", "prefixes": [ "v7", "3/5" ] }