Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67315/?format=api
{ "id": 67315, "url": "http://patches.dpdk.org/api/patches/67315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200329144308.5103-2-i.dyukov@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200329144308.5103-2-i.dyukov@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200329144308.5103-2-i.dyukov@samsung.com", "date": "2020-03-29T14:42:47", "name": "[v7,1/5] net/virtio: refactor devargs parsing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b223a7a74cf86c981646bb2e7725ac9500b54586", "submitter": { "id": 783, "url": "http://patches.dpdk.org/api/people/783/?format=api", "name": "Ivan Dyukov", "email": "i.dyukov@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200329144308.5103-2-i.dyukov@samsung.com/mbox/", "series": [ { "id": 9083, "url": "http://patches.dpdk.org/api/series/9083/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9083", "date": "2020-03-29T14:42:46", "name": "net/virtio: add link speed devarg", "version": 7, "mbox": "http://patches.dpdk.org/series/9083/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67315/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/67315/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5533DA0562;\n\tSun, 29 Mar 2020 16:43:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 846FC1B949;\n\tSun, 29 Mar 2020 16:43:37 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 818A51BF9D\n for <dev@dpdk.org>; Sun, 29 Mar 2020 16:43:35 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200329144334euoutp017e3d2c67804fd90ad7833b0bceef9919~AzX8eYudk0271602716euoutp01Z\n for <dev@dpdk.org>; Sun, 29 Mar 2020 14:43:34 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200329144334eucas1p12d50fe8a686a82bfb9549fd17dda5fdd~AzX74CTc41538815388eucas1p1s;\n Sun, 29 Mar 2020 14:43:34 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id 80.A3.60679.514B08E5; Sun, 29\n Mar 2020 15:43:33 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200329144333eucas1p2aa754e8de8f2ba01da656821c76eae9f~AzX7jhgxK0989809898eucas1p2m;\n Sun, 29 Mar 2020 14:43:33 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200329144333eusmtrp2ff7192be3230d62faa3b96aedde5fa67~AzX7i8FWW1656816568eusmtrp2T;\n Sun, 29 Mar 2020 14:43:33 +0000 (GMT)", "from eusmtip1.samsung.com ( [203.254.199.221]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id C0.F7.07950.514B08E5; Sun, 29\n Mar 2020 15:43:33 +0100 (BST)", "from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by\n eusmtip1.samsung.com (KnoxPortal) with ESMTPA id\n 20200329144333eusmtip1ef117e8b2db6a3c0e2bd7418969aa684~AzX6-D6j10185501855eusmtip1Q;\n Sun, 29 Mar 2020 14:43:33 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n 20200329144334euoutp017e3d2c67804fd90ad7833b0bceef9919~AzX8eYudk0271602716euoutp01Z", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1585493014;\n bh=mHhQ03gcfc8lc4HgXNspAnL6+ptFrufucmW+PD+kjK4=;\n h=From:To:Subject:Date:In-Reply-To:References:From;\n b=WQwmm+Klfh4EyJs+YD9V1UWa39f9kcEz9n1rPqQBmEtoTQlVPBx3ST2QqceMZ4PX0\n /DykAWiEgpPIgPbVR9mo9lr6NrYTw3sEwkGtSal+ly/k8ABZ6y0BMpC4E/cAZvMv5D\n /2nkAMS7tFDCO/zt1iaVZtZxQrh1DyFmnbk2fSd8=", "X-AuditID": "cbfec7f4-0cbff7000001ed07-6a-5e80b415d2e7", "From": "Ivan Dyukov <i.dyukov@samsung.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, i.dyukov@samsung.com,\n tiwei.bie@intel.com, amorenoz@redhat.com, zhihong.wang@intel.com,\n xiaolong.ye@intel.com", "Date": "Sun, 29 Mar 2020 17:42:47 +0300", "Message-Id": "<20200329144308.5103-2-i.dyukov@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200329144308.5103-1-i.dyukov@samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsWy7djP87qiWxriDLpfWFi07njAYvHu03Ym\n i1mXmtgtjnXuYbHY2vCfyeLPG1OLzRcnMTmwe/xasJTVY/Gel0we7/ddZfPo27KKMYAlissm\n JTUnsyy1SN8ugSvjzYHfjAXLBSta1/xka2Bs5Oti5OSQEDCR2HvpB2MXIxeHkMAKRokvxw8z\n QzhfGCWa/z1jgnA+M0rsONvACtOy6dVOFojEckaJ33+mQfV/ZZQ4NXkHI0gVm4CGxOmOeWDt\n IgLzGSVO9nxmBkkIC9hIfD0wE2wUi4CqxMIvD1hAbF4BC4kXDy8yQ6yQl1i94QCYzSlgKTHh\n /V2wDRICt9kknve8YoEocpGYtv8DO4QtLPHq+BYoW0bi/875TBB2tcSerrfsEM0djBJfG7Yy\n QiTsJba8PgeU4OBgFtCUWL9LHyLsKPHrbC8bSFhCgE/ixltBkDAzkDlp23RmiDCvREebEES1\n ksSBk5egwhISf3/zQJgeEisfqkGCZDejxPlbn5gnMMrNQli1gJFxFaN4amlxbnpqsVFearle\n cWJucWleul5yfu4mRmAKOP3v+JcdjLv+JB1iFOBgVOLhNaisjxNiTSwrrsw9xCjBwawkwsvm\n 3xAnxJuSWFmVWpQfX1Sak1p8iFGag0VJnNd40ctYIYH0xJLU7NTUgtQimCwTB6dUA+OS17vP\n m4Up/Pue94NHp2bdf74rDcI7Os3yCspfOYpf+9LAx/ThUXFp3DaOwyXbt3xfnSE8TfBxgs8x\n qaQcmw9yU7r6tXdacEQdcTpx93zQPcW4Y8pr7hRXPo6JvxQ/jcHSdP7KJA1feWWFe2LlW48o\n lV97v7ggtNb0Yc90My23+0v/aX7vkFViKc5INNRiLipOBAAatDqx/QIAAA==", "\n H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xu7qiWxriDC59VrZo3fGAxeLdp+1M\n FrMuNbFbHOvcw2KxteE/k8WfN6YWmy9OYnJg9/i1YCmrx+I9L5k83u+7yubRt2UVYwBLlJ5N\n UX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl7GmwO/GQuW\n C1a0rvnJ1sDYyNfFyMkhIWAisenVThYQW0hgKaPEvy71LkYOoLiExOsnzBAlwhJ/rnWxdTFy\n AZV8ZpS4/Pg0O0iCTUBD4nTHPCaQhIjAckaJ/sutbCAJYQEbia8HZrKC2CwCqhILvzwAW8Ar\n YCHx4uFFqKnyEqs3HACzOQUsJSa8v8sIcUS6xMFdJ5gmMPIuYGRYxSiSWlqcm55bbKRXnJhb\n XJqXrpecn7uJERiQ24793LKDsetd8CFGAQ5GJR5eg8r6OCHWxLLiytxDjBIczEoivGz+DXFC\n vCmJlVWpRfnxRaU5qcWHGE2BjprILCWanA+MlrySeENTQ3MLS0NzY3NjMwslcd4OgYMxQGck\n lqRmp6YWpBbB9DFxcEo1MBZEpoXJPL/93MaW6cz8G6/Pci9dNF/VP2J1C5tob8w6g286DrFV\n k8ruFvao5U2Mn3rkXPq39Mpk+ZflxtwLt28XzU33u+dqu3b/Ov9AxqWpF/ecP3HoZ0L1+3dF\n XGUhD0p7eSycuX4LXp/vu+7WcVsvSxm/tTZfcsWPrT1vYnxHNumNi9NLPyWW4oxEQy3mouJE\n AF70tcxeAgAA" ], "X-CMS-MailID": "20200329144333eucas1p2aa754e8de8f2ba01da656821c76eae9f", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200329144333eucas1p2aa754e8de8f2ba01da656821c76eae9f", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200329144333eucas1p2aa754e8de8f2ba01da656821c76eae9f", "References": "<20191212085012.9170-1-i.dyukov@samsung.com>\n <20200329144308.5103-1-i.dyukov@samsung.com>\n <CGME20200329144333eucas1p2aa754e8de8f2ba01da656821c76eae9f@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH v7 1/5] net/virtio: refactor devargs parsing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "refactor vdpa specific devargs parsing to more generic way\n\nSigned-off-by: Ivan Dyukov <i.dyukov@samsung.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 34 +++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex f9d0ea70d..870ff7801 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1957,16 +1957,18 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev)\n }\n \n static int vdpa_check_handler(__rte_unused const char *key,\n-\t\tconst char *value, __rte_unused void *opaque)\n+\t\tconst char *value, void *ret_val)\n {\n-\tif (strcmp(value, \"1\"))\n-\t\treturn -1;\n+\tif (strcmp(value, \"1\") == 0)\n+\t\t*(int *)ret_val = 1;\n+\telse\n+\t\t*(int *)ret_val = 0;\n \n \treturn 0;\n }\n \n static int\n-vdpa_mode_selected(struct rte_devargs *devargs)\n+virtio_dev_devargs_parse(struct rte_devargs *devargs, int *vdpa)\n {\n \tstruct rte_kvargs *kvlist;\n \tconst char *key = \"vdpa\";\n@@ -1982,12 +1984,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n \tif (!rte_kvargs_count(kvlist, key))\n \t\tgoto exit;\n \n-\t/* vdpa mode selected when there's a key-value pair: vdpa=1 */\n-\tif (rte_kvargs_process(kvlist, key,\n-\t\t\t\tvdpa_check_handler, NULL) < 0) {\n-\t\tgoto exit;\n+\tif (vdpa) {\n+\t\t/* vdpa mode selected when there's a key-value pair:\n+\t\t * vdpa=1\n+\t\t */\n+\t\tret = rte_kvargs_process(kvlist, key,\n+\t\t\t\tvdpa_check_handler, vdpa);\n+\t\tif (ret < 0)\n+\t\t\tgoto exit;\n \t}\n-\tret = 1;\n+\n \n exit:\n \trte_kvargs_free(kvlist);\n@@ -1997,8 +2003,16 @@ vdpa_mode_selected(struct rte_devargs *devargs)\n static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct rte_pci_device *pci_dev)\n {\n+\tint vdpa = 0;\n+\tint ret = 0;\n+\n+\tret = virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa);\n+\tif (ret < 0) {\n+\t\tPMD_INIT_LOG(ERR, \"devargs parsing is failed\");\n+\t\treturn ret;\n+\t}\n \t/* virtio pmd skips probe if device needs to work in vdpa mode */\n-\tif (vdpa_mode_selected(pci_dev->device.devargs))\n+\tif (vdpa == 1)\n \t\treturn 1;\n \n \treturn rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct virtio_hw),\n", "prefixes": [ "v7", "1/5" ] }