Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67293/?format=api
{ "id": 67293, "url": "http://patches.dpdk.org/api/patches/67293/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-20-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200327101823.12646-20-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200327101823.12646-20-mk@semihalf.com", "date": "2020-03-27T10:18:13", "name": "[19/29] net/ena: add Tx drops statistic", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fd09211b408de004fbc34e1da31758ca174f2c2e", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-20-mk@semihalf.com/mbox/", "series": [ { "id": 9077, "url": "http://patches.dpdk.org/api/series/9077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9077", "date": "2020-03-27T10:17:54", "name": "Update ENA driver to v2.1.0", "version": 1, "mbox": "http://patches.dpdk.org/series/9077/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67293/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/67293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 32A9CA0589;\n\tFri, 27 Mar 2020 11:32:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EAAA11C1A4;\n\tFri, 27 Mar 2020 11:29:45 +0100 (CET)", "from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id E15B51C0CB\n for <dev@dpdk.org>; Fri, 27 Mar 2020 11:29:35 +0100 (CET)", "by mail-lj1-f193.google.com with SMTP id i20so9633476ljn.6\n for <dev@dpdk.org>; Fri, 27 Mar 2020 03:29:35 -0700 (PDT)", "from localhost.localdomain (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id i11sm2789587lfo.84.2020.03.27.03.29.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2020 03:29:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=CUokLl9P44Co5oTDPqz/JzoBAxLSE1S9K05SI5KDHm4=;\n b=MDn1Bgidg7ctRPEcYXoIcGnt/1RW+I/PBSqDFa3HBQWuyhEouQqWaDjArGKXDzpTUo\n jI/c5/+tln/5JxdSlTjU9VNFWFKCcfbEU4Fw9s4v3LkhPgbJ5ifEjrzE3e5Z/fKgaDfF\n s7JHZaNSbTfat9o5noqcSPPXh6w5y1aaHHoiYaTtf/GLGAoMNiaatv0ZoAiqYGXZl7qV\n myF3yh/WZcKB1bUkWAsdPHzVN3091TzenOuS6/SUiqyl0MU2WTc55pSQLzbPv9FtOatI\n k9f+kRrI6qrgdeIUWA9CxPgu/gF3H9pzMY1zwFmLBmlzJcg5BOZh/M5jPcuOEnSaVaLF\n juIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=CUokLl9P44Co5oTDPqz/JzoBAxLSE1S9K05SI5KDHm4=;\n b=LPVTiYptL6q4W9t+sZyWxd3kfr2trpmlOe7mBBvg5lQG/33fOdHPUjY7Y8Mgq3iGX+\n OySvDyVXunJ8w9hKLgjCaU40axtKtKPzrW8m1axOtvpFngFuyZd9KVRtv7sHwwQArhN/\n TTvLeaBbMT/UoXEJ7uKb7kBB56fUJ4f8upatoHekaoDnVwPpQocqX1kdNcEPPb0cUoNC\n h1tQDg0G+24agC8ir0+xxwgSE7nRl19DZKLvaTg83rr+i5972DxRx7jEHG2Hy8Q87PsR\n aeCR2DMy6qP3W9WSN89atbfkG6+gl404cFEktqioRTFvckLNdWk68VUUxxynz04MMkDC\n MdFA==", "X-Gm-Message-State": "AGi0PuZ9HkT2+cRvWoIwJqQK2D/G6uPZmLdLkQBaDHGpMMBIf8+O4R4j\n 7Zak/plBRHjOk2cDBeiDiofk3eGjq9r3+g==", "X-Google-Smtp-Source": "\n APiQypI/LF3ABc2ZSnAobQFi2R2Yrrn8QEFZ1r7KufXoYKmffliMP0hzcJixrj9awz+DNDwu2OwMQA==", "X-Received": "by 2002:a2e:9710:: with SMTP id r16mr4792315lji.109.1585304975232;\n Fri, 27 Mar 2020 03:29:35 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Fri, 27 Mar 2020 11:18:13 +0100", "Message-Id": "<20200327101823.12646-20-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200327101823.12646-1-mk@semihalf.com>", "References": "<20200327101823.12646-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 19/29] net/ena: add Tx drops statistic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ENA device can report in the AENQ handler amount of Tx packets that were\ndropped and not sent.\n\nThis statistic is showing global value for the device and because\nrte_eth_stats is missing field that could indicate this value (it\nisn't the Tx error), it is being presented as a extended statistic.\n\nAs the current design of extended statistics prevents tx_drops from\nbeing an atomic variable and both tx_drops and rx_drops are only updated\nfrom the AENQ handler, both were set as non-atomic for the alignment.\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 11 ++++++++---\n drivers/net/ena/ena_ethdev.h | 8 +++++++-\n 2 files changed, 15 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 19a43400d5..52eac0f1b9 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -92,6 +92,7 @@ static const struct ena_stats ena_stats_global_strings[] = {\n \tENA_STAT_GLOBAL_ENTRY(wd_expired),\n \tENA_STAT_GLOBAL_ENTRY(dev_start),\n \tENA_STAT_GLOBAL_ENTRY(dev_stop),\n+\tENA_STAT_GLOBAL_ENTRY(tx_drops),\n };\n \n static const struct ena_stats ena_stats_tx_strings[] = {\n@@ -925,7 +926,7 @@ static void ena_stats_restart(struct rte_eth_dev *dev)\n \trte_atomic64_init(&adapter->drv_stats->ierrors);\n \trte_atomic64_init(&adapter->drv_stats->oerrors);\n \trte_atomic64_init(&adapter->drv_stats->rx_nombuf);\n-\trte_atomic64_init(&adapter->drv_stats->rx_drops);\n+\tadapter->drv_stats->rx_drops = 0;\n }\n \n static int ena_stats_get(struct rte_eth_dev *dev,\n@@ -959,7 +960,7 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t\t\t\tena_stats.tx_bytes_low);\n \n \t/* Driver related stats */\n-\tstats->imissed = rte_atomic64_read(&adapter->drv_stats->rx_drops);\n+\tstats->imissed = adapter->drv_stats->rx_drops;\n \tstats->ierrors = rte_atomic64_read(&adapter->drv_stats->ierrors);\n \tstats->oerrors = rte_atomic64_read(&adapter->drv_stats->oerrors);\n \tstats->rx_nombuf = rte_atomic64_read(&adapter->drv_stats->rx_nombuf);\n@@ -2715,12 +2716,16 @@ static void ena_keep_alive(void *adapter_data,\n \tstruct ena_adapter *adapter = adapter_data;\n \tstruct ena_admin_aenq_keep_alive_desc *desc;\n \tuint64_t rx_drops;\n+\tuint64_t tx_drops;\n \n \tadapter->timestamp_wd = rte_get_timer_cycles();\n \n \tdesc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e;\n \trx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low;\n-\trte_atomic64_set(&adapter->drv_stats->rx_drops, rx_drops);\n+\ttx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low;\n+\n+\tadapter->drv_stats->rx_drops = rx_drops;\n+\tadapter->dev_stats.tx_drops = tx_drops;\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 99d1fba64d..a7f87eddc3 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -134,13 +134,19 @@ struct ena_driver_stats {\n \trte_atomic64_t ierrors;\n \trte_atomic64_t oerrors;\n \trte_atomic64_t rx_nombuf;\n-\trte_atomic64_t rx_drops;\n+\tu64 rx_drops;\n };\n \n struct ena_stats_dev {\n \tu64 wd_expired;\n \tu64 dev_start;\n \tu64 dev_stop;\n+\t/*\n+\t * Tx drops cannot be reported as the driver statistic, because DPDK\n+\t * rte_eth_stats structure isn't providing appropriate field for that.\n+\t * As a workaround it is being published as an extended statistic.\n+\t */\n+\tu64 tx_drops;\n };\n \n struct ena_offloads {\n", "prefixes": [ "19/29" ] }