Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/67275/?format=api
{ "id": 67275, "url": "http://patches.dpdk.org/api/patches/67275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-2-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200327101823.12646-2-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200327101823.12646-2-mk@semihalf.com", "date": "2020-03-27T10:17:55", "name": "[01/29] net/ena: check if size of buffer is at least 1400B", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5cb98a8b8f3140d7a5994b9a91a5e978e0038a3c", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200327101823.12646-2-mk@semihalf.com/mbox/", "series": [ { "id": 9077, "url": "http://patches.dpdk.org/api/series/9077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=9077", "date": "2020-03-27T10:17:54", "name": "Update ENA driver to v2.1.0", "version": 1, "mbox": "http://patches.dpdk.org/series/9077/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/67275/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/67275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0910A0589;\n\tFri, 27 Mar 2020 11:29:20 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 67FFC1C08E;\n\tFri, 27 Mar 2020 11:29:13 +0100 (CET)", "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id D8FB81C029\n for <dev@dpdk.org>; Fri, 27 Mar 2020 11:29:11 +0100 (CET)", "by mail-lj1-f195.google.com with SMTP id w1so9615839ljh.5\n for <dev@dpdk.org>; Fri, 27 Mar 2020 03:29:11 -0700 (PDT)", "from localhost.localdomain (193-106-246-138.noc.fibertech.net.pl.\n [193.106.246.138])\n by smtp.gmail.com with ESMTPSA id i11sm2789587lfo.84.2020.03.27.03.29.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 27 Mar 2020 03:29:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=uKwrko1vKJTbWihDMGGAXsh6+ATWl/XADKanZvKUjoY=;\n b=Az9BnLQUet8ZP8LJxUpIJVMQ9eaUMtsSQsYFqhtBQlvrAVSg5ykGbC8K7vzccz2lJj\n vKAvIlSLCB7h5FBSAdsA8v/Xg3i3pOn6+tWceRL1bpTwK/UQSddPTA+meLMuECtTVhO8\n t9eGmY8n86zFmbePFQcfNbN1KrnfIcbOrJtvyNrYhvikxX9hlBLf4oOrAJpqpCGIgo7Z\n Q8a2u5nRtm/obGWd8OtKAFFqqs4jtMSvxTmjZWfYGndpkCI1WPX0NvnNowWVM2cujKvu\n mjZWu5/AkS8kFEa+pozWF6IKqTJ6ea/4UZdOs7+zg2fdX4LrFwuZa2Ai0tq6s0/qdxpT\n P1rg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=uKwrko1vKJTbWihDMGGAXsh6+ATWl/XADKanZvKUjoY=;\n b=dUzD6SYF6b6lRJ663G8N+FdTCAku9HKZAv11HbRA8G4QSaZmJ2nIzNRGWkMFPjpr+f\n ORpl2fBeQfNRRw/xziSI+Kog5/bSaduJExCyuZVZ9tlTZMxlJ5DbM29jTVdHsf9oT1tQ\n 0fdjjvX51psvSOmxcDblhEuBE7LzBzFzFbWkP6VUjanKPmU/5wzW8IbrRVwxICqlqAQM\n cEf+DwzYmIGscaqQXMC5Yc318tyFdZAqAwzfR1l2SIde7qhVNdAGO6KU9Jj6vzEbZSoj\n uLog7bs9fcs2pb1GuhNgdjFGbKjGFFClu+awOSBp1+hQXgcTY5vTkhOgG9F5yFlT/nzS\n 2hAQ==", "X-Gm-Message-State": "AGi0PuZTEwlUVeOCJRimtPWFObEQGGf/TR+IsOWpboUdXi17gwPzr+zB\n 7IJHx94lMCbmiEPL7YeFa1qKgJAkEuM=", "X-Google-Smtp-Source": "\n APiQypKU/l3hvf2bJGIvuh1RY0fCMnP9gj8K2Vz5gtyLH03SQMoASqPpgAYptu+H2/FotT2aIV98Kw==", "X-Received": "by 2002:a2e:9710:: with SMTP id r16mr4791340lji.109.1585304951113;\n Fri, 27 Mar 2020 03:29:11 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "mw@semihalf.com, mba@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com,\n igorch@amazon.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Fri, 27 Mar 2020 11:17:55 +0100", "Message-Id": "<20200327101823.12646-2-mk@semihalf.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200327101823.12646-1-mk@semihalf.com>", "References": "<20200327101823.12646-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at\n\tleast 1400B", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some of the ENA devices can't handle buffers which are smaller than a\n1400B. Because of this limitation, size of the buffer is being checked\nand limited during the Rx queue setup.\n\nIf it's below the allowed value, PMD won't finish it's configuration\nsuccessfully..\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 12 ++++++++++++\n drivers/net/ena/ena_ethdev.h | 1 +\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 665afee4f0..a8f8784a9f 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1282,6 +1282,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n {\n \tstruct ena_adapter *adapter = dev->data->dev_private;\n \tstruct ena_ring *rxq = NULL;\n+\tsize_t buffer_size;\n \tint i;\n \n \trxq = &adapter->rx_ring[queue_idx];\n@@ -1309,6 +1310,17 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n+\t/* ENA isn't supporting buffers smaller than 1400 bytes */\n+\tbuffer_size = mp->elt_size - sizeof(struct rte_mbuf) -\n+\t\tRTE_PKTMBUF_HEADROOM;\n+\tif (buffer_size < ENA_RX_BUF_MIN_SIZE) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Unsupported size of RX buffer: %zu (min size: %d)\\n\",\n+\t\t\tbuffer_size, ENA_RX_BUF_MIN_SIZE);\n+\t\treturn -EINVAL;\n+\t}\n+\tprintf(\"mempool size: %ld\\n\", buffer_size);\n+\n \trxq->port_id = dev->data->port_id;\n \trxq->next_to_clean = 0;\n \trxq->next_to_use = 0;\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex af5eeea280..c1457defeb 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -20,6 +20,7 @@\n #define ENA_MIN_FRAME_LEN\t64\n #define ENA_NAME_MAX_LEN\t20\n #define ENA_PKT_MAX_BUFS\t17\n+#define ENA_RX_BUF_MIN_SIZE\t1400\n \n #define ENA_MIN_MTU\t\t128\n \n", "prefixes": [ "01/29" ] }