Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66970/?format=api
{ "id": 66970, "url": "http://patches.dpdk.org/api/patches/66970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200320064600.1240-1-muhammad.ahmad@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200320064600.1240-1-muhammad.ahmad@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200320064600.1240-1-muhammad.ahmad@emumba.com", "date": "2020-03-20T06:46:00", "name": "[v4] app/testpmd: add fw version in port info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9e239defb72ae3dac6cdcc45beac2f0d62764444", "submitter": { "id": 1602, "url": "http://patches.dpdk.org/api/people/1602/?format=api", "name": "Muhammad Ahmad", "email": "muhammad.ahmad@emumba.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200320064600.1240-1-muhammad.ahmad@emumba.com/mbox/", "series": [ { "id": 8993, "url": "http://patches.dpdk.org/api/series/8993/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8993", "date": "2020-03-20T06:46:00", "name": "[v4] app/testpmd: add fw version in port info", "version": 4, "mbox": "http://patches.dpdk.org/series/8993/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66970/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA3EDA0583;\n\tFri, 20 Mar 2020 07:47:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A57412BB9;\n\tFri, 20 Mar 2020 07:47:46 +0100 (CET)", "from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 2EC86F90\n for <dev@dpdk.org>; Fri, 20 Mar 2020 07:47:45 +0100 (CET)", "by mail-lj1-f196.google.com with SMTP id g12so5254268ljj.3\n for <dev@dpdk.org>; Thu, 19 Mar 2020 23:47:45 -0700 (PDT)", "from localhost.localdomain ([182.191.83.208])\n by smtp.gmail.com with ESMTPSA id r18sm2920112lji.16.2020.03.19.23.47.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Mar 2020 23:47:44 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=NccwooGfaR8wLsV/oT0JQiX1uw+ggabfdtbap70Q57s=;\n b=ckwxG5+Tbmwl5f6UKo9g8U9YTyluEymVvQUmh0KIjYE/zehaG5pNU+cGaYH72eN+ar\n GCUSWitv4ptDU3H96YYSWjz7kyB+KSiHv9xeEsIweOlio79v7D0lSW//itHGQxloDIzG\n gwdHOxNyGXPkeHMHdJQsW3m4awAks4uuPsKlK7DmPDibwx+SlwCxQ3wGN0CAaJppBZhQ\n q+O/7AWCxJynbICLEpiPc0j3rG75tBzMWx2NaPg8kOCMFROQ4VgSW3XjDbfEa0ui5D5k\n D0YN+Fb3eUjZWGHLwmtCcWRxiKHHRYolcN7ENsC5qnKdn18uXXQZB1PnSxGa7B/TwomJ\n qXRg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=NccwooGfaR8wLsV/oT0JQiX1uw+ggabfdtbap70Q57s=;\n b=tENg+IfCRyMSIf0zQffRZ7mJU1/BK9f+XjMSAp4vbGtCao2dGQ6S9J16/xz9nXU3Ef\n neZImJLbEw6jAkdXcGfyGDojkxQsmTwz54l9pA5T+b105Dhws3rUfeOEoRGVo6LRxP8J\n 6WG3Kea5ELnpao6ze8FK4YvQrS0Z9kzT1T/l5sUQ3c8g0U9AmSdXIH00gG1Mk916xYCY\n Itet3AVkub95Rtk9CEs4Ru/G/9QDjFMk5QL/ckMPlYrC/LZcfiz1ptUVlqWsI1jFm2nu\n NuA7kHobQ7Y9hSJy0crbdePdnEp1BpzOAyKK/Eoq2Xy8l00DQ2WmPMcRIWZL7nw6r/Hj\n 5Gmw==", "X-Gm-Message-State": "ANhLgQ2suxoCdlycVZIQjYTUYV9CMEl6DdQZzaO3s9ZAeRdW+mRod5k+\n /0yw9FeEe6Qp+Y3BzYBdV6ilNA==", "X-Google-Smtp-Source": "\n ADFU+vtLQTUx1zXEubjfDEQjPoztMoUjYppzQYi+OmaLrjGsEAML4eEYCkxtwoyeuzSm4w60FIaGfg==", "X-Received": "by 2002:a05:651c:233:: with SMTP id\n z19mr4133048ljn.176.1584686864644;\n Thu, 19 Mar 2020 23:47:44 -0700 (PDT)", "From": "Muhammad Ahmad <muhammad.ahmad@emumba.com>", "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,\n ferruh.yigit@intel.com", "Cc": "kalesh-anakkur.purayil@broadcom.com,\n Muhammad Ahmad <muhammad.ahmad@emumba.com>, dev@dpdk.org", "Date": "Fri, 20 Mar 2020 11:46:00 +0500", "Message-Id": "<20200320064600.1240-1-muhammad.ahmad@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200319074400.14139-1-muhammad.ahmad@emumba.com>", "References": "<20200319074400.14139-1-muhammad.ahmad@emumba.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=y", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4] app/testpmd: add fw version in port info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_eth_dev_fw_version_get() was not called in test pmd.\n Added rte_eth_dev_fw_version_get() in testpmd under\nshow port info <port no>\n\nBugzilla ID: 225\n\nCc: dev@dpdk.org\n\nReported-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com>\n---\n app/test-pmd/config.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 8cf84ccd3..66f3de908 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -52,6 +52,8 @@\n \n #include \"testpmd.h\"\n \n+#define ETHDEV_FWVERS_LEN 32\n+\n static char *flowtype_to_str(uint16_t flow_type);\n \n static const struct {\n@@ -523,6 +525,7 @@ port_infos_display(portid_t port_id)\n \tuint16_t mtu;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tint ret;\n+\tchar fw_version[ETHDEV_FWVERS_LEN];\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN)) {\n \t\tprint_valid_ports();\n@@ -544,6 +547,13 @@ port_infos_display(portid_t port_id)\n \trte_eth_dev_get_name_by_port(port_id, name);\n \tprintf(\"\\nDevice name: %s\", name);\n \tprintf(\"\\nDriver name: %s\", dev_info.driver_name);\n+\n+\tif (rte_eth_dev_fw_version_get(port_id, fw_version,\n+\t\t\t\t\t\tETHDEV_FWVERS_LEN) == 0)\n+\t\tprintf(\"\\nFirmware-version: %s\", fw_version);\n+\telse\n+\t\tprintf(\"\\nFirmware-version: %s\", \"not available\");\n+\n \tif (dev_info.device->devargs && dev_info.device->devargs->args)\n \t\tprintf(\"\\nDevargs: %s\", dev_info.device->devargs->args);\n \tprintf(\"\\nConnect to socket: %u\", port->socket_id);\n", "prefixes": [ "v4" ] }