Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66909/?format=api
{ "id": 66909, "url": "http://patches.dpdk.org/api/patches/66909/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200318213551.3489504-16-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200318213551.3489504-16-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200318213551.3489504-16-jerinj@marvell.com", "date": "2020-03-18T21:35:40", "name": "[v1,15/26] node: add log infra and null node", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "221f071b5b226505eb19b03c9141c9e8a008427e", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200318213551.3489504-16-jerinj@marvell.com/mbox/", "series": [ { "id": 8974, "url": "http://patches.dpdk.org/api/series/8974/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8974", "date": "2020-03-18T21:35:25", "name": "graph: introduce graph subsystem", "version": 1, "mbox": "http://patches.dpdk.org/series/8974/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66909/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7227A057D;\n\tWed, 18 Mar 2020 22:38:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 02F2B1C126;\n\tWed, 18 Mar 2020 22:36:24 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1D5F61C118\n for <dev@dpdk.org>; Wed, 18 Mar 2020 22:36:21 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 02ILUsFR003319; Wed, 18 Mar 2020 14:36:20 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 2yu8pqmrcj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 18 Mar 2020 14:36:19 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 18 Mar\n 2020 14:36:18 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 18 Mar 2020 14:36:18 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 625043F704A;\n Wed, 18 Mar 2020 14:36:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=3CNOVBBLK73W/OzwOZflpCNsmAzj7S0ytdVggEVXZJo=;\n b=YV3d42q+megRO7eDvpR6wj+UCWpiX9X5sObSzMWg3nyGWHJnFs+/rGSQFzZBf77QuHQ7\n ibGn6bPfzO62l6POE8lQ+KrQXSohaqrVdWUt9QKxRKGjLXiyL5UYxoJl4lFCzyMkZwbT\n OQUWzls/+qZOdyTA95GQ7Rfv1TuRXmrvgxg8w/rSV7HJEWSsylmMQz69WNn8eWN+j/Un\n aD/X0Yl15vDtktZhN1l6fRpDR332BmzqRBRvWs01lpM1SZdLUXs+9TuxQd4YHt9jQY4u\n bPCEiFfSYPY1ygjKqTBbfk4q9aHNobs0nK+2wy/Oq1fkSwDuPUL3TLzRl403reaB8BjT bQ==", "From": "<jerinj@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, John McNamara\n <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>, Bruce Richardson <bruce.richardson@intel.com>", "CC": "<dev@dpdk.org>, <david.marchand@redhat.com>, <mdr@ashroe.eu>,\n <mattias.ronnblom@ericsson.com>, <kirankumark@marvell.com>", "Date": "Thu, 19 Mar 2020 03:05:40 +0530", "Message-ID": "<20200318213551.3489504-16-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200318213551.3489504-1-jerinj@marvell.com>", "References": "<20200318213551.3489504-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645\n definitions=2020-03-18_07:2020-03-18,\n 2020-03-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 15/26] node: add log infra and null node", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nithin Dabilpuram <ndabilpuram@marvell.com>\n\nAdd log infra for node specific logging.\nAlso, add null rte_node that just ignores all the objects\ndirected to it.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\n---\n MAINTAINERS | 5 +++++\n config/common_base | 5 +++++\n doc/api/doxy-api.conf.in | 1 +\n lib/Makefile | 3 +++\n lib/librte_node/Makefile | 20 ++++++++++++++++++++\n lib/librte_node/log.c | 14 ++++++++++++++\n lib/librte_node/meson.build | 6 ++++++\n lib/librte_node/node_private.h | 22 ++++++++++++++++++++++\n lib/librte_node/null.c | 23 +++++++++++++++++++++++\n lib/librte_node/rte_node_version.map | 6 ++++++\n lib/meson.build | 5 ++++-\n meson.build | 1 +\n mk/rte.app.mk | 1 +\n 13 files changed, 111 insertions(+), 1 deletion(-)\n create mode 100644 lib/librte_node/Makefile\n create mode 100644 lib/librte_node/log.c\n create mode 100644 lib/librte_node/meson.build\n create mode 100644 lib/librte_node/node_private.h\n create mode 100644 lib/librte_node/null.c\n create mode 100644 lib/librte_node/rte_node_version.map", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 32d0ea032..3959ed19a 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -1473,6 +1473,11 @@ M: Jerin Jacob <jerinj@marvell.com>\n M: Kiran Kumar K <kirankumark@marvell.com>\n F: lib/librte_graph/\n \n+Nodes - EXPERIMENTAL\n+M: Nithin Dabilpuram <ndabilpuram@marvell.com>\n+M: Pavan Nikhilesh <pbhagavatula@marvell.com>\n+F: lib/librte_node/\n+\n \n Test Applications\n -----------------\ndiff --git a/config/common_base b/config/common_base\nindex 04a96aef5..442949ff1 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -1082,6 +1082,11 @@ CONFIG_RTE_LIBRTE_GRAPH=y\n CONFIG_RTE_GRAPH_BURST_SIZE=256\n CONFIG_RTE_LIBRTE_GRAPH_STATS=y\n \n+#\n+# Compile librte_node\n+#\n+CONFIG_RTE_LIBRTE_NODE=y\n+\n #\n # Compile the test application\n #\ndiff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in\nindex 759a7213e..1d4f1a37d 100644\n--- a/doc/api/doxy-api.conf.in\n+++ b/doc/api/doxy-api.conf.in\n@@ -49,6 +49,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \\\n @TOPDIR@/lib/librte_mempool \\\n @TOPDIR@/lib/librte_meter \\\n @TOPDIR@/lib/librte_metrics \\\n+ @TOPDIR@/lib/librte_node \\\n @TOPDIR@/lib/librte_net \\\n @TOPDIR@/lib/librte_pci \\\n @TOPDIR@/lib/librte_pdump \\\ndiff --git a/lib/Makefile b/lib/Makefile\nindex 1f572b659..50d61a338 100644\n--- a/lib/Makefile\n+++ b/lib/Makefile\n@@ -122,6 +122,9 @@ DEPDIRS-librte_rcu := librte_eal\n DIRS-$(CONFIG_RTE_LIBRTE_GRAPH) += librte_graph\n DEPDIRS-librte_graph := librte_eal\n \n+DIRS-$(CONFIG_RTE_LIBRTE_NODE) += librte_node\n+DEPDIRS-librte_node := librte_graph librte_lpm librte_ethdev librte_mbuf\n+\n ifeq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n DIRS-$(CONFIG_RTE_LIBRTE_KNI) += librte_kni\n endif\ndiff --git a/lib/librte_node/Makefile b/lib/librte_node/Makefile\nnew file mode 100644\nindex 000000000..5f9be6c2e\n--- /dev/null\n+++ b/lib/librte_node/Makefile\n@@ -0,0 +1,20 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(C) 2020 Marvell International Ltd.\n+#\n+\n+include $(RTE_SDK)/mk/rte.vars.mk\n+\n+# library name\n+LIB = librte_node.a\n+\n+CFLAGS += -O3 -DALLOW_EXPERIMENTAL_API\n+CFLAGS += $(WERROR_FLAGS)\n+LDLIBS += -lrte_eal -lrte_graph\n+\n+EXPORT_MAP := rte_node_version.map\n+\n+# all source are stored in SRCS-y\n+SRCS-$(CONFIG_RTE_LIBRTE_NODE) += null.c\n+SRCS-$(CONFIG_RTE_LIBRTE_NODE) += log.c\n+\n+include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_node/log.c b/lib/librte_node/log.c\nnew file mode 100644\nindex 000000000..f035f91e8\n--- /dev/null\n+++ b/lib/librte_node/log.c\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+\n+#include \"node_private.h\"\n+\n+int rte_node_logtype;\n+\n+RTE_INIT(rte_node_init_log)\n+{\n+\trte_node_logtype = rte_log_register(\"lib.node\");\n+\tif (rte_node_logtype >= 0)\n+\t\trte_log_set_level(rte_node_logtype, RTE_LOG_INFO);\n+}\ndiff --git a/lib/librte_node/meson.build b/lib/librte_node/meson.build\nnew file mode 100644\nindex 000000000..655970614\n--- /dev/null\n+++ b/lib/librte_node/meson.build\n@@ -0,0 +1,6 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(C) 2020 Marvell International Ltd.\n+\n+sources = files('null.c', 'log.c')\n+allow_experimental_apis = true\n+deps += ['graph']\ndiff --git a/lib/librte_node/node_private.h b/lib/librte_node/node_private.h\nnew file mode 100644\nindex 000000000..f30902a94\n--- /dev/null\n+++ b/lib/librte_node/node_private.h\n@@ -0,0 +1,22 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+\n+#ifndef __NODE_PRIVATE_H__\n+#define __NODE_PRIVATE_H__\n+\n+#include <rte_common.h>\n+#include <rte_log.h>\n+\n+extern int rte_node_logtype;\n+#define NODE_LOG(level, node_name, ...) \\\n+\trte_log(RTE_LOG_##level, rte_node_logtype, \\\n+\t\tRTE_FMT(\"NODE %s: %s():%u \" RTE_FMT_HEAD(__VA_ARGS__, ) \"\\n\", \\\n+\t\t\tnode_name, __func__, __LINE__, \\\n+\t\t\tRTE_FMT_TAIL(__VA_ARGS__, )))\n+\n+#define node_err(node_name, ...) NODE_LOG(ERR, node_name, __VA_ARGS__)\n+#define node_info(node_name, ...) NODE_LOG(INFO, node_name, __VA_ARGS__)\n+#define node_dbg(node_name, ...) NODE_LOG(DEBUG, node_name, __VA_ARGS__)\n+\n+#endif /* __NODE_PRIVATE_H__ */\ndiff --git a/lib/librte_node/null.c b/lib/librte_node/null.c\nnew file mode 100644\nindex 000000000..c7cd8b6df\n--- /dev/null\n+++ b/lib/librte_node/null.c\n@@ -0,0 +1,23 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ */\n+\n+#include <rte_graph.h>\n+\n+static uint16_t\n+null(struct rte_graph *graph, struct rte_node *node, void **objs,\n+\tuint16_t nb_objs)\n+{\n+\tRTE_SET_USED(node);\n+\tRTE_SET_USED(objs);\n+\tRTE_SET_USED(graph);\n+\n+\treturn nb_objs;\n+}\n+\n+static struct rte_node_register null_node = {\n+\t.name = \"null\",\n+\t.process = null,\n+};\n+\n+RTE_NODE_REGISTER(null_node);\ndiff --git a/lib/librte_node/rte_node_version.map b/lib/librte_node/rte_node_version.map\nnew file mode 100644\nindex 000000000..f87163bb9\n--- /dev/null\n+++ b/lib/librte_node/rte_node_version.map\n@@ -0,0 +1,6 @@\n+EXPERIMENTAL {\n+\tglobal:\n+\n+\trte_node_logtype;\n+\tlocal: *;\n+};\ndiff --git a/lib/meson.build b/lib/meson.build\nindex c43d86bb9..147129b0b 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -30,7 +30,7 @@ libraries = [\n \t# add pkt framework libs which use other libs from above\n \t'port', 'table', 'pipeline',\n \t# flow_classify lib depends on pkt framework table lib\n-\t'flow_classify', 'bpf', 'graph', 'telemetry']\n+\t'flow_classify', 'bpf', 'graph', 'node', 'telemetry']\n \n if is_windows\n \tlibraries = ['kvargs','eal'] # only supported libraries for windows\n@@ -186,6 +186,9 @@ foreach l:libraries\n \n \t\t\tdpdk_libraries = [shared_lib] + dpdk_libraries\n \t\t\tdpdk_static_libraries = [static_lib] + dpdk_static_libraries\n+\t\t\tif libname == 'rte_node'\n+\t\t\t\tdpdk_graph_nodes = [static_lib]\n+\t\t\tendif\n \t\tendif # sources.length() > 0\n \n \t\tset_variable('shared_rte_' + name, shared_dep)\ndiff --git a/meson.build b/meson.build\nindex b7ae9c8d9..811c96421 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -16,6 +16,7 @@ cc = meson.get_compiler('c')\n dpdk_conf = configuration_data()\n dpdk_libraries = []\n dpdk_static_libraries = []\n+dpdk_graph_nodes = []\n dpdk_driver_classes = []\n dpdk_drivers = []\n dpdk_extra_ldflags = []\ndiff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex b1195f09a..68d7806a4 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -99,6 +99,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) += -lrte_reorder\n _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched\n _LDLIBS-$(CONFIG_RTE_LIBRTE_RCU) += -lrte_rcu\n _LDLIBS-$(CONFIG_RTE_LIBRTE_GRAPH) += -lrte_graph\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_NODE) += -lrte_node\n \n ifeq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI) += -lrte_kni\n", "prefixes": [ "v1", "15/26" ] }