Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66897/?format=api
{ "id": 66897, "url": "http://patches.dpdk.org/api/patches/66897/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200318213551.3489504-4-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200318213551.3489504-4-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200318213551.3489504-4-jerinj@marvell.com", "date": "2020-03-18T21:35:28", "name": "[v1,03/26] graph: implement node operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "97fb282d8d4adf2ad8036f26f38e5961dbf2e749", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200318213551.3489504-4-jerinj@marvell.com/mbox/", "series": [ { "id": 8974, "url": "http://patches.dpdk.org/api/series/8974/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8974", "date": "2020-03-18T21:35:25", "name": "graph: introduce graph subsystem", "version": 1, "mbox": "http://patches.dpdk.org/series/8974/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66897/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66897/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E57BA057D;\n\tWed, 18 Mar 2020 22:35:57 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1BE221BF7E;\n\tWed, 18 Mar 2020 22:35:36 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 186891BF7E\n for <dev@dpdk.org>; Wed, 18 Mar 2020 22:35:33 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 02ILV0Z2003373; Wed, 18 Mar 2020 14:35:32 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 2yu8pqmr8k-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 18 Mar 2020 14:35:32 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 18 Mar\n 2020 14:35:30 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 18 Mar 2020 14:35:30 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 0D63E3F703F;\n Wed, 18 Mar 2020 14:35:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=J9utzqq2KUlVcQ48F+PoxWm2CYbAsHtCYoq3aEt1va0=;\n b=pXZwrkk9Af7zSyN4on18SXl0V9vel+z7cLwT7d2Qr7bMx7fVrgZAREpK9i84mClIz4b0\n AGD1hjlj1nGS/D9pZqa+Zb6Hh0eHyQD1lEAa4GMq56nb3OI7qYZATbE/M3bEmOa+QnWv\n cgQfzeUnlW9tAsfjUxZ35woBqDa7YJLhxS2D8D538mG1xM8e6e2m6prpNwJBx0dBgUP/\n eZls/4tt8AasGEfsyGHHBF/4KyPbCQ8mg49AwTWB6G38x7pHGiuaomM4p30JirIla2c8\n 1gx9L+riuTGqKrjNZB0RGOe/84QEYQZR7c8SKTL0PzEhLH9GXu83DHT8f4FuyCDu250w sQ==", "From": "<jerinj@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <david.marchand@redhat.com>,\n <mdr@ashroe.eu>, <mattias.ronnblom@ericsson.com>,\n <pbhagavatula@marvell.com>, <ndabilpuram@marvell.com>", "Date": "Thu, 19 Mar 2020 03:05:28 +0530", "Message-ID": "<20200318213551.3489504-4-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200318213551.3489504-1-jerinj@marvell.com>", "References": "<20200318213551.3489504-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645\n definitions=2020-03-18_07:2020-03-18,\n 2020-03-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 03/26] graph: implement node operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nAdding node-specific API implementation like cloning node, updating\nedges for the node, shrinking edges of a node, retrieving edges of a\nnode.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Kiran Kumar K <kirankumark@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n lib/librte_graph/graph_private.h | 10 +\n lib/librte_graph/node.c | 269 +++++++++++++++++++++++++\n lib/librte_graph/rte_graph_version.map | 10 +\n 3 files changed, 289 insertions(+)", "diff": "diff --git a/lib/librte_graph/graph_private.h b/lib/librte_graph/graph_private.h\nindex ba56927fa..28405ddb7 100644\n--- a/lib/librte_graph/graph_private.h\n+++ b/lib/librte_graph/graph_private.h\n@@ -12,6 +12,16 @@\n #include <rte_eal.h>\n #include <rte_graph.h>\n \n+\n+#define ID_CHECK(id, id_max) \\\n+\tdo { \\\n+\t\tif ((id) >= (id_max)) { \\\n+\t\t\trte_errno = EINVAL; \\\n+\t\t\tgoto fail; \\\n+\t\t} \\\n+\t} while (0)\n+\n+\n /**\n * @internal\n *\ndiff --git a/lib/librte_graph/node.c b/lib/librte_graph/node.c\nindex 7999ca6ed..8de857889 100644\n--- a/lib/librte_graph/node.c\n+++ b/lib/librte_graph/node.c\n@@ -113,3 +113,272 @@ __rte_node_register(const struct rte_node_register *reg)\n \treturn RTE_NODE_ID_INVALID;\n }\n \n+static int\n+clone_name(struct rte_node_register *reg, struct node *node, const char *name)\n+{\n+\tssize_t sz, rc;\n+\n+#define SZ RTE_NODE_NAMESIZE\n+\trc = rte_strscpy(reg->name, node->name, SZ);\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz = rc;\n+\trc = rte_strscpy(reg->name + sz, \"-\", RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz += rc;\n+\tsz = rte_strscpy(reg->name + sz, name, RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (sz < 0)\n+\t\tgoto fail;\n+\n+\treturn 0;\n+fail:\n+\trte_errno = E2BIG;\n+\treturn -rte_errno;\n+}\n+\n+static rte_node_t\n+node_clone(struct node *node, const char *name)\n+{\n+\trte_node_t rc = RTE_NODE_ID_INVALID;\n+\tstruct rte_node_register *reg;\n+\trte_edge_t i;\n+\n+\t/* Don't allow to clone a node from a cloned node */\n+\tif (node->parent_id != RTE_NODE_ID_INVALID) {\n+\t\trte_errno = EEXIST;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Check for duplicate name */\n+\tif (node_has_duplicate_entry(name))\n+\t\tgoto fail;\n+\n+\treg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));\n+\tif (reg == NULL) {\n+\t\trte_errno = ENOMEM;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Clone the source node */\n+\treg->flags = node->flags;\n+\treg->process = node->process;\n+\treg->init = node->init;\n+\treg->fini = node->fini;\n+\treg->nb_edges = node->nb_edges;\n+\treg->parent_id = node->id;\n+\n+\tfor (i = 0; i < node->nb_edges; i++)\n+\t\treg->next_nodes[i] = node->next_nodes[i];\n+\n+\t/* Naming ceremony of the new node. name is node->name + \"-\" + name */\n+\tif (clone_name(reg, node, name))\n+\t\tgoto free;\n+\n+\trc = __rte_node_register(reg);\n+free:\n+\tfree(reg);\n+fail:\n+\treturn rc;\n+}\n+\n+rte_node_t\n+rte_node_clone(rte_node_t id, const char *name)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node_clone(node, name);\n+\n+fail:\n+\treturn RTE_NODE_ID_INVALID;\n+}\n+\n+rte_node_t\n+rte_node_from_name(const char *name)\n+{\n+\tstruct node *node;\n+\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (strncmp(node->name, name, RTE_NODE_NAMESIZE) == 0)\n+\t\t\treturn node->id;\n+\n+\treturn RTE_NODE_ID_INVALID;\n+}\n+\n+char *\n+rte_node_id_to_name(rte_node_t id)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node->name;\n+\n+fail:\n+\treturn NULL;\n+}\n+\n+rte_edge_t\n+rte_node_edge_count(rte_node_t id)\n+{\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tSTAILQ_FOREACH(node, &node_list, next)\n+\t\tif (node->id == id)\n+\t\t\treturn node->nb_edges;\n+fail:\n+\treturn RTE_EDGE_ID_INVALID;\n+}\n+\n+static rte_edge_t\n+edge_update(struct node *node, struct node *prev, rte_edge_t from,\n+\t const char **next_nodes, rte_edge_t nb_edges)\n+{\n+\trte_edge_t i, max_edges, count = 0;\n+\tstruct node *new_node;\n+\tbool need_realloc;\n+\tsize_t sz;\n+\n+\tif (from == RTE_EDGE_ID_INVALID)\n+\t\tfrom = node->nb_edges;\n+\n+\t/* Don't create hole in next_nodes[] list */\n+\tif (from > node->nb_edges) {\n+\t\trte_errno = ENOMEM;\n+\t\tgoto fail;\n+\t}\n+\n+\t/* Remove me from list */\n+\tSTAILQ_REMOVE(&node_list, node, node, next);\n+\n+\t/* Allocate the storage space for new node if required */\n+\tmax_edges = from + nb_edges;\n+\tneed_realloc = max_edges > node->nb_edges;\n+\tif (need_realloc) {\n+\t\tsz = sizeof(struct node) + (max_edges * RTE_NODE_NAMESIZE);\n+\t\tnew_node = realloc(node, sz);\n+\t\tif (new_node == NULL) {\n+\t\t\trte_errno = ENOMEM;\n+\t\t\tgoto restore;\n+\t\t} else {\n+\t\t\tnode = new_node;\n+\t\t}\n+\t}\n+\n+\t/* Update the new nodes name */\n+\tfor (i = from; i < max_edges; i++, count++) {\n+\t\tif (rte_strscpy(node->next_nodes[i], next_nodes[count],\n+\t\t\t\tRTE_NODE_NAMESIZE) < 0) {\n+\t\t\trte_errno = E2BIG;\n+\t\t\tgoto restore;\n+\t\t}\n+\t}\n+restore:\n+\t/* Update the linked list to point new node address in prev node */\n+\tif (prev)\n+\t\tSTAILQ_INSERT_AFTER(&node_list, prev, node, next);\n+\telse\n+\t\tSTAILQ_INSERT_HEAD(&node_list, node, next);\n+\n+\tif (need_realloc)\n+\t\tnode->nb_edges += count;\n+\n+fail:\n+\treturn count;\n+}\n+\n+rte_edge_t\n+rte_node_edge_shrink(rte_node_t id, rte_edge_t size)\n+{\n+\trte_edge_t rc = RTE_EDGE_ID_INVALID;\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tSTAILQ_FOREACH(node, &node_list, next) {\n+\t\tif (node->id == id) {\n+\t\t\tif (node->nb_edges < size) {\n+\t\t\t\trte_errno = E2BIG;\n+\t\t\t\tgoto fail;\n+\t\t\t}\n+\t\t\tnode->nb_edges = size;\n+\t\t\trc = size;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+fail:\n+\tgraph_spinlock_unlock();\n+\treturn rc;\n+}\n+\n+rte_edge_t\n+rte_node_edge_update(rte_node_t id, rte_edge_t from, const char **next_nodes,\n+\t\t uint16_t nb_edges)\n+{\n+\trte_edge_t rc = RTE_EDGE_ID_INVALID;\n+\tstruct node *n, *prev;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tprev = NULL;\n+\tSTAILQ_FOREACH(n, &node_list, next) {\n+\t\tif (n->id == id) {\n+\t\t\trc = edge_update(n, prev, from, next_nodes, nb_edges);\n+\t\t\tbreak;\n+\t\t}\n+\t\tprev = n;\n+\t}\n+\n+\tgraph_spinlock_unlock();\n+fail:\n+\treturn rc;\n+}\n+\n+static rte_node_t\n+node_copy_edges(struct node *node, char *next_nodes[])\n+{\n+\trte_edge_t i;\n+\n+\tfor (i = 0; i < node->nb_edges; i++)\n+\t\tnext_nodes[i] = node->next_nodes[i];\n+\n+\treturn i;\n+}\n+\n+rte_node_t\n+rte_node_edge_get(rte_node_t id, char *next_nodes[])\n+{\n+\trte_node_t rc = RTE_NODE_ID_INVALID;\n+\tstruct node *node;\n+\n+\tNODE_ID_CHECK(id);\n+\tgraph_spinlock_lock();\n+\n+\tSTAILQ_FOREACH(node, &node_list, next) {\n+\t\tif (node->id == id) {\n+\t\t\tif (next_nodes == NULL)\n+\t\t\t\trc = sizeof(char *) * node->nb_edges;\n+\t\t\telse\n+\t\t\t\trc = node_copy_edges(node, next_nodes);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tgraph_spinlock_unlock();\n+fail:\n+\treturn rc;\n+}\n+\n+rte_node_t\n+rte_node_max_count(void)\n+{\n+\treturn node_id;\n+}\ndiff --git a/lib/librte_graph/rte_graph_version.map b/lib/librte_graph/rte_graph_version.map\nindex 0884c09f1..412386356 100644\n--- a/lib/librte_graph/rte_graph_version.map\n+++ b/lib/librte_graph/rte_graph_version.map\n@@ -3,5 +3,15 @@ EXPERIMENTAL {\n \n \t__rte_node_register;\n \n+\trte_node_clone;\n+\trte_node_edge_count;\n+\trte_node_edge_get;\n+\trte_node_edge_shrink;\n+\trte_node_edge_update;\n+\trte_node_from_name;\n+\trte_node_id_to_name;\n+\trte_node_list_dump;\n+\trte_node_max_count;\n+\n \tlocal: *;\n };\n", "prefixes": [ "v1", "03/26" ] }