Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66635/?format=api
{ "id": 66635, "url": "http://patches.dpdk.org/api/patches/66635/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200313091835.58039-3-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200313091835.58039-3-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200313091835.58039-3-gavin.hu@arm.com", "date": "2020-03-13T09:18:30", "name": "[RFC,v1,2/7] net/ena: relax the barrier for doorbell ring", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "eb6c1753ec31c98da68b97650b7f6c61fac4817b", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200313091835.58039-3-gavin.hu@arm.com/mbox/", "series": [ { "id": 8902, "url": "http://patches.dpdk.org/api/series/8902/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8902", "date": "2020-03-13T09:18:28", "name": "relax barriers for ENA PMD and small fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8902/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66635/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66635/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C475A0567;\n\tFri, 13 Mar 2020 10:20:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 051B81C037;\n\tFri, 13 Mar 2020 10:19:56 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 610FE3B5;\n Fri, 13 Mar 2020 10:19:54 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBD0D31B;\n Fri, 13 Mar 2020 02:19:53 -0700 (PDT)", "from net-arm-thunderx2-04.shanghai.arm.com\n (net-arm-thunderx2-04.shanghai.arm.com [10.169.40.184])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C78EB3F67D;\n Fri, 13 Mar 2020 02:19:49 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, david.marchand@redhat.com, thomas@monjalon.net,\n mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, igorch@amazon.com,\n mw@semihalf.com, Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com,\n phil.yang@arm.com, joyce.kong@arm.com, stable@dpdk.org", "Date": "Fri, 13 Mar 2020 17:18:30 +0800", "Message-Id": "<20200313091835.58039-3-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200313091835.58039-1-gavin.hu@arm.com>", "References": "<20200313091835.58039-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH RFC v1 2/7] net/ena: relax the barrier for\n\tdoorbell ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_cio_wmb is a light weight version of IO memory barrier that\nguarantees that the stores to the coherent memory prior to the\nthe rte_cio_rmb() call are visible to the NIC HW before the doorbell\nring(or any other stores to the MMIO registers) that follows it.[1]\n\nFixes: 5e02e19eb14e (\"net/ena: fix unneeded doorbell submission\")\nCc: stable@dpdk.org\n\n[1] http://code.dpdk.org/dpdk/v20.02/source/lib/librte_eal/common/\ninclude/generic/rte_atomic.h#L137\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n drivers/net/ena/ena_ethdev.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 665afee4f..c268788fd 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1425,7 +1425,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \t\t * Add memory barrier to make sure the desc were written before\n \t\t * issue a doorbell\n \t\t */\n-\t\trte_wmb();\n+\t\trte_cio_wmb();\n \t\tena_com_write_sq_doorbell(rxq->ena_com_io_sq);\n \n \t\trxq->next_to_use = next_to_use;\n@@ -2344,7 +2344,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tPMD_DRV_LOG(DEBUG, \"llq tx max burst size of queue %d\"\n \t\t\t\t\" achieved, writing doorbell to send burst\\n\",\n \t\t\t\ttx_ring->id);\n-\t\t\trte_wmb();\n+\t\t\trte_cio_wmb();\n \t\t\tena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);\n \t\t}\n \n@@ -2367,7 +2367,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t/* If there are ready packets to be xmitted... */\n \tif (sent_idx > 0) {\n \t\t/* ...let HW do its best :-) */\n-\t\trte_wmb();\n+\t\trte_cio_wmb();\n \t\tena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);\n \t\ttx_ring->tx_stats.doorbells++;\n \t\ttx_ring->next_to_use = next_to_use;\n", "prefixes": [ "RFC", "v1", "2/7" ] }