Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66630/?format=api
{ "id": 66630, "url": "http://patches.dpdk.org/api/patches/66630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200313081614.195335-3-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200313081614.195335-3-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200313081614.195335-3-ruifeng.wang@arm.com", "date": "2020-03-13T08:16:12", "name": "[v3,2/4] ci: generate fast-tests suite base on hugepage availability", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "be07f22fc9f0d2ce77aa74145e91c81d750720ec", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200313081614.195335-3-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 8901, "url": "http://patches.dpdk.org/api/series/8901/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8901", "date": "2020-03-13T08:16:10", "name": "no-huge unit test", "version": 3, "mbox": "http://patches.dpdk.org/series/8901/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66630/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66630/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03A3EA0567;\n\tFri, 13 Mar 2020 09:17:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EBBC71C037;\n\tFri, 13 Mar 2020 09:17:13 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 81CEE1C02E\n for <dev@dpdk.org>; Fri, 13 Mar 2020 09:17:12 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0471731B;\n Fri, 13 Mar 2020 01:17:12 -0700 (PDT)", "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.40.171])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2295C3F67D;\n Fri, 13 Mar 2020 01:17:07 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "aconole@redhat.com, maicolgabriel@hotmail.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com,\n yipeng1.wang@intel.com, sameh.gobriel@intel.com", "Cc": "dev@dpdk.org, david.marchand@redhat.com, anatoly.burakov@intel.com,\n gavin.hu@arm.com, honnappa.nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Fri, 13 Mar 2020 16:16:12 +0800", "Message-Id": "<20200313081614.195335-3-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200313081614.195335-1-ruifeng.wang@arm.com>", "References": "<20200225073236.135581-1-ruifeng.wang@arm.com>\n <20200313081614.195335-1-ruifeng.wang@arm.com>", "Subject": "[dpdk-dev] [PATCH v3 2/4] ci: generate fast-tests suite base on\n\thugepage availability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In environments where hugepage are not available, such as\ncontainers, many cases in fast-tests suite should also run\nif no-huge EAL option is used.\n\nFlag is appended to each case in fast-tests suite to indicate\nwhether it lives with no-huge mode.\nWith the flag, fast-tests suite can be generated based on\ndetected hugepage availability of building environment.\nAll cases will be valid if hugepage is available, whereas\nonly applicable cases will be added if environment has no\nhugepage support.\n\nSuggested-by: Aaron Conole <aconole@redhat.com>\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n app/test/meson.build | 216 ++++++++++++++++++++++++-------------------\n 1 file changed, 120 insertions(+), 96 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 0a2ce710f..dd121a297 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -154,87 +154,89 @@ test_deps = ['acl',\n \t'timer'\n ]\n \n+# Each test is marked with flag true/false\n+# to indicate whether it can run in no-huge mode.\n fast_test_names = [\n- 'acl_autotest',\n- 'alarm_autotest',\n- 'atomic_autotest',\n- 'byteorder_autotest',\n- 'cmdline_autotest',\n- 'common_autotest',\n- 'cpuflags_autotest',\n- 'cycles_autotest',\n- 'debug_autotest',\n- 'eal_flags_c_opt_autotest',\n- 'eal_flags_master_opt_autotest',\n- 'eal_flags_n_opt_autotest',\n- 'eal_flags_hpet_autotest',\n- 'eal_flags_no_huge_autotest',\n- 'eal_flags_w_opt_autotest',\n- 'eal_flags_b_opt_autotest',\n- 'eal_flags_vdev_opt_autotest',\n- 'eal_flags_r_opt_autotest',\n- 'eal_flags_mem_autotest',\n- 'eal_flags_file_prefix_autotest',\n- 'eal_flags_misc_autotest',\n- 'eal_fs_autotest',\n- 'errno_autotest',\n- 'event_ring_autotest',\n- 'fib_autotest',\n- 'fib6_autotest',\n- 'func_reentrancy_autotest',\n- 'flow_classify_autotest',\n- 'hash_autotest',\n- 'interrupt_autotest',\n- 'logs_autotest',\n- 'lpm_autotest',\n- 'lpm6_autotest',\n- 'malloc_autotest',\n- 'mbuf_autotest',\n- 'mcslock_autotest',\n- 'memcpy_autotest',\n- 'memory_autotest',\n- 'mempool_autotest',\n- 'memzone_autotest',\n- 'meter_autotest',\n- 'multiprocess_autotest',\n- 'per_lcore_autotest',\n- 'prefetch_autotest',\n- 'rcu_qsbr_autotest',\n- 'red_autotest',\n- 'rib_autotest',\n- 'rib6_autotest',\n- 'ring_autotest',\n- 'rwlock_test1_autotest',\n- 'rwlock_rda_autotest',\n- 'rwlock_rds_wrm_autotest',\n- 'rwlock_rde_wro_autotest',\n- 'sched_autotest',\n- 'spinlock_autotest',\n- 'stack_autotest',\n- 'stack_lf_autotest',\n- 'string_autotest',\n- 'table_autotest',\n- 'tailq_autotest',\n- 'timer_autotest',\n- 'user_delay_us',\n- 'version_autotest',\n- 'crc_autotest',\n- 'delay_us_sleep_autotest',\n- 'distributor_autotest',\n- 'eventdev_common_autotest',\n- 'fbarray_autotest',\n- 'hash_readwrite_func_autotest',\n- 'ipsec_autotest',\n- 'kni_autotest',\n- 'kvargs_autotest',\n- 'member_autotest',\n- 'metrics_autotest',\n- 'power_cpufreq_autotest',\n- 'power_autotest',\n- 'power_kvm_vm_autotest',\n- 'reorder_autotest',\n- 'service_autotest',\n- 'thash_autotest',\n+ ['acl_autotest', true],\n+ ['alarm_autotest', false],\n+ ['atomic_autotest', false],\n+ ['byteorder_autotest', true],\n+ ['cmdline_autotest', true],\n+ ['common_autotest', true],\n+ ['cpuflags_autotest', true],\n+ ['cycles_autotest', true],\n+ ['debug_autotest', true],\n+ ['eal_flags_c_opt_autotest', false],\n+ ['eal_flags_master_opt_autotest', false],\n+ ['eal_flags_n_opt_autotest', false],\n+ ['eal_flags_hpet_autotest', false],\n+ ['eal_flags_no_huge_autotest', false],\n+ ['eal_flags_w_opt_autotest', false],\n+ ['eal_flags_b_opt_autotest', false],\n+ ['eal_flags_vdev_opt_autotest', false],\n+ ['eal_flags_r_opt_autotest', false],\n+ ['eal_flags_mem_autotest', false],\n+ ['eal_flags_file_prefix_autotest', false],\n+ ['eal_flags_misc_autotest', false],\n+ ['eal_fs_autotest', true],\n+ ['errno_autotest', true],\n+ ['event_ring_autotest', true],\n+ ['fib_autotest', true],\n+ ['fib6_autotest', true],\n+ ['func_reentrancy_autotest', false],\n+ ['flow_classify_autotest', false],\n+ ['hash_autotest', true],\n+ ['interrupt_autotest', true],\n+ ['logs_autotest', true],\n+ ['lpm_autotest', true],\n+ ['lpm6_autotest', true],\n+ ['malloc_autotest', false],\n+ ['mbuf_autotest', false],\n+ ['mcslock_autotest', false],\n+ ['memcpy_autotest', true],\n+ ['memory_autotest', false],\n+ ['mempool_autotest', false],\n+ ['memzone_autotest', false],\n+ ['meter_autotest', true],\n+ ['multiprocess_autotest', false],\n+ ['per_lcore_autotest', true],\n+ ['prefetch_autotest', true],\n+ ['rcu_qsbr_autotest', true],\n+ ['red_autotest', true],\n+ ['rib_autotest', true],\n+ ['rib6_autotest', true],\n+ ['ring_autotest', true],\n+ ['rwlock_test1_autotest', true],\n+ ['rwlock_rda_autotest', true],\n+ ['rwlock_rds_wrm_autotest', true],\n+ ['rwlock_rde_wro_autotest', true],\n+ ['sched_autotest', true],\n+ ['spinlock_autotest', true],\n+ ['stack_autotest', false],\n+ ['stack_lf_autotest', false],\n+ ['string_autotest', true],\n+ ['table_autotest', true],\n+ ['tailq_autotest', true],\n+ ['timer_autotest', false],\n+ ['user_delay_us', true],\n+ ['version_autotest', true],\n+ ['crc_autotest', true],\n+ ['delay_us_sleep_autotest', true],\n+ ['distributor_autotest', false],\n+ ['eventdev_common_autotest', true],\n+ ['fbarray_autotest', true],\n+ ['hash_readwrite_func_autotest', false],\n+ ['ipsec_autotest', true],\n+ ['kni_autotest', false],\n+ ['kvargs_autotest', true],\n+ ['member_autotest', true],\n+ ['metrics_autotest', true],\n+ ['power_cpufreq_autotest', false],\n+ ['power_autotest', true],\n+ ['power_kvm_vm_autotest', false],\n+ ['reorder_autotest', true],\n+ ['service_autotest', true],\n+ ['thash_autotest', true],\n ]\n \n perf_test_names = [\n@@ -334,13 +336,13 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD')\n \ttest_sources += 'test_link_bonding_mode4.c'\n \ttest_sources += 'sample_packet_forward.c'\n \ttest_sources += 'test_pdump.c'\n-\tfast_test_names += 'ring_pmd_autotest'\n+\tfast_test_names += [['ring_pmd_autotest', true]]\n \tperf_test_names += 'ring_pmd_perf_autotest'\n-\tfast_test_names += 'event_eth_tx_adapter_autotest'\n-\tfast_test_names += 'bitratestats_autotest'\n-\tfast_test_names += 'latencystats_autotest'\n+\tfast_test_names += [['event_eth_tx_adapter_autotest', false]]\n+\tfast_test_names += [['bitratestats_autotest', true]]\n+\tfast_test_names += [['latencystats_autotest', true]]\n \tdriver_test_names += 'link_bonding_mode4_autotest'\n-\tfast_test_names += 'pdump_autotest'\n+\tfast_test_names += [['pdump_autotest', true]]\n endif\n \n if dpdk_conf.has('RTE_LIBRTE_POWER')\n@@ -368,7 +370,7 @@ if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')\n \t\ttest_dep_objs += compress_test_dep\n \t\ttest_sources += 'test_compressdev.c'\n \t\ttest_deps += 'compressdev'\n-\t\tfast_test_names += 'compressdev_autotest'\n+\t\tfast_test_names += [['compressdev_autotest', false]]\n \tendif\n endif\n \n@@ -395,6 +397,17 @@ dpdk_test = executable('dpdk-test',\n \tinstall_rpath: driver_install_path,\n \tinstall: true)\n \n+has_hugepage = true\n+if host_machine.system() == 'linux'\n+\tcheck_hugepage = run_command('cat',\n+\t\t\t\t '/proc/sys/vm/nr_hugepages')\n+\tif (check_hugepage.returncode() != 0 or\n+\t check_hugepage.stdout().strip() == '0')\n+\t\thas_hugepage = false\n+\tendif\n+endif\n+message('hugepage availbility: @0@'.format(has_hugepage))\n+\n # some perf tests (eg: memcpy perf autotest)take very long\n # to complete, so timeout to 10 minutes\n timeout_seconds = 600\n@@ -407,22 +420,33 @@ test_args = [num_cores_arg]\n \n foreach arg : fast_test_names\n \tif (get_option('default_library') == 'shared' and\n-\t\targ == 'event_eth_tx_adapter_autotest')\n+\t\targ[0] == 'event_eth_tx_adapter_autotest')\n \t\tforeach drv:dpdk_drivers\n \t\t\ttest_args += ['-d', drv.full_path().split('.a')[0] + '.so']\n \t\tendforeach\n \tendif\n \tif host_machine.system() == 'linux'\n-\t\ttest(arg, dpdk_test,\n-\t\t\t env : ['DPDK_TEST=' + arg],\n-\t\t\t args : test_args +\n-\t\t\t\t ['--file-prefix=@0@'.format(arg)],\n-\t\ttimeout : timeout_seconds_fast,\n-\t\tis_parallel : false,\n-\t\tsuite : 'fast-tests')\n+\t\tif has_hugepage\n+\t\t\ttest(arg[0], dpdk_test,\n+\t\t\t\t env : ['DPDK_TEST=' + arg[0]],\n+\t\t\t\t args : test_args +\n+\t\t\t\t\t ['--file-prefix=@0@'.format(arg[0])],\n+\t\t\ttimeout : timeout_seconds_fast,\n+\t\t\tis_parallel : false,\n+\t\t\tsuite : 'fast-tests')\n+\t\telif arg[1]\n+\t\t\ttest(arg[0], dpdk_test,\n+\t\t\t\t env : ['DPDK_TEST=' + arg[0]],\n+\t\t\t\t args : test_args +\n+\t\t\t\t\t ['--no-huge'] + ['-m 2048'] +\n+\t\t\t\t\t ['--file-prefix=@0@'.format(arg[0])],\n+\t\t\ttimeout : timeout_seconds_fast,\n+\t\t\tis_parallel : false,\n+\t\t\tsuite : 'fast-tests')\n+\t\tendif\n \telse\n-\t\ttest(arg, dpdk_test,\n-\t\t\tenv : ['DPDK_TEST=' + arg],\n+\t\ttest(arg[0], dpdk_test,\n+\t\t\tenv : ['DPDK_TEST=' + arg[0]],\n \t\t\targs : test_args,\n \t\ttimeout : timeout_seconds_fast,\n \t\tis_parallel : false,\n", "prefixes": [ "v3", "2/4" ] }