Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 66623,
    "url": "http://patches.dpdk.org/api/patches/66623/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200313020806.21654-4-wei.zhao1@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200313020806.21654-4-wei.zhao1@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200313020806.21654-4-wei.zhao1@intel.com",
    "date": "2020-03-13T02:08:02",
    "name": "[3/7] net/ice: change swicth parser to support flexible mask",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "f474284ffbd6a1363598a84089f8fe0b17a0c145",
    "submitter": {
        "id": 495,
        "url": "http://patches.dpdk.org/api/people/495/?format=api",
        "name": "Zhao1, Wei",
        "email": "wei.zhao1@intel.com"
    },
    "delegate": {
        "id": 31221,
        "url": "http://patches.dpdk.org/api/users/31221/?format=api",
        "username": "yexl",
        "first_name": "xiaolong",
        "last_name": "ye",
        "email": "xiaolong.ye@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200313020806.21654-4-wei.zhao1@intel.com/mbox/",
    "series": [
        {
            "id": 8900,
            "url": "http://patches.dpdk.org/api/series/8900/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8900",
            "date": "2020-03-13T02:07:59",
            "name": "add switch filter support for intel DCF",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8900/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/66623/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/66623/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22CA7A0567;\n\tFri, 13 Mar 2020 03:29:11 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0A3A61C06A;\n\tFri, 13 Mar 2020 03:28:50 +0100 (CET)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id EBE281C038\n for <dev@dpdk.org>; Fri, 13 Mar 2020 03:28:46 +0100 (CET)",
            "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Mar 2020 19:28:47 -0700",
            "from unknown (HELO localhost.localdomain.bj.intel.com)\n ([172.16.182.123])\n by fmsmga004.fm.intel.com with ESMTP; 12 Mar 2020 19:28:44 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.70,546,1574150400\"; d=\"scan'208\";a=\"266587180\"",
        "From": "Wei Zhao <wei.zhao1@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "qi.z.zhang@intel.com, xiaolong.ye@intel.com,\n Wei Zhao <wei.zhao1@intel.com>",
        "Date": "Fri, 13 Mar 2020 10:08:02 +0800",
        "Message-Id": "<20200313020806.21654-4-wei.zhao1@intel.com>",
        "X-Mailer": "git-send-email 2.19.1",
        "In-Reply-To": "<20200313020806.21654-1-wei.zhao1@intel.com>",
        "References": "<20200313020806.21654-1-wei.zhao1@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/7] net/ice: change swicth parser to support\n\tflexible mask",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "DCF need to make configuration of flexible mask, that is to say\nsome iput set mask may be not 0xFFFF type all one bit. In order\nto direct L2/IP multicast packets, the mask for source IP maybe\n0xF0000000, this patch enable switch filter parser for it.\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n---\n drivers/net/ice/ice_switch_filter.c | 298 +++++++++++++---------------\n 1 file changed, 133 insertions(+), 165 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c\nindex 39b5c7266..af7e9cb0b 100644\n--- a/drivers/net/ice/ice_switch_filter.c\n+++ b/drivers/net/ice/ice_switch_filter.c\n@@ -326,9 +326,6 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \tconst struct rte_flow_item_pppoe *pppoe_spec, *pppoe_mask;\n \tconst struct rte_flow_item_pppoe_proto_id *pppoe_proto_spec,\n \t\t\t\t*pppoe_proto_mask;\n-\tuint8_t  ipv6_addr_mask[16] = {\n-\t\t0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,\n-\t\t0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF};\n \tuint64_t input_set = ICE_INSET_NONE;\n \tuint16_t j, t = 0;\n \tuint16_t tunnel_valid = 0;\n@@ -351,19 +348,29 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\teth_spec = item->spec;\n \t\t\teth_mask = item->mask;\n \t\t\tif (eth_spec && eth_mask) {\n-\t\t\t\tif (tunnel_valid &&\n-\t\t\t\t    rte_is_broadcast_ether_addr(&eth_mask->src))\n-\t\t\t\t\tinput_set |= ICE_INSET_TUN_SMAC;\n-\t\t\t\telse if (\n-\t\t\t\trte_is_broadcast_ether_addr(&eth_mask->src))\n-\t\t\t\t\tinput_set |= ICE_INSET_SMAC;\n-\t\t\t\tif (tunnel_valid &&\n-\t\t\t\t    rte_is_broadcast_ether_addr(&eth_mask->dst))\n-\t\t\t\t\tinput_set |= ICE_INSET_TUN_DMAC;\n-\t\t\t\telse if (\n-\t\t\t\trte_is_broadcast_ether_addr(&eth_mask->dst))\n-\t\t\t\t\tinput_set |= ICE_INSET_DMAC;\n-\t\t\t\tif (eth_mask->type == RTE_BE16(0xffff))\n+\t\t\t\tfor (j = 0; j < RTE_ETHER_ADDR_LEN; j++) {\n+\t\t\t\t\tif (eth_mask->src.addr_bytes[j]) {\n+\t\t\t\t\tif (tunnel_valid)\n+\t\t\t\t\t\tinput_set |=\n+\t\t\t\t\t\t\tICE_INSET_TUN_SMAC;\n+\t\t\t\t\telse\n+\t\t\t\t\t\tinput_set |=\n+\t\t\t\t\t\t\tICE_INSET_SMAC;\n+\t\t\t\t\tbreak;\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t\tfor (j = 0; j < RTE_ETHER_ADDR_LEN; j++) {\n+\t\t\t\t\tif (eth_mask->dst.addr_bytes[j]) {\n+\t\t\t\t\tif (tunnel_valid)\n+\t\t\t\t\t\tinput_set |=\n+\t\t\t\t\t\tICE_INSET_TUN_DMAC;\n+\t\t\t\t\telse\n+\t\t\t\t\t\tinput_set |=\n+\t\t\t\t\t\tICE_INSET_DMAC;\n+\t\t\t\t\tbreak;\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t\tif (eth_mask->type)\n \t\t\t\t\tinput_set |= ICE_INSET_ETHERTYPE;\n \t\t\t\tlist[t].type = (tunnel_valid  == 0) ?\n \t\t\t\t\tICE_MAC_OFOS : ICE_MAC_IL;\n@@ -373,16 +380,14 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\th = &list[t].h_u.eth_hdr;\n \t\t\t\tm = &list[t].m_u.eth_hdr;\n \t\t\t\tfor (j = 0; j < RTE_ETHER_ADDR_LEN; j++) {\n-\t\t\t\t\tif (eth_mask->src.addr_bytes[j] ==\n-\t\t\t\t\t\t\t\tUINT8_MAX) {\n+\t\t\t\t\tif (eth_mask->src.addr_bytes[j]) {\n \t\t\t\t\t\th->src_addr[j] =\n \t\t\t\t\t\teth_spec->src.addr_bytes[j];\n \t\t\t\t\t\tm->src_addr[j] =\n \t\t\t\t\t\teth_mask->src.addr_bytes[j];\n \t\t\t\t\t\ti = 1;\n \t\t\t\t\t}\n-\t\t\t\t\tif (eth_mask->dst.addr_bytes[j] ==\n-\t\t\t\t\t\t\t\tUINT8_MAX) {\n+\t\t\t\t\tif (eth_mask->dst.addr_bytes[j]) {\n \t\t\t\t\t\th->dst_addr[j] =\n \t\t\t\t\t\teth_spec->dst.addr_bytes[j];\n \t\t\t\t\t\tm->dst_addr[j] =\n@@ -392,17 +397,14 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \t\t\t\tif (i)\n \t\t\t\t\tt++;\n-\t\t\t\tif (eth_mask->type == UINT16_MAX) {\n+\t\t\t\tif (eth_mask->type) {\n \t\t\t\t\tlist[t].type = ICE_ETYPE_OL;\n \t\t\t\t\tlist[t].h_u.ethertype.ethtype_id =\n \t\t\t\t\t\teth_spec->type;\n \t\t\t\t\tlist[t].m_u.ethertype.ethtype_id =\n-\t\t\t\t\t\tUINT16_MAX;\n+\t\t\t\t\t\teth_mask->type;\n \t\t\t\t\tt++;\n \t\t\t\t}\n-\t\t\t} else if (!eth_spec && !eth_mask) {\n-\t\t\t\tlist[t].type = (tun_type == ICE_NON_TUN) ?\n-\t\t\t\t\tICE_MAC_OFOS : ICE_MAC_IL;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -423,81 +425,68 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \n \t\t\t\tif (tunnel_valid) {\n-\t\t\t\t\tif (ipv4_mask->hdr.type_of_service ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.type_of_service)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_TUN_IPV4_TOS;\n-\t\t\t\t\tif (ipv4_mask->hdr.src_addr ==\n-\t\t\t\t\t\t\tUINT32_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.src_addr)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_TUN_IPV4_SRC;\n-\t\t\t\t\tif (ipv4_mask->hdr.dst_addr ==\n-\t\t\t\t\t\t\tUINT32_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.dst_addr)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_TUN_IPV4_DST;\n-\t\t\t\t\tif (ipv4_mask->hdr.time_to_live ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.time_to_live)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_TUN_IPV4_TTL;\n-\t\t\t\t\tif (ipv4_mask->hdr.next_proto_id ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.next_proto_id)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_IPV4_PROTO;\n \t\t\t\t} else {\n-\t\t\t\t\tif (ipv4_mask->hdr.src_addr ==\n-\t\t\t\t\t\t\tUINT32_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.src_addr)\n \t\t\t\t\t\tinput_set |= ICE_INSET_IPV4_SRC;\n-\t\t\t\t\tif (ipv4_mask->hdr.dst_addr ==\n-\t\t\t\t\t\t\tUINT32_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.dst_addr)\n \t\t\t\t\t\tinput_set |= ICE_INSET_IPV4_DST;\n-\t\t\t\t\tif (ipv4_mask->hdr.time_to_live ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.time_to_live)\n \t\t\t\t\t\tinput_set |= ICE_INSET_IPV4_TTL;\n-\t\t\t\t\tif (ipv4_mask->hdr.next_proto_id ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.next_proto_id)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_IPV4_PROTO;\n-\t\t\t\t\tif (ipv4_mask->hdr.type_of_service ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv4_mask->hdr.type_of_service)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_IPV4_TOS;\n \t\t\t\t}\n \t\t\t\tlist[t].type = (tunnel_valid  == 0) ?\n \t\t\t\t\tICE_IPV4_OFOS : ICE_IPV4_IL;\n-\t\t\t\tif (ipv4_mask->hdr.src_addr == UINT32_MAX) {\n+\t\t\t\tif (ipv4_mask->hdr.src_addr) {\n \t\t\t\t\tlist[t].h_u.ipv4_hdr.src_addr =\n \t\t\t\t\t\tipv4_spec->hdr.src_addr;\n \t\t\t\t\tlist[t].m_u.ipv4_hdr.src_addr =\n-\t\t\t\t\t\tUINT32_MAX;\n+\t\t\t\t\t\tipv4_mask->hdr.src_addr;\n \t\t\t\t}\n-\t\t\t\tif (ipv4_mask->hdr.dst_addr == UINT32_MAX) {\n+\t\t\t\tif (ipv4_mask->hdr.dst_addr) {\n \t\t\t\t\tlist[t].h_u.ipv4_hdr.dst_addr =\n \t\t\t\t\t\tipv4_spec->hdr.dst_addr;\n \t\t\t\t\tlist[t].m_u.ipv4_hdr.dst_addr =\n-\t\t\t\t\t\tUINT32_MAX;\n+\t\t\t\t\t\tipv4_mask->hdr.dst_addr;\n \t\t\t\t}\n-\t\t\t\tif (ipv4_mask->hdr.time_to_live == UINT8_MAX) {\n+\t\t\t\tif (ipv4_mask->hdr.time_to_live) {\n \t\t\t\t\tlist[t].h_u.ipv4_hdr.time_to_live =\n \t\t\t\t\t\tipv4_spec->hdr.time_to_live;\n \t\t\t\t\tlist[t].m_u.ipv4_hdr.time_to_live =\n-\t\t\t\t\t\tUINT8_MAX;\n+\t\t\t\t\t\tipv4_mask->hdr.time_to_live;\n \t\t\t\t}\n-\t\t\t\tif (ipv4_mask->hdr.next_proto_id == UINT8_MAX) {\n+\t\t\t\tif (ipv4_mask->hdr.next_proto_id) {\n \t\t\t\t\tlist[t].h_u.ipv4_hdr.protocol =\n \t\t\t\t\t\tipv4_spec->hdr.next_proto_id;\n \t\t\t\t\tlist[t].m_u.ipv4_hdr.protocol =\n-\t\t\t\t\t\tUINT8_MAX;\n+\t\t\t\t\t\tipv4_mask->hdr.next_proto_id;\n \t\t\t\t}\n-\t\t\t\tif (ipv4_mask->hdr.type_of_service ==\n-\t\t\t\t\t\tUINT8_MAX) {\n+\t\t\t\tif (ipv4_mask->hdr.type_of_service) {\n \t\t\t\t\tlist[t].h_u.ipv4_hdr.tos =\n \t\t\t\t\t\tipv4_spec->hdr.type_of_service;\n-\t\t\t\t\tlist[t].m_u.ipv4_hdr.tos = UINT8_MAX;\n+\t\t\t\t\tlist[t].m_u.ipv4_hdr.tos =\n+\t\t\t\t\t\tipv4_mask->hdr.type_of_service;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!ipv4_spec && !ipv4_mask) {\n-\t\t\t\tlist[t].type = (tunnel_valid  == 0) ?\n-\t\t\t\t\tICE_IPV4_OFOS : ICE_IPV4_IL;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -514,51 +503,58 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \n \t\t\t\tif (tunnel_valid) {\n-\t\t\t\t\tif (!memcmp(ipv6_mask->hdr.src_addr,\n-\t\t\t\t\t\tipv6_addr_mask,\n-\t\t\t\t\t    RTE_DIM(ipv6_mask->hdr.src_addr)))\n+\t\t\t\t\tfor (j = 0; j < ICE_IPV6_ADDR_LENGTH;\n+\t\t\t\t\t\tj++) {\n+\t\t\t\t\tif (ipv6_mask->hdr.src_addr[j]) {\n \t\t\t\t\t\tinput_set |=\n-\t\t\t\t\t\t\tICE_INSET_TUN_IPV6_SRC;\n-\t\t\t\t\tif (!memcmp(ipv6_mask->hdr.dst_addr,\n-\t\t\t\t\t\tipv6_addr_mask,\n-\t\t\t\t\t    RTE_DIM(ipv6_mask->hdr.dst_addr)))\n+\t\t\t\t\t\tICE_INSET_TUN_IPV6_SRC;\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t\tfor (j = 0; j < ICE_IPV6_ADDR_LENGTH;\n+\t\t\t\t\t\tj++) {\n+\t\t\t\t\tif (ipv6_mask->hdr.dst_addr[j]) {\n \t\t\t\t\t\tinput_set |=\n-\t\t\t\t\t\t\tICE_INSET_TUN_IPV6_DST;\n-\t\t\t\t\tif (ipv6_mask->hdr.proto == UINT8_MAX)\n+\t\t\t\t\t\tICE_INSET_TUN_IPV6_DST;\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t\tif (ipv6_mask->hdr.proto)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_IPV6_NEXT_HDR;\n-\t\t\t\t\tif (ipv6_mask->hdr.hop_limits ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv6_mask->hdr.hop_limits)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_IPV6_HOP_LIMIT;\n-\t\t\t\t\tif ((ipv6_mask->hdr.vtc_flow &\n+\t\t\t\t\tif (ipv6_mask->hdr.vtc_flow &\n \t\t\t\t\t\trte_cpu_to_be_32\n \t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK))\n-\t\t\t\t\t\t\t== rte_cpu_to_be_32\n-\t\t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK))\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\t\tICE_INSET_TUN_IPV6_TC;\n \t\t\t\t} else {\n-\t\t\t\t\tif (!memcmp(ipv6_mask->hdr.src_addr,\n-\t\t\t\t\t\tipv6_addr_mask,\n-\t\t\t\t\t    RTE_DIM(ipv6_mask->hdr.src_addr)))\n+\t\t\t\t\tfor (j = 0; j < ICE_IPV6_ADDR_LENGTH;\n+\t\t\t\t\t\t\tj++) {\n+\t\t\t\t\tif (ipv6_mask->hdr.src_addr[j]) {\n \t\t\t\t\t\tinput_set |= ICE_INSET_IPV6_SRC;\n-\t\t\t\t\tif (!memcmp(ipv6_mask->hdr.dst_addr,\n-\t\t\t\t\t\tipv6_addr_mask,\n-\t\t\t\t\t    RTE_DIM(ipv6_mask->hdr.dst_addr)))\n-\t\t\t\t\t\tinput_set |= ICE_INSET_IPV6_DST;\n-\t\t\t\t\tif (ipv6_mask->hdr.proto == UINT8_MAX)\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t\tfor (j = 0; j < ICE_IPV6_ADDR_LENGTH;\n+\t\t\t\t\t\tj++) {\n+\t\t\t\t\tif (ipv6_mask->hdr.dst_addr[j]) {\n+\t\t\t\t\t\tinput_set |=\n+\t\t\t\t\t\tICE_INSET_IPV6_DST;\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t\tif (ipv6_mask->hdr.proto)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_IPV6_NEXT_HDR;\n-\t\t\t\t\tif (ipv6_mask->hdr.hop_limits ==\n-\t\t\t\t\t\t\tUINT8_MAX)\n+\t\t\t\t\tif (ipv6_mask->hdr.hop_limits)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_IPV6_HOP_LIMIT;\n-\t\t\t\t\tif ((ipv6_mask->hdr.vtc_flow &\n+\t\t\t\t\tif (ipv6_mask->hdr.vtc_flow &\n \t\t\t\t\t\trte_cpu_to_be_32\n \t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK))\n-\t\t\t\t\t\t\t== rte_cpu_to_be_32\n-\t\t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK))\n \t\t\t\t\t\tinput_set |= ICE_INSET_IPV6_TC;\n \t\t\t\t}\n \t\t\t\tlist[t].type = (tunnel_valid  == 0) ?\n@@ -568,35 +564,33 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\tf = &list[t].h_u.ipv6_hdr;\n \t\t\t\ts = &list[t].m_u.ipv6_hdr;\n \t\t\t\tfor (j = 0; j < ICE_IPV6_ADDR_LENGTH; j++) {\n-\t\t\t\t\tif (ipv6_mask->hdr.src_addr[j] ==\n-\t\t\t\t\t\tUINT8_MAX) {\n+\t\t\t\t\tif (ipv6_mask->hdr.src_addr[j]) {\n \t\t\t\t\t\tf->src_addr[j] =\n \t\t\t\t\t\tipv6_spec->hdr.src_addr[j];\n \t\t\t\t\t\ts->src_addr[j] =\n \t\t\t\t\t\tipv6_mask->hdr.src_addr[j];\n \t\t\t\t\t}\n-\t\t\t\t\tif (ipv6_mask->hdr.dst_addr[j] ==\n-\t\t\t\t\t\t\t\tUINT8_MAX) {\n+\t\t\t\t\tif (ipv6_mask->hdr.dst_addr[j]) {\n \t\t\t\t\t\tf->dst_addr[j] =\n \t\t\t\t\t\tipv6_spec->hdr.dst_addr[j];\n \t\t\t\t\t\ts->dst_addr[j] =\n \t\t\t\t\t\tipv6_mask->hdr.dst_addr[j];\n \t\t\t\t\t}\n \t\t\t\t}\n-\t\t\t\tif (ipv6_mask->hdr.proto == UINT8_MAX) {\n+\t\t\t\tif (ipv6_mask->hdr.proto) {\n \t\t\t\t\tf->next_hdr =\n \t\t\t\t\t\tipv6_spec->hdr.proto;\n-\t\t\t\t\ts->next_hdr = UINT8_MAX;\n+\t\t\t\t\ts->next_hdr =\n+\t\t\t\t\t\tipv6_mask->hdr.proto;\n \t\t\t\t}\n-\t\t\t\tif (ipv6_mask->hdr.hop_limits == UINT8_MAX) {\n+\t\t\t\tif (ipv6_mask->hdr.hop_limits) {\n \t\t\t\t\tf->hop_limit =\n \t\t\t\t\t\tipv6_spec->hdr.hop_limits;\n-\t\t\t\t\ts->hop_limit = UINT8_MAX;\n+\t\t\t\t\ts->hop_limit =\n+\t\t\t\t\t\tipv6_mask->hdr.hop_limits;\n \t\t\t\t}\n-\t\t\t\tif ((ipv6_mask->hdr.vtc_flow &\n+\t\t\t\tif (ipv6_mask->hdr.vtc_flow &\n \t\t\t\t\t\trte_cpu_to_be_32\n-\t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK))\n-\t\t\t\t\t\t== rte_cpu_to_be_32\n \t\t\t\t\t\t(RTE_IPV6_HDR_TC_MASK)) {\n \t\t\t\t\tstruct ice_le_ver_tc_flow vtf;\n \t\t\t\t\tvtf.u.fld.version = 0;\n@@ -606,13 +600,13 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t\t\t\tRTE_IPV6_HDR_TC_MASK) >>\n \t\t\t\t\t\t\tRTE_IPV6_HDR_TC_SHIFT;\n \t\t\t\t\tf->be_ver_tc_flow = CPU_TO_BE32(vtf.u.val);\n-\t\t\t\t\tvtf.u.fld.tc = UINT8_MAX;\n+\t\t\t\t\tvtf.u.fld.tc = (rte_be_to_cpu_32\n+\t\t\t\t\t\t(ipv6_mask->hdr.vtc_flow) &\n+\t\t\t\t\t\t\tRTE_IPV6_HDR_TC_MASK) >>\n+\t\t\t\t\t\t\tRTE_IPV6_HDR_TC_SHIFT;\n \t\t\t\t\ts->be_ver_tc_flow = CPU_TO_BE32(vtf.u.val);\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!ipv6_spec && !ipv6_mask) {\n-\t\t\t\tlist[t].type = (tun_type == ICE_NON_TUN) ?\n-\t\t\t\t\tICE_IPV4_OFOS : ICE_IPV4_IL;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -631,21 +625,17 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \n \t\t\t\tif (tunnel_valid) {\n-\t\t\t\t\tif (udp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (udp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_UDP_SRC_PORT;\n-\t\t\t\t\tif (udp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (udp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_UDP_DST_PORT;\n \t\t\t\t} else {\n-\t\t\t\t\tif (udp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (udp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_UDP_SRC_PORT;\n-\t\t\t\t\tif (udp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (udp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_UDP_DST_PORT;\n \t\t\t\t}\n@@ -654,21 +644,19 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t\tlist[t].type = ICE_UDP_OF;\n \t\t\t\telse\n \t\t\t\t\tlist[t].type = ICE_UDP_ILOS;\n-\t\t\t\tif (udp_mask->hdr.src_port == UINT16_MAX) {\n+\t\t\t\tif (udp_mask->hdr.src_port) {\n \t\t\t\t\tlist[t].h_u.l4_hdr.src_port =\n \t\t\t\t\t\tudp_spec->hdr.src_port;\n \t\t\t\t\tlist[t].m_u.l4_hdr.src_port =\n \t\t\t\t\t\tudp_mask->hdr.src_port;\n \t\t\t\t}\n-\t\t\t\tif (udp_mask->hdr.dst_port == UINT16_MAX) {\n+\t\t\t\tif (udp_mask->hdr.dst_port) {\n \t\t\t\t\tlist[t].h_u.l4_hdr.dst_port =\n \t\t\t\t\t\tudp_spec->hdr.dst_port;\n \t\t\t\t\tlist[t].m_u.l4_hdr.dst_port =\n \t\t\t\t\t\tudp_mask->hdr.dst_port;\n \t\t\t\t}\n \t\t\t\t\t\tt++;\n-\t\t\t} else if (!udp_spec && !udp_mask) {\n-\t\t\t\tlist[t].type = ICE_UDP_ILOS;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -692,40 +680,34 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \n \t\t\t\tif (tunnel_valid) {\n-\t\t\t\t\tif (tcp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (tcp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_TCP_SRC_PORT;\n-\t\t\t\t\tif (tcp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (tcp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_TCP_DST_PORT;\n \t\t\t\t} else {\n-\t\t\t\t\tif (tcp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (tcp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TCP_SRC_PORT;\n-\t\t\t\t\tif (tcp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (tcp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TCP_DST_PORT;\n \t\t\t\t}\n \t\t\t\tlist[t].type = ICE_TCP_IL;\n-\t\t\t\tif (tcp_mask->hdr.src_port == UINT16_MAX) {\n+\t\t\t\tif (tcp_mask->hdr.src_port) {\n \t\t\t\t\tlist[t].h_u.l4_hdr.src_port =\n \t\t\t\t\t\ttcp_spec->hdr.src_port;\n \t\t\t\t\tlist[t].m_u.l4_hdr.src_port =\n \t\t\t\t\t\ttcp_mask->hdr.src_port;\n \t\t\t\t}\n-\t\t\t\tif (tcp_mask->hdr.dst_port == UINT16_MAX) {\n+\t\t\t\tif (tcp_mask->hdr.dst_port) {\n \t\t\t\t\tlist[t].h_u.l4_hdr.dst_port =\n \t\t\t\t\t\ttcp_spec->hdr.dst_port;\n \t\t\t\t\tlist[t].m_u.l4_hdr.dst_port =\n \t\t\t\t\t\ttcp_mask->hdr.dst_port;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!tcp_spec && !tcp_mask) {\n-\t\t\t\tlist[t].type = ICE_TCP_IL;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -743,40 +725,34 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t}\n \n \t\t\t\tif (tunnel_valid) {\n-\t\t\t\t\tif (sctp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (sctp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_SCTP_SRC_PORT;\n-\t\t\t\t\tif (sctp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (sctp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_SCTP_DST_PORT;\n \t\t\t\t} else {\n-\t\t\t\t\tif (sctp_mask->hdr.src_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (sctp_mask->hdr.src_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_SCTP_SRC_PORT;\n-\t\t\t\t\tif (sctp_mask->hdr.dst_port ==\n-\t\t\t\t\t\t\tUINT16_MAX)\n+\t\t\t\t\tif (sctp_mask->hdr.dst_port)\n \t\t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_SCTP_DST_PORT;\n \t\t\t\t}\n \t\t\t\tlist[t].type = ICE_SCTP_IL;\n-\t\t\t\tif (sctp_mask->hdr.src_port == UINT16_MAX) {\n+\t\t\t\tif (sctp_mask->hdr.src_port) {\n \t\t\t\t\tlist[t].h_u.sctp_hdr.src_port =\n \t\t\t\t\t\tsctp_spec->hdr.src_port;\n \t\t\t\t\tlist[t].m_u.sctp_hdr.src_port =\n \t\t\t\t\t\tsctp_mask->hdr.src_port;\n \t\t\t\t}\n-\t\t\t\tif (sctp_mask->hdr.dst_port == UINT16_MAX) {\n+\t\t\t\tif (sctp_mask->hdr.dst_port) {\n \t\t\t\t\tlist[t].h_u.sctp_hdr.dst_port =\n \t\t\t\t\t\tsctp_spec->hdr.dst_port;\n \t\t\t\t\tlist[t].m_u.sctp_hdr.dst_port =\n \t\t\t\t\t\tsctp_mask->hdr.dst_port;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!sctp_spec && !sctp_mask) {\n-\t\t\t\tlist[t].type = ICE_SCTP_IL;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -799,21 +775,21 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\ttunnel_valid = 1;\n \t\t\tif (vxlan_spec && vxlan_mask) {\n \t\t\t\tlist[t].type = ICE_VXLAN;\n-\t\t\t\tif (vxlan_mask->vni[0] == UINT8_MAX &&\n-\t\t\t\t\tvxlan_mask->vni[1] == UINT8_MAX &&\n-\t\t\t\t\tvxlan_mask->vni[2] == UINT8_MAX) {\n+\t\t\t\tif (vxlan_mask->vni[0] ||\n+\t\t\t\t\tvxlan_mask->vni[1] ||\n+\t\t\t\t\tvxlan_mask->vni[2]) {\n \t\t\t\t\tlist[t].h_u.tnl_hdr.vni =\n \t\t\t\t\t\t(vxlan_spec->vni[2] << 16) |\n \t\t\t\t\t\t(vxlan_spec->vni[1] << 8) |\n \t\t\t\t\t\tvxlan_spec->vni[0];\n \t\t\t\t\tlist[t].m_u.tnl_hdr.vni =\n-\t\t\t\t\t\tUINT32_MAX;\n+\t\t\t\t\t\t(vxlan_mask->vni[2] << 16) |\n+\t\t\t\t\t\t(vxlan_mask->vni[1] << 8) |\n+\t\t\t\t\t\tvxlan_mask->vni[0];\n \t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_VXLAN_VNI;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!vxlan_spec && !vxlan_mask) {\n-\t\t\t\tlist[t].type = ICE_VXLAN;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -835,21 +811,21 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\ttunnel_valid = 1;\n \t\t\tif (nvgre_spec && nvgre_mask) {\n \t\t\t\tlist[t].type = ICE_NVGRE;\n-\t\t\t\tif (nvgre_mask->tni[0] == UINT8_MAX &&\n-\t\t\t\t\tnvgre_mask->tni[1] == UINT8_MAX &&\n-\t\t\t\t\tnvgre_mask->tni[2] == UINT8_MAX) {\n+\t\t\t\tif (nvgre_mask->tni[0] ||\n+\t\t\t\t\tnvgre_mask->tni[1] ||\n+\t\t\t\t\tnvgre_mask->tni[2]) {\n \t\t\t\t\tlist[t].h_u.nvgre_hdr.tni_flow =\n \t\t\t\t\t\t(nvgre_spec->tni[2] << 16) |\n \t\t\t\t\t\t(nvgre_spec->tni[1] << 8) |\n \t\t\t\t\t\tnvgre_spec->tni[0];\n \t\t\t\t\tlist[t].m_u.nvgre_hdr.tni_flow =\n-\t\t\t\t\t\tUINT32_MAX;\n+\t\t\t\t\t\t(nvgre_mask->tni[2] << 16) |\n+\t\t\t\t\t\t(nvgre_mask->tni[1] << 8) |\n+\t\t\t\t\t\tnvgre_mask->tni[0];\n \t\t\t\t\tinput_set |=\n \t\t\t\t\t\tICE_INSET_TUN_NVGRE_TNI;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!nvgre_spec && !nvgre_mask) {\n-\t\t\t\tlist[t].type = ICE_NVGRE;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -870,23 +846,21 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t}\n \t\t\tif (vlan_spec && vlan_mask) {\n \t\t\t\tlist[t].type = ICE_VLAN_OFOS;\n-\t\t\t\tif (vlan_mask->tci == UINT16_MAX) {\n+\t\t\t\tif (vlan_mask->tci) {\n \t\t\t\t\tlist[t].h_u.vlan_hdr.vlan =\n \t\t\t\t\t\tvlan_spec->tci;\n \t\t\t\t\tlist[t].m_u.vlan_hdr.vlan =\n-\t\t\t\t\t\tUINT16_MAX;\n+\t\t\t\t\t\tvlan_mask->tci;\n \t\t\t\t\tinput_set |= ICE_INSET_VLAN_OUTER;\n \t\t\t\t}\n-\t\t\t\tif (vlan_mask->inner_type == UINT16_MAX) {\n+\t\t\t\tif (vlan_mask->inner_type) {\n \t\t\t\t\tlist[t].h_u.vlan_hdr.type =\n \t\t\t\t\t\tvlan_spec->inner_type;\n \t\t\t\t\tlist[t].m_u.vlan_hdr.type =\n-\t\t\t\t\t\tUINT16_MAX;\n+\t\t\t\t\t\tvlan_mask->inner_type;\n \t\t\t\t\tinput_set |= ICE_INSET_VLAN_OUTER;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!vlan_spec && !vlan_mask) {\n-\t\t\t\tlist[t].type = ICE_VLAN_OFOS;\n \t\t\t}\n \t\t\tbreak;\n \n@@ -918,19 +892,16 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\t\treturn 0;\n \t\t\t\t}\n \t\t\t\tlist[t].type = ICE_PPPOE;\n-\t\t\t\tif (pppoe_mask->session_id == UINT16_MAX) {\n+\t\t\t\tif (pppoe_mask->session_id) {\n \t\t\t\t\tlist[t].h_u.pppoe_hdr.session_id =\n \t\t\t\t\t\tpppoe_spec->session_id;\n \t\t\t\t\tlist[t].m_u.pppoe_hdr.session_id =\n-\t\t\t\t\t\tUINT16_MAX;\n+\t\t\t\t\t\tpppoe_mask->session_id;\n \t\t\t\t\tinput_set |= ICE_INSET_PPPOE_SESSION;\n \t\t\t\t}\n \t\t\t\tt++;\n \t\t\t\tpppoe_valid = 1;\n-\t\t\t} else if (!pppoe_spec && !pppoe_mask) {\n-\t\t\t\tlist[t].type = ICE_PPPOE;\n \t\t\t}\n-\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID:\n@@ -953,18 +924,15 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],\n \t\t\t\tif (pppoe_valid)\n \t\t\t\t\tt--;\n \t\t\t\tlist[t].type = ICE_PPPOE;\n-\t\t\t\tif (pppoe_proto_mask->proto_id == UINT16_MAX) {\n+\t\t\t\tif (pppoe_proto_mask->proto_id) {\n \t\t\t\t\tlist[t].h_u.pppoe_hdr.ppp_prot_id =\n \t\t\t\t\t\tpppoe_proto_spec->proto_id;\n \t\t\t\t\tlist[t].m_u.pppoe_hdr.ppp_prot_id =\n-\t\t\t\t\t\tUINT16_MAX;\n+\t\t\t\t\t\tpppoe_proto_mask->proto_id;\n \t\t\t\t\tinput_set |= ICE_INSET_PPPOE_PROTO;\n \t\t\t\t}\n \t\t\t\tt++;\n-\t\t\t} else if (!pppoe_proto_spec && !pppoe_proto_mask) {\n-\t\t\t\tlist[t].type = ICE_PPPOE;\n \t\t\t}\n-\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ITEM_TYPE_VOID:\n",
    "prefixes": [
        "3/7"
    ]
}