Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66607/?format=api
{ "id": 66607, "url": "http://patches.dpdk.org/api/patches/66607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200312172047.19973-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200312172047.19973-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200312172047.19973-4-stephen@networkplumber.org", "date": "2020-03-12T17:20:43", "name": "[3/7] examples/l3fwd: block attempts to use owned ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b694bd7fe89bb8b1c46f31478b376339adff5570", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200312172047.19973-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 8898, "url": "http://patches.dpdk.org/api/series/8898/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8898", "date": "2020-03-12T17:20:40", "name": "checking for owned ports in portmask", "version": 1, "mbox": "http://patches.dpdk.org/series/8898/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66607/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E05A7A056D;\n\tThu, 12 Mar 2020 18:21:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AEFE1C036;\n\tThu, 12 Mar 2020 18:21:03 +0100 (CET)", "from mail-pj1-f67.google.com (mail-pj1-f67.google.com\n [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 3D14E1C012\n for <dev@dpdk.org>; Thu, 12 Mar 2020 18:20:59 +0100 (CET)", "by mail-pj1-f67.google.com with SMTP id d8so2924314pje.4\n for <dev@dpdk.org>; Thu, 12 Mar 2020 10:20:59 -0700 (PDT)", "from hermes.corp.microsoft.com (204-195-22-127.wavecable.com.\n [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id v1sm9447511pjy.35.2020.03.12.10.20.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 12 Mar 2020 10:20:56 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=kcq6NWgod5osKvrxdEtMQjmmS5QiNiB/WlPhCsJbOK0=;\n b=tcgmpe3V2rZzOqW3kDwAtXLGeL1xsTieckxiwwqApA2/hkxjcGe0xexwIXCwBKSXCG\n 2J4oUWnGDpv5StGfx91brQstqhyu/6BPc0l5gVxiOhj0La/FiL2B+xFNBELl4X/73qZZ\n niSucwy/jD0dEVhYezA+nCa1eGv937U5gM32ddIHdjc0ZvX+ntpfPIhMxsE6eSLH6Ro6\n lNCXI91CoWOS6W6cLEsFhaf6ABektlrIw5lOkKXOgBF8TIlLB1caOrOCCP/I7ifcExh0\n 7JtcNxqCa35krQcdQX2HYURL0hSN8uHGZ4iKXRFhvd6q8ww57eE1oqm1LmI+RC/NR870\n 0ngA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=kcq6NWgod5osKvrxdEtMQjmmS5QiNiB/WlPhCsJbOK0=;\n b=J8llOB6de40UNvfM80Gnqd8nWIS9iqWQU+nDr/LKYdJmlVKo8so7BLKoCaVDgWCMhN\n 1wkTXDKAhApo9PIjNRy+dpZtoDH3OsJGbHe1uW+NZHcgAPlTCxRZTtOY/BNAB8ZohzJD\n DWv41Ojp8dkn7sIkuqH1s9CE5O6hORTuPxTtN4fv2FOpHnNhTYviDjy6vFGOdZzbc1xr\n IS979xsabdmjevI4pyUNRB0x3ayCbmGJyZ5+hL1Vn3GLx0m8M65oE8sBKRLWEXkKTCQM\n D9qk+7ZtOn0k1D7DIn32UysoyPFCH65pe7Dx88ogJfaZQtqO4kd4xFZUkYVJ9NrJh5f7\n N4pQ==", "X-Gm-Message-State": "ANhLgQ3PsHRH+4145bStyVUeY2jJ1Nf8zx4HD/Jd+HUOxvApsZ+OULXI\n tD6mzGEE6WIRtodT/WplK1xM6taxiO0=", "X-Google-Smtp-Source": "\n ADFU+vuV6aDObctJJCucSHq7T1iOUmEdSeDL7/hcXbw0Wq6q8gzYS0+OWCTV7L1r6KW0vICgY/4rjA==", "X-Received": "by 2002:a17:902:aa49:: with SMTP id\n c9mr9252878plr.145.1584033657869;\n Thu, 12 Mar 2020 10:20:57 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, matan@mellanox.com,\n stable@dpdk.org", "Date": "Thu, 12 Mar 2020 10:20:43 -0700", "Message-Id": "<20200312172047.19973-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200312172047.19973-1-stephen@networkplumber.org>", "References": "<20200312172047.19973-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/7] examples/l3fwd: block attempts to use owned\n\tports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a ethdev port is in use for a sub device, then it should not\nbe allowed in the portmask of l3fwd.\n\nFixes: 5b7ba31148a8 (\"ethdev: add port ownership\")\nCc: matan@mellanox.com\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/l3fwd/Makefile | 3 +++\n examples/l3fwd/main.c | 4 ++++\n examples/l3fwd/meson.build | 1 +\n 3 files changed, 8 insertions(+)", "diff": "diff --git a/examples/l3fwd/Makefile b/examples/l3fwd/Makefile\nindex 59a110d12a49..59cd00abe6e9 100644\n--- a/examples/l3fwd/Makefile\n+++ b/examples/l3fwd/Makefile\n@@ -25,6 +25,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)\n \n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+\n build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n \t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n \n@@ -50,6 +52,7 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf\n \n include $(RTE_SDK)/mk/rte.vars.mk\n \n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -I$(SRCDIR)\n CFLAGS += -O3 $(USER_FLAGS)\n CFLAGS += $(WERROR_FLAGS)\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex dda430d68a20..307a490fb552 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -221,6 +221,10 @@ check_port_config(void)\n \t\t\tprintf(\"port %u is not present on the board\\n\", portid);\n \t\t\treturn -1;\n \t\t}\n+\t\tif (!rte_eth_dev_is_owned_by(portid, RTE_ETH_DEV_NO_OWNER)) {\n+\t\t\tprintf(\"port %u is already in use\\n\", portid);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \treturn 0;\n }\ndiff --git a/examples/l3fwd/meson.build b/examples/l3fwd/meson.build\nindex ebed3b518c4b..7d72b1b365ae 100644\n--- a/examples/l3fwd/meson.build\n+++ b/examples/l3fwd/meson.build\n@@ -6,6 +6,7 @@\n # To build this example as a standalone application with an already-installed\n # DPDK instance, use 'make'\n \n+allow_experimental_apis = true\n deps += ['hash', 'lpm', 'eventdev']\n sources = files(\n \t'l3fwd_em.c', 'l3fwd_lpm.c', 'l3fwd_event.c',\n", "prefixes": [ "3/7" ] }