Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66521/?format=api
{ "id": 66521, "url": "http://patches.dpdk.org/api/patches/66521/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-8-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583862551-2049-8-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583862551-2049-8-git-send-email-phil.yang@arm.com", "date": "2020-03-10T17:49:08", "name": "[07/10] service: avoid race condition for MT unsafe service", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b008dd474c1526943ebc41d50b40e36197472e4a", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-8-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 8875, "url": "http://patches.dpdk.org/api/series/8875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8875", "date": "2020-03-10T17:49:01", "name": "generic rte atomic APIs deprecate proposal", "version": 1, "mbox": "http://patches.dpdk.org/series/8875/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66521/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 54C1DA0566;\n\tTue, 10 Mar 2020 18:51:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78AC61C0BC;\n\tTue, 10 Mar 2020 18:50:24 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id CFA3F1C0B7;\n Tue, 10 Mar 2020 18:50:22 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 624DA1FB;\n Tue, 10 Mar 2020 10:50:22 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 964293F534;\n Tue, 10 Mar 2020 10:50:18 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net, harry.van.haaren@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n maxime.coquelin@redhat.com, dev@dpdk.org", "Cc": "david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com,\n joyce.kong@arm.com, nd@arm.com,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, stable@dpdk.org", "Date": "Wed, 11 Mar 2020 01:49:08 +0800", "Message-Id": "<1583862551-2049-8-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "References": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 07/10] service: avoid race condition for MT\n\tunsafe service", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\nThere has possible that a MT unsafe service might get configured to\nrun on another core while the service is running currently. This\nmight result in the MT unsafe service running on multiple cores\nsimultaneously. Use 'execute_lock' always when the service is\nMT unsafe.\n\nFixes: e9139a32f6e8 (\"service: add function to run on app lcore\")\nCc: stable@dpdk.org\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\n---\n lib/librte_eal/common/rte_service.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex 6990dc2..b37fc56 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -50,6 +50,10 @@ struct rte_service_spec_impl {\n \tuint8_t internal_flags;\n \n \t/* per service statistics */\n+\t/* Indicates how many cores the service is mapped to run on.\n+\t * It does not indicate the number of cores the service is running\n+\t * on currently.\n+\t */\n \trte_atomic32_t num_mapped_cores;\n \tuint64_t calls;\n \tuint64_t cycles_spent;\n@@ -367,12 +371,7 @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask,\n \n \tcs->service_active_on_lcore[i] = 1;\n \n-\t/* check do we need cmpset, if MT safe or <= 1 core\n-\t * mapped, atomic ops are not required.\n-\t */\n-\tconst int use_atomics = (service_mt_safe(s) == 0) &&\n-\t\t\t\t(rte_atomic32_read(&s->num_mapped_cores) > 1);\n-\tif (use_atomics) {\n+\tif (service_mt_safe(s) == 0) {\n \t\tif (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1))\n \t\t\treturn -EBUSY;\n \n", "prefixes": [ "07/10" ] }