Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66520/?format=api
{ "id": 66520, "url": "http://patches.dpdk.org/api/patches/66520/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-7-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583862551-2049-7-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583862551-2049-7-git-send-email-phil.yang@arm.com", "date": "2020-03-10T17:49:07", "name": "[06/10] service: remove redundant code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "55dc9f6f6eb3ce30a9b409c18678ecc90c1f0970", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-7-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 8875, "url": "http://patches.dpdk.org/api/series/8875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8875", "date": "2020-03-10T17:49:01", "name": "generic rte atomic APIs deprecate proposal", "version": 1, "mbox": "http://patches.dpdk.org/series/8875/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66520/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66520/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08240A0566;\n\tTue, 10 Mar 2020 18:50:57 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 246611C08C;\n\tTue, 10 Mar 2020 18:50:20 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 96EC71C0AE;\n Tue, 10 Mar 2020 18:50:18 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2905B7FA;\n Tue, 10 Mar 2020 10:50:18 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6296B3F534;\n Tue, 10 Mar 2020 10:50:14 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net, harry.van.haaren@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n maxime.coquelin@redhat.com, dev@dpdk.org", "Cc": "david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com,\n joyce.kong@arm.com, nd@arm.com, Stable@dpdk.org", "Date": "Wed, 11 Mar 2020 01:49:07 +0800", "Message-Id": "<1583862551-2049-7-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "References": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 06/10] service: remove redundant code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The service id validation is verified in the calling function, remove\nthe redundant code inside the service_update function.\n\nFixes: 21698354c832 (\"service: introduce service cores concept\")\nCc: Stable@dpdk.org\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n lib/librte_eal/common/rte_service.c | 31 ++++++++++++-------------------\n 1 file changed, 12 insertions(+), 19 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex a691f5d..6990dc2 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -549,21 +549,10 @@ rte_service_start_with_defaults(void)\n }\n \n static int32_t\n-service_update(struct rte_service_spec *service, uint32_t lcore,\n+service_update(uint32_t sid, uint32_t lcore,\n \t\tuint32_t *set, uint32_t *enabled)\n {\n-\tuint32_t i;\n-\tint32_t sid = -1;\n-\n-\tfor (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {\n-\t\tif ((struct rte_service_spec *)&rte_services[i] == service &&\n-\t\t\t\tservice_valid(i)) {\n-\t\t\tsid = i;\n-\t\t\tbreak;\n-\t\t}\n-\t}\n-\n-\tif (sid == -1 || lcore >= RTE_MAX_LCORE)\n+\tif (lcore >= RTE_MAX_LCORE)\n \t\treturn -EINVAL;\n \n \tif (!lcore_states[lcore].is_service_core)\n@@ -595,19 +584,23 @@ service_update(struct rte_service_spec *service, uint32_t lcore,\n int32_t\n rte_service_map_lcore_set(uint32_t id, uint32_t lcore, uint32_t enabled)\n {\n-\tstruct rte_service_spec_impl *s;\n-\tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n+\t/* validate ID, or return error value */\n+\tif (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))\n+\t\treturn -EINVAL;\n+\n \tuint32_t on = enabled > 0;\n-\treturn service_update(&s->spec, lcore, &on, 0);\n+\treturn service_update(id, lcore, &on, 0);\n }\n \n int32_t\n rte_service_map_lcore_get(uint32_t id, uint32_t lcore)\n {\n-\tstruct rte_service_spec_impl *s;\n-\tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n+\t/* validate ID, or return error value */\n+\tif (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))\n+\t\treturn -EINVAL;\n+\n \tuint32_t enabled;\n-\tint ret = service_update(&s->spec, lcore, 0, &enabled);\n+\tint ret = service_update(id, lcore, 0, &enabled);\n \tif (ret == 0)\n \t\treturn enabled;\n \treturn ret;\n", "prefixes": [ "06/10" ] }