Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66519/?format=api
{ "id": 66519, "url": "http://patches.dpdk.org/api/patches/66519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-6-git-send-email-phil.yang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1583862551-2049-6-git-send-email-phil.yang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1583862551-2049-6-git-send-email-phil.yang@arm.com", "date": "2020-03-10T17:49:06", "name": "[05/10] service: remove rte prefix from static functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3d56056e01c373efe338cca120fc90efc1da7bbe", "submitter": { "id": 833, "url": "http://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1583862551-2049-6-git-send-email-phil.yang@arm.com/mbox/", "series": [ { "id": 8875, "url": "http://patches.dpdk.org/api/series/8875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8875", "date": "2020-03-10T17:49:01", "name": "generic rte atomic APIs deprecate proposal", "version": 1, "mbox": "http://patches.dpdk.org/series/8875/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66519/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/66519/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0BF67A0566;\n\tTue, 10 Mar 2020 18:50:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2C47B1C08D;\n\tTue, 10 Mar 2020 18:50:16 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 646CB1C07C;\n Tue, 10 Mar 2020 18:50:14 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA0B71FB;\n Tue, 10 Mar 2020 10:50:13 -0700 (PDT)", "from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2E0973F534;\n Tue, 10 Mar 2020 10:50:09 -0700 (PDT)" ], "From": "Phil Yang <phil.yang@arm.com>", "To": "thomas@monjalon.net, harry.van.haaren@intel.com,\n konstantin.ananyev@intel.com, stephen@networkplumber.org,\n maxime.coquelin@redhat.com, dev@dpdk.org", "Cc": "david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com,\n joyce.kong@arm.com, nd@arm.com, stable@dpdk.org", "Date": "Wed, 11 Mar 2020 01:49:06 +0800", "Message-Id": "<1583862551-2049-6-git-send-email-phil.yang@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "References": "<1583862551-2049-1-git-send-email-phil.yang@arm.com>", "Subject": "[dpdk-dev] [PATCH 05/10] service: remove rte prefix from static\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 3cf5eb1546ed (\"service: fix and refactor atomic service accesses\")\nFixes: 21698354c832 (\"service: introduce service cores concept\")\nCc: stable@dpdk.org\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n lib/librte_eal/common/rte_service.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex 7e537b8..a691f5d 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -333,7 +333,7 @@ rte_service_runstate_get(uint32_t id)\n }\n \n static inline void\n-rte_service_runner_do_callback(struct rte_service_spec_impl *s,\n+service_runner_do_callback(struct rte_service_spec_impl *s,\n \t\t\t struct core_state *cs, uint32_t service_idx)\n {\n \tvoid *userdata = s->spec.callback_userdata;\n@@ -376,10 +376,10 @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask,\n \t\tif (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1))\n \t\t\treturn -EBUSY;\n \n-\t\trte_service_runner_do_callback(s, cs, i);\n+\t\tservice_runner_do_callback(s, cs, i);\n \t\trte_atomic32_clear(&s->execute_lock);\n \t} else\n-\t\trte_service_runner_do_callback(s, cs, i);\n+\t\tservice_runner_do_callback(s, cs, i);\n \n \treturn 0;\n }\n@@ -433,7 +433,7 @@ rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t serialize_mt_unsafe)\n }\n \n static int32_t\n-rte_service_runner_func(void *arg)\n+service_runner_func(void *arg)\n {\n \tRTE_SET_USED(arg);\n \tuint32_t i;\n@@ -703,7 +703,7 @@ rte_service_lcore_start(uint32_t lcore)\n \t */\n \tlcore_states[lcore].runstate = RUNSTATE_RUNNING;\n \n-\tint ret = rte_eal_remote_launch(rte_service_runner_func, 0, lcore);\n+\tint ret = rte_eal_remote_launch(service_runner_func, 0, lcore);\n \t/* returns -EBUSY if the core is already launched, 0 on success */\n \treturn ret;\n }\n@@ -782,7 +782,7 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id,\n }\n \n static void\n-rte_service_dump_one(FILE *f, struct rte_service_spec_impl *s,\n+service_dump_one(FILE *f, struct rte_service_spec_impl *s,\n \t\t uint64_t all_cycles, uint32_t reset)\n {\n \t/* avoid divide by zero */\n@@ -815,7 +815,7 @@ rte_service_attr_reset_all(uint32_t id)\n \tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n \n \tint reset = 1;\n-\trte_service_dump_one(NULL, s, 0, reset);\n+\tservice_dump_one(NULL, s, 0, reset);\n \treturn 0;\n }\n \n@@ -873,7 +873,7 @@ rte_service_dump(FILE *f, uint32_t id)\n \t\tSERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);\n \t\tfprintf(f, \"Service %s Summary\\n\", s->spec.name);\n \t\tuint32_t reset = 0;\n-\t\trte_service_dump_one(f, s, total_cycles, reset);\n+\t\tservice_dump_one(f, s, total_cycles, reset);\n \t\treturn 0;\n \t}\n \n@@ -883,7 +883,7 @@ rte_service_dump(FILE *f, uint32_t id)\n \t\tif (!service_valid(i))\n \t\t\tcontinue;\n \t\tuint32_t reset = 0;\n-\t\trte_service_dump_one(f, &rte_services[i], total_cycles, reset);\n+\t\tservice_dump_one(f, &rte_services[i], total_cycles, reset);\n \t}\n \n \tfprintf(f, \"Service Cores Summary\\n\");\n", "prefixes": [ "05/10" ] }