Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66508/?format=api
{ "id": 66508, "url": "http://patches.dpdk.org/api/patches/66508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200310133304.39951-1-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200310133304.39951-1-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200310133304.39951-1-harry.van.haaren@intel.com", "date": "2020-03-10T13:33:04", "name": "eal/service: fix exit by resetting service lcores", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8b67ec0958adb111b6bca63b496312ac1260a5fb", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200310133304.39951-1-harry.van.haaren@intel.com/mbox/", "series": [ { "id": 8869, "url": "http://patches.dpdk.org/api/series/8869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8869", "date": "2020-03-10T13:33:04", "name": "eal/service: fix exit by resetting service lcores", "version": 1, "mbox": "http://patches.dpdk.org/series/8869/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66508/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/66508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8A935A0566;\n\tTue, 10 Mar 2020 14:32:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D70FD2BE6;\n\tTue, 10 Mar 2020 14:32:38 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id C00DF23D\n for <dev@dpdk.org>; Tue, 10 Mar 2020 14:32:36 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 10 Mar 2020 06:32:35 -0700", "from silpixa00399779.ir.intel.com (HELO\n silpixa00399779.ger.corp.intel.com) ([10.237.222.209])\n by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2020 06:32:34 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,537,1574150400\"; d=\"scan'208\";a=\"265618409\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, aconole@redhat.com,\n Harry van Haaren <harry.van.haaren@intel.com>", "Date": "Tue, 10 Mar 2020 13:33:04 +0000", "Message-Id": "<20200310133304.39951-1-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit releases all service cores from thier role,\nreturning them to ROLE_RTE on rte_service_finalize().\n\nThis may fix an issue relating to the service cores causing\na race-condition on eal_cleanup(), where the service core\ncould still be executing while the main thread has already\nfree-d the service memory, leading to a segfault.\n\nFixes: 21698354c832 (\"service: introduce service cores concept\")\n\nReported-by: David Marchand <david.marchand@redhat.com>\nReported-by: Aaron Conole <aconole@redhat.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nPlease note that this patch is being sent to community for\ntesting as I cannot reliably reproduce the reported issue on\nmy local setup (despite code-changes in attempts to make the\nproblem more visible, and instructions from David on how he\ncan reproduce it). Email discusson on this topic here:\nhttps://mails.dpdk.org/archives/dev/2020-March/159584.html\n---\n lib/librte_eal/common/rte_service.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex 7e537b8cd..d400ccf79 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -122,6 +122,8 @@ rte_service_finalize(void)\n \tif (!rte_service_library_initialized)\n \t\treturn;\n \n+\trte_service_lcore_reset_all();\n+\n \trte_free(rte_services);\n \trte_free(lcore_states);\n \n", "prefixes": [] }