Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66440/?format=api
{ "id": 66440, "url": "http://patches.dpdk.org/api/patches/66440/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-24-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309114357.31800-24-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309114357.31800-24-qi.z.zhang@intel.com", "date": "2020-03-09T11:43:52", "name": "[23/28] net/ice/base: support PHY persistent feature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3b4a9fb5b94fb4a97c0403711f672ef614d0707f", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-24-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 8843, "url": "http://patches.dpdk.org/api/series/8843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8843", "date": "2020-03-09T11:43:29", "name": "update ice base code", "version": 1, "mbox": "http://patches.dpdk.org/series/8843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66440/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77706A052E;\n\tMon, 9 Mar 2020 12:44:17 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA2821C1C0;\n\tMon, 9 Mar 2020 12:41:17 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 1E5701C1AF\n for <dev@dpdk.org>; Mon, 9 Mar 2020 12:41:15 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2020 04:41:15 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2020 04:41:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,533,1574150400\"; d=\"scan'208\";a=\"276483643\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Chinh T Cao <chinh.t.cao@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 9 Mar 2020 19:43:52 +0800", "Message-Id": "<20200309114357.31800-24-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "References": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 23/28] net/ice/base: support PHY persistent\n\tfeature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In this patch, we will modify the ice_copy_phy_caps_to_cfg(...) function\nto conditionally fill up the\nice_aqc_set_phy_cfg_data.module_compliance_enforcement with correct\nvalue, based on the PHY persistent feature.\n\nApply the ice_copy_phy_caps_to_cfg() function inside ice_set_fc()\n\nSigned-off-by: Chinh T Cao <chinh.t.cao@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 13 ++++---------\n 1 file changed, 4 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 25e205944..afc0bb413 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -2583,9 +2583,11 @@ ice_set_fc(struct ice_port_info *pi, u8 *aq_failures, bool ena_auto_link_update)\n \t\tgoto out;\n \t}\n \n+\tice_copy_phy_caps_to_cfg(pcaps, &cfg);\n+\n \t/* clear the old pause settings */\n-\tcfg.caps = pcaps->caps & ~(ICE_AQC_PHY_EN_TX_LINK_PAUSE |\n-\t\t\t\t ICE_AQC_PHY_EN_RX_LINK_PAUSE);\n+\tcfg.caps &= ~(ICE_AQC_PHY_EN_TX_LINK_PAUSE |\n+\t\t ICE_AQC_PHY_EN_RX_LINK_PAUSE);\n \n \t/* set the new capabilities */\n \tif (pi->fc.req_mode == ICE_FC_AUTO &&\n@@ -2608,13 +2610,6 @@ ice_set_fc(struct ice_port_info *pi, u8 *aq_failures, bool ena_auto_link_update)\n \t\t/* Auto restart link so settings take effect */\n \t\tif (ena_auto_link_update)\n \t\t\tcfg.caps |= ICE_AQ_PHY_ENA_AUTO_LINK_UPDT;\n-\t\t/* Copy over all the old settings */\n-\t\tcfg.phy_type_high = pcaps->phy_type_high;\n-\t\tcfg.phy_type_low = pcaps->phy_type_low;\n-\t\tcfg.low_power_ctrl_an = pcaps->low_power_ctrl_an;\n-\t\tcfg.eee_cap = pcaps->eee_cap;\n-\t\tcfg.eeer_value = pcaps->eeer_value;\n-\t\tcfg.link_fec_opt = pcaps->link_fec_options;\n \n \t\tstatus = ice_aq_set_phy_cfg(hw, pi, &cfg, NULL);\n \t\tif (status) {\n", "prefixes": [ "23/28" ] }