Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66435/?format=api
http://patches.dpdk.org/api/patches/66435/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-19-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309114357.31800-19-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309114357.31800-19-qi.z.zhang@intel.com", "date": "2020-03-09T11:43:47", "name": "[18/28] net/ice/bse: add AN masks to Get PHY Caps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e92e0a770e037c21fd68b25e2f6ba3a60954b372", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-19-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 8843, "url": "http://patches.dpdk.org/api/series/8843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8843", "date": "2020-03-09T11:43:29", "name": "update ice base code", "version": 1, "mbox": "http://patches.dpdk.org/series/8843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66435/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66435/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3ED72A052E;\n\tMon, 9 Mar 2020 12:43:29 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BCACA1C19B;\n\tMon, 9 Mar 2020 12:41:08 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 8049B1C19A\n for <dev@dpdk.org>; Mon, 9 Mar 2020 12:41:06 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2020 04:41:06 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2020 04:41:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,533,1574150400\"; d=\"scan'208\";a=\"276483612\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Lev Faerman <lev.faerman@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 9 Mar 2020 19:43:47 +0800", "Message-Id": "<20200309114357.31800-19-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "References": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 18/28] net/ice/bse: add AN masks to Get PHY Caps", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adds masks indicating AN clauses to the Get PHY Capabilities\ncommand. Changes the name of the low_power_ctrl field to be\nproperly descriptive of it being an AN field.\n\nSigned-off-by: Lev Faerman <lev.faerman@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_adminq_cmd.h | 7 +++++--\n drivers/net/ice/base/ice_common.c | 10 +++++-----\n drivers/net/ice/ice_ethdev.c | 2 +-\n 3 files changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h\nindex f6068a123..9375d615e 100644\n--- a/drivers/net/ice/base/ice_adminq_cmd.h\n+++ b/drivers/net/ice/base/ice_adminq_cmd.h\n@@ -1337,8 +1337,11 @@ struct ice_aqc_get_phy_caps_data {\n #define ICE_AQC_PHY_EN_LESM\t\t\t\tBIT(6)\n #define ICE_AQC_PHY_EN_AUTO_FEC\t\t\t\tBIT(7)\n #define ICE_AQC_PHY_CAPS_MASK\t\t\t\tMAKEMASK(0xff, 0)\n-\tu8 low_power_ctrl;\n+\tu8 low_power_ctrl_an;\n #define ICE_AQC_PHY_EN_D3COLD_LOW_POWER_AUTONEG\t\tBIT(0)\n+#define ICE_AQC_PHY_AN_EN_CLAUSE28\t\t\tBIT(1)\n+#define ICE_AQC_PHY_AN_EN_CLAUSE73\t\t\tBIT(2)\n+#define ICE_AQC_PHY_AN_EN_CLAUSE37\t\t\tBIT(3)\n \t__le16 eee_cap;\n #define ICE_AQC_PHY_EEE_EN_100BASE_TX\t\t\tBIT(0)\n #define ICE_AQC_PHY_EEE_EN_1000BASE_T\t\t\tBIT(1)\n@@ -1413,7 +1416,7 @@ struct ice_aqc_set_phy_cfg_data {\n #define ICE_AQ_PHY_ENA_AUTO_LINK_UPDT\tBIT(5)\n #define ICE_AQ_PHY_ENA_LESM\t\tBIT(6)\n #define ICE_AQ_PHY_ENA_AUTO_FEC\t\tBIT(7)\n-\tu8 low_power_ctrl;\n+\tu8 low_power_ctrl_an;\n \t__le16 eee_cap; /* Value from ice_aqc_get_phy_caps */\n \t__le16 eeer_value;\n \tu8 link_fec_opt; /* Use defines from ice_aqc_get_phy_caps */\ndiff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex 3fa2256e8..99f696211 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -2393,8 +2393,8 @@ ice_aq_set_phy_cfg(struct ice_hw *hw, struct ice_port_info *pi,\n \tice_debug(hw, ICE_DBG_LINK, \"phy_type_high = 0x%llx\\n\",\n \t\t (unsigned long long)LE64_TO_CPU(cfg->phy_type_high));\n \tice_debug(hw, ICE_DBG_LINK, \"caps = 0x%x\\n\", cfg->caps);\n-\tice_debug(hw, ICE_DBG_LINK, \"low_power_ctrl = 0x%x\\n\",\n-\t\t cfg->low_power_ctrl);\n+\tice_debug(hw, ICE_DBG_LINK, \"low_power_ctrl_an = 0x%x\\n\",\n+\t\t cfg->low_power_ctrl_an);\n \tice_debug(hw, ICE_DBG_LINK, \"eee_cap = 0x%x\\n\", cfg->eee_cap);\n \tice_debug(hw, ICE_DBG_LINK, \"eeer_value = 0x%x\\n\", cfg->eeer_value);\n \tice_debug(hw, ICE_DBG_LINK, \"link_fec_opt = 0x%x\\n\", cfg->link_fec_opt);\n@@ -2611,7 +2611,7 @@ ice_set_fc(struct ice_port_info *pi, u8 *aq_failures, bool ena_auto_link_update)\n \t\t/* Copy over all the old settings */\n \t\tcfg.phy_type_high = pcaps->phy_type_high;\n \t\tcfg.phy_type_low = pcaps->phy_type_low;\n-\t\tcfg.low_power_ctrl = pcaps->low_power_ctrl;\n+\t\tcfg.low_power_ctrl_an = pcaps->low_power_ctrl_an;\n \t\tcfg.eee_cap = pcaps->eee_cap;\n \t\tcfg.eeer_value = pcaps->eeer_value;\n \t\tcfg.link_fec_opt = pcaps->link_fec_options;\n@@ -2672,7 +2672,7 @@ ice_phy_caps_equals_cfg(struct ice_aqc_get_phy_caps_data *phy_caps,\n \tif (phy_caps->phy_type_low != phy_cfg->phy_type_low ||\n \t phy_caps->phy_type_high != phy_cfg->phy_type_high ||\n \t ((phy_caps->caps & caps_mask) != (phy_cfg->caps & cfg_mask)) ||\n-\t phy_caps->low_power_ctrl != phy_cfg->low_power_ctrl ||\n+\t phy_caps->low_power_ctrl_an != phy_cfg->low_power_ctrl_an ||\n \t phy_caps->eee_cap != phy_cfg->eee_cap ||\n \t phy_caps->eeer_value != phy_cfg->eeer_value ||\n \t phy_caps->link_fec_options != phy_cfg->link_fec_opt)\n@@ -2699,7 +2699,7 @@ ice_copy_phy_caps_to_cfg(struct ice_aqc_get_phy_caps_data *caps,\n \tcfg->phy_type_low = caps->phy_type_low;\n \tcfg->phy_type_high = caps->phy_type_high;\n \tcfg->caps = caps->caps;\n-\tcfg->low_power_ctrl = caps->low_power_ctrl;\n+\tcfg->low_power_ctrl_an = caps->low_power_ctrl_an;\n \tcfg->eee_cap = caps->eee_cap;\n \tcfg->eeer_value = caps->eeer_value;\n \tcfg->link_fec_opt = caps->link_fec_options;\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 88e7c9f0b..65015e9fd 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3173,7 +3173,7 @@ ice_force_phys_link_state(struct ice_hw *hw, bool link_up)\n \tcfg.phy_type_low = pcaps->phy_type_low;\n \tcfg.phy_type_high = pcaps->phy_type_high;\n \tcfg.caps = pcaps->caps | ICE_AQ_PHY_ENA_AUTO_LINK_UPDT;\n-\tcfg.low_power_ctrl = pcaps->low_power_ctrl;\n+\tcfg.low_power_ctrl_an = pcaps->low_power_ctrl_an;\n \tcfg.eee_cap = pcaps->eee_cap;\n \tcfg.eeer_value = pcaps->eeer_value;\n \tcfg.link_fec_opt = pcaps->link_fec_options;\n", "prefixes": [ "18/28" ] }{ "id": 66435, "url": "