Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/66426/?format=api
{ "id": 66426, "url": "http://patches.dpdk.org/api/patches/66426/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-10-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200309114357.31800-10-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200309114357.31800-10-qi.z.zhang@intel.com", "date": "2020-03-09T11:43:38", "name": "[09/28] net/ice/base: refactor a function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8230ce5114d02aaf023e26885ee6b0153f51f7e7", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200309114357.31800-10-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 8843, "url": "http://patches.dpdk.org/api/series/8843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8843", "date": "2020-03-09T11:43:29", "name": "update ice base code", "version": 1, "mbox": "http://patches.dpdk.org/series/8843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/66426/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/66426/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 215C2A052E;\n\tMon, 9 Mar 2020 12:42:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 43FDA1C0D2;\n\tMon, 9 Mar 2020 12:40:51 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 0E2191C0CC\n for <dev@dpdk.org>; Mon, 9 Mar 2020 12:40:48 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Mar 2020 04:40:48 -0700", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga002.fm.intel.com with ESMTP; 09 Mar 2020 04:40:46 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,533,1574150400\"; d=\"scan'208\";a=\"276483549\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Tony Nguyen <anthony.l.nguyen@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 9 Mar 2020 19:43:38 +0800", "Message-Id": "<20200309114357.31800-10-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "References": "<20200309114357.31800-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 09/28] net/ice/base: refactor a function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Refactor function ice_prof_bld_xlt2, a switch statement is better suited\nfor this situation and eliminates the need for the \"found\" variable.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flex_pipe.c | 21 +++++++++------------\n 1 file changed, 9 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c\nindex c18ccea48..5dd7a0d38 100644\n--- a/drivers/net/ice/base/ice_flex_pipe.c\n+++ b/drivers/net/ice/base/ice_flex_pipe.c\n@@ -4051,19 +4051,13 @@ ice_prof_bld_xlt2(enum ice_block blk, struct ice_buf_build *bld,\n \tstruct ice_chs_chg *tmp;\n \n \tLIST_FOR_EACH_ENTRY(tmp, chgs, ice_chs_chg, list_entry) {\n-\t\tbool found = false;\n-\n-\t\tif (tmp->type == ICE_VSIG_ADD)\n-\t\t\tfound = true;\n-\t\telse if (tmp->type == ICE_VSI_MOVE)\n-\t\t\tfound = true;\n-\t\telse if (tmp->type == ICE_VSIG_REM)\n-\t\t\tfound = true;\n-\n-\t\tif (found) {\n-\t\t\tstruct ice_xlt2_section *p;\n-\t\t\tu32 id;\n+\t\tstruct ice_xlt2_section *p;\n+\t\tu32 id;\n \n+\t\tswitch (tmp->type) {\n+\t\tcase ICE_VSIG_ADD:\n+\t\tcase ICE_VSI_MOVE:\n+\t\tcase ICE_VSIG_REM:\n \t\t\tid = ice_sect_id(blk, ICE_XLT2);\n \t\t\tp = (struct ice_xlt2_section *)\n \t\t\t\tice_pkg_buf_alloc_section(bld, id, sizeof(*p));\n@@ -4074,6 +4068,9 @@ ice_prof_bld_xlt2(enum ice_block blk, struct ice_buf_build *bld,\n \t\t\tp->count = CPU_TO_LE16(1);\n \t\t\tp->offset = CPU_TO_LE16(tmp->vsi);\n \t\t\tp->value[0] = CPU_TO_LE16(tmp->vsig);\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tbreak;\n \t\t}\n \t}\n \n", "prefixes": [ "09/28" ] }